Fix SafeHtmlBuilder.appendAttribute when the attribute is empty
If the attribute currently has no value we want to set it to
the supplied value. Previously the code was incorrectly using
the empty string in this case, resulting in a chain of append
calls producing no output.
Signed-off-by: Shawn O. Pearce <sop@google.com>
diff --git a/src/main/java/com/google/gwtexpui/safehtml/client/SafeHtmlBuilder.java b/src/main/java/com/google/gwtexpui/safehtml/client/SafeHtmlBuilder.java
index 5a3fdfd..a46a47e 100644
--- a/src/main/java/com/google/gwtexpui/safehtml/client/SafeHtmlBuilder.java
+++ b/src/main/java/com/google/gwtexpui/safehtml/client/SafeHtmlBuilder.java
@@ -225,7 +225,7 @@
public SafeHtmlBuilder appendAttribute(final String name, String value) {
if (value != null && value.length() > 0) {
final String e = getAttribute(name);
- return setAttribute(name, e.length() > 0 ? e + " " + value : e);
+ return setAttribute(name, e.length() > 0 ? e + " " + value : value);
}
return this;
}
