commit 30190077dc375cbc19de161a36a93db9bdc38e73
author Shawn O. Pearce <sop@google.com> Sun Mar 01 15:05:07 2009 -0800
committer Shawn O. Pearce <sop@google.com> Sun Mar 01 15:05:07 2009 -0800
tree 69a39dc38584779ded1fab0256baf32ba169af26
parent 46a7b809dd1b2432dcb0136e58884ae47e29f796

Hide SafeHtml.asString from client code

Converting a SafeHtml into a String may lead to unsafe patterns
such as calling setInnerHTML directly, possibly after doing an
unsafe string concatenation.  By hiding the method we reduce
the ability for client code to make this innocent mistake.

Signed-off-by: Shawn O. Pearce <sop@google.com>

src/main/java/com/google/gwtexpui/safehtml/client/SafeHtml.java

diff --git a/src/main/java/com/google/gwtexpui/safehtml/client/SafeHtml.java b/src/main/java/com/google/gwtexpui/safehtml/client/SafeHtml.java
index 311584a..eef4a96 100644
--- a/src/main/java/com/google/gwtexpui/safehtml/client/SafeHtml.java
+++ b/src/main/java/com/google/gwtexpui/safehtml/client/SafeHtml.java
@@ -115,5 +115,5 @@
   }
 
   /** @return a clean HTML string safe for inclusion in any context. */
-  public abstract String asString();
+  abstract String asString();
 }

src/main/java/com/google/gwtexpui/safehtml/client/SafeHtmlBuilder.java

diff --git a/src/main/java/com/google/gwtexpui/safehtml/client/SafeHtmlBuilder.java b/src/main/java/com/google/gwtexpui/safehtml/client/SafeHtmlBuilder.java
index a46a47e..238a102 100644
--- a/src/main/java/com/google/gwtexpui/safehtml/client/SafeHtmlBuilder.java
+++ b/src/main/java/com/google/gwtexpui/safehtml/client/SafeHtmlBuilder.java
@@ -361,7 +361,7 @@
   }
 
   @Override
-  public String asString() {
+  String asString() {
     return cb.toString();
   }
 

src/main/java/com/google/gwtexpui/safehtml/client/SafeHtmlString.java

diff --git a/src/main/java/com/google/gwtexpui/safehtml/client/SafeHtmlString.java b/src/main/java/com/google/gwtexpui/safehtml/client/SafeHtmlString.java
index 781e494..4d500fe 100644
--- a/src/main/java/com/google/gwtexpui/safehtml/client/SafeHtmlString.java
+++ b/src/main/java/com/google/gwtexpui/safehtml/client/SafeHtmlString.java
@@ -22,7 +22,7 @@
   }
 
   @Override
-  public String asString() {
+  String asString() {
     return html;
   }
 }