Compare java.time types directly instead of decomposing and comparing longs
This avoids potential bugs due to precision loss when decomposing.
PiperOrigin-RevId: 324113596
Change-Id: I3bbcf86c6b533520479e26628854abd38214c420
diff --git a/javatests/com/google/gitiles/ConfigUtilTest.java b/javatests/com/google/gitiles/ConfigUtilTest.java
index d2e3ac7..0f5d6e9 100644
--- a/javatests/com/google/gitiles/ConfigUtilTest.java
+++ b/javatests/com/google/gitiles/ConfigUtilTest.java
@@ -35,7 +35,7 @@
config.setString("core", "dht", "timeout", "500 ms");
t = getDuration(config, "core", "dht", "timeout", def);
- assertThat(t.toMillis()).isEqualTo(500);
+ assertThat(t).isEqualTo(Duration.ofMillis(500));
config.setString("core", "dht", "timeout", "5.2 sec");
try {
@@ -47,7 +47,7 @@
config.setString("core", "dht", "timeout", "1 min");
t = getDuration(config, "core", "dht", "timeout", def);
- assertThat(t.toMillis()).isEqualTo(60000);
+ assertThat(t).isEqualTo(Duration.ofMinutes(1));
}
@Test
@@ -57,15 +57,15 @@
Duration t;
t = getDuration(config, "core", null, "blank", def);
- assertThat(t.toMillis()).isEqualTo(1000);
+ assertThat(t).isEqualTo(Duration.ofSeconds(1));
config.setString("core", null, "blank", "");
t = getDuration(config, "core", null, "blank", def);
- assertThat(t.toMillis()).isEqualTo(1000);
+ assertThat(t).isEqualTo(Duration.ofSeconds(1));
config.setString("core", null, "blank", " ");
t = getDuration(config, "core", null, "blank", def);
- assertThat(t.toMillis()).isEqualTo(1000);
+ assertThat(t).isEqualTo(Duration.ofSeconds(1));
}
@Test