commit cfa034a4b3efcbe84f2e9e039e9839164881a280
author Kurt Alfred Kluever <kak@google.com> Thu Jul 30 16:59:57 2020 -0700
committer Jonathan Nieder <jrn@google.com> Sat Aug 29 01:00:20 2020 +0000
tree 689b0846ee9b9a33c9e6ad2866d41bb20c77b181
parent 5eb9439f9db0da0ce6fbf1c127dfc32e0b35175d

Compare java.time types directly instead of decomposing and comparing longs

This avoids potential bugs due to precision loss when decomposing.

PiperOrigin-RevId: 324113596
Change-Id: I3bbcf86c6b533520479e26628854abd38214c420

javatests/com/google/gitiles/ConfigUtilTest.java

diff --git a/javatests/com/google/gitiles/ConfigUtilTest.java b/javatests/com/google/gitiles/ConfigUtilTest.java
index d2e3ac7..0f5d6e9 100644
--- a/javatests/com/google/gitiles/ConfigUtilTest.java
+++ b/javatests/com/google/gitiles/ConfigUtilTest.java
@@ -35,7 +35,7 @@
 
     config.setString("core", "dht", "timeout", "500 ms");
     t = getDuration(config, "core", "dht", "timeout", def);
-    assertThat(t.toMillis()).isEqualTo(500);
+    assertThat(t).isEqualTo(Duration.ofMillis(500));
 
     config.setString("core", "dht", "timeout", "5.2 sec");
     try {
@@ -47,7 +47,7 @@
 
     config.setString("core", "dht", "timeout", "1 min");
     t = getDuration(config, "core", "dht", "timeout", def);
-    assertThat(t.toMillis()).isEqualTo(60000);
+    assertThat(t).isEqualTo(Duration.ofMinutes(1));
   }
 
   @Test
@@ -57,15 +57,15 @@
     Duration t;
 
     t = getDuration(config, "core", null, "blank", def);
-    assertThat(t.toMillis()).isEqualTo(1000);
+    assertThat(t).isEqualTo(Duration.ofSeconds(1));
 
     config.setString("core", null, "blank", "");
     t = getDuration(config, "core", null, "blank", def);
-    assertThat(t.toMillis()).isEqualTo(1000);
+    assertThat(t).isEqualTo(Duration.ofSeconds(1));
 
     config.setString("core", null, "blank", " ");
     t = getDuration(config, "core", null, "blank", def);
-    assertThat(t.toMillis()).isEqualTo(1000);
+    assertThat(t).isEqualTo(Duration.ofSeconds(1));
   }
 
   @Test