Fix ReferenceEquality Error Prone errors The newer Error Prone shipped with rules_java 9.8.0 flags several reference-equality comparisons. Fix them following the conventions already used in this codebase, keeping the check at ERROR: - JGit FileMode comparisons use value equality (FileMode.X.equals), matching PathServlet/ReadmeHelper: ArchiveServlet, PathServlet, ImageLoader. - commonmark AST nodes are intentionally compared by identity, so suppress the check on those methods (as Revision already does): MarkdownToHtml, NamedAnchorExtension, SmartQuotedExtension. Change-Id: Ie852ea8484717501e6b8302c71588a2bb45a230b

diff --git a/java/com/google/gitiles/ArchiveServlet.java b/java/com/google/gitiles/ArchiveServlet.java
index ed9fedd..39d7556 100644
--- a/java/com/google/gitiles/ArchiveServlet.java
+++ b/java/com/google/gitiles/ArchiveServlet.java

@@ -80,7 +80,7 @@
         return tree;
       }
       TreeWalk tw = TreeWalk.forPath(rw.getObjectReader(), view.getPathPart(), tree);
-      if (tw == null || tw.getFileMode(0) != FileMode.TREE) {
+      if (tw == null || !FileMode.TREE.equals(tw.getRawMode(0))) {
         return ObjectId.zeroId();
       }
       return tw.getObjectId(0);

diff --git a/java/com/google/gitiles/PathServlet.java b/java/com/google/gitiles/PathServlet.java
index a5c46e2..d742dad 100644
--- a/java/com/google/gitiles/PathServlet.java
+++ b/java/com/google/gitiles/PathServlet.java

@@ -533,7 +533,7 @@
   private @Nullable CanonicalTreeParser getOnlyChildSubtree(
       ObjectReader reader, ObjectId id, byte[] prefix) throws IOException {
     CanonicalTreeParser p = new CanonicalTreeParser(prefix, reader, id);
-    if (p.eof() || p.getEntryFileMode() != FileMode.TREE) {
+    if (p.eof() || !FileMode.TREE.equals(p.getEntryRawMode())) {
       return null;
     }
     p.next(1);

diff --git a/java/com/google/gitiles/doc/ImageLoader.java b/java/com/google/gitiles/doc/ImageLoader.java
index 0a1cc3d..f3cb84f 100644
--- a/java/com/google/gitiles/doc/ImageLoader.java
+++ b/java/com/google/gitiles/doc/ImageLoader.java

@@ -74,7 +74,7 @@
 
     try {
       TreeWalk tw = TreeWalk.forPath(reader, path, root);
-      if (tw == null || tw.getFileMode(0) != FileMode.REGULAR_FILE) {
+      if (tw == null || !FileMode.REGULAR_FILE.equals(tw.getRawMode(0))) {
         return null;
       }
 

diff --git a/java/com/google/gitiles/doc/MarkdownToHtml.java b/java/com/google/gitiles/doc/MarkdownToHtml.java
index f0518e6..03cc78b 100644
--- a/java/com/google/gitiles/doc/MarkdownToHtml.java
+++ b/java/com/google/gitiles/doc/MarkdownToHtml.java

@@ -185,6 +185,7 @@
     visitChildren(node);
   }
 
+  @SuppressWarnings("ReferenceEquality") // commonmark AST nodes compared by identity.
   private void visit(BlockNote node) {
     html.open("div").attribute("class", node.getClassName());
     Node f = node.getFirstChild();

diff --git a/java/com/google/gitiles/doc/NamedAnchorExtension.java b/java/com/google/gitiles/doc/NamedAnchorExtension.java
index cd02733..5bb4a79 100644
--- a/java/com/google/gitiles/doc/NamedAnchorExtension.java
+++ b/java/com/google/gitiles/doc/NamedAnchorExtension.java

@@ -55,6 +55,7 @@
       return 1;
     }
 
+    @SuppressWarnings("ReferenceEquality") // commonmark AST nodes compared by identity.
     @Override
     public int process(DelimiterRun openingRun, DelimiterRun closingRun) {
       Text opener = openingRun.getOpener();

diff --git a/java/com/google/gitiles/doc/SmartQuotedExtension.java b/java/com/google/gitiles/doc/SmartQuotedExtension.java
index a8e7f13..bc3403d 100644
--- a/java/com/google/gitiles/doc/SmartQuotedExtension.java
+++ b/java/com/google/gitiles/doc/SmartQuotedExtension.java

@@ -39,6 +39,7 @@
     builder.customDelimiterProcessor(new QuotedProcessor(DOUBLE, '"'));
   }
 
+  @SuppressWarnings("ReferenceEquality") // commonmark AST nodes compared by identity.
   private static void quote(SmartQuoted.Type type, Text opener, Text closer) {
     SmartQuoted quote = new SmartQuoted();
     quote.setType(type);