Revert "tools: cpplint: Add Android.bp to build cpplint as python_binary_host" This reverts commit dfda9bcf07fbab25efe44fe603f6ebe9ed643ea7. Reason for revert: The development flow & goals of repohooks is unable to support the needs of art. The main branch of repohooks is used in all branches of Android, including very old ones, so we have to stay compatible. That means the tool behavior, and in Android.bp syntax. Older branches will fail with newer cpplint, and older soong tooling does not recognize newer keywords in this Android.bp. Any tools we want to execute at build time will need to be vendored in directly in external/ so they stay pinned/locked when branches are cut. Bug: 396027786 Bug: 396308027 Change-Id: Iae0f308c602504226c1e044ebdd0fb574ab50903 Reviewed-on: https://android-review.googlesource.com/c/platform/tools/repohooks/+/3528670 Reviewed-by: Leandro Lovisolo <lovisolo@google.com> Open-Source-Licensing: Lint 🤖 <ayeaye-gerrit@google.com> Performance: CrystalBall Performance Presubmit <android-crystalball-presubmit-eng@google.com> Presubmit-Verified: Treehugger Robot <android-test-infra-workplan-finisher@system.gserviceaccount.com> Lint: Lint 🤖 <ayeaye-gerrit@google.com> Autosubmit: Mike Frysinger <vapier@google.com>
diff --git a/tools/Android.bp b/tools/Android.bp deleted file mode 100644 index b43dd9b..0000000 --- a/tools/Android.bp +++ /dev/null
@@ -1,30 +0,0 @@ -// -// Copyright (C) 2025 The Android Open Source Project -// -// Licensed under the Apache License, Version 2.0 (the "License"); -// you may not use this file except in compliance with the License. -// You may obtain a copy of the License at -// -// http://www.apache.org/licenses/LICENSE-2.0 -// -// Unless required by applicable law or agreed to in writing, software -// distributed under the License is distributed on an "AS IS" BASIS, -// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -// See the License for the specific language governing permissions and -// limitations under the License. -// - -license { - name: "tools_repohooks_tools_cpplint_license", - visibility: [":__subpackages__"], - license_kinds: ["SPDX-license-identifier-BSD-3-Clause"], - license_text: [ - "LICENSE", - ], -} - -python_binary_host { - name: "cpplint", - srcs: ["cpplint.py"], - licenses: ["tools_repohooks_tools_cpplint_license"], -}
diff --git a/tools/LICENSE b/tools/LICENSE deleted file mode 100644 index b5fbfc7..0000000 --- a/tools/LICENSE +++ /dev/null
@@ -1,31 +0,0 @@ -File: cpplint.py - -Copyright (c) 2009 Google Inc. All rights reserved. - -Redistribution and use in source and binary forms, with or without -modification, are permitted provided that the following conditions are -met: - - * Redistributions of source code must retain the above copyright -notice, this list of conditions and the following disclaimer. - * Redistributions in binary form must reproduce the above -copyright notice, this list of conditions and the following disclaimer -in the documentation and/or other materials provided with the -distribution. - * Neither the name of Google Inc. nor the names of its -contributors may be used to endorse or promote products derived from -this software without specific prior written permission. - -THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS -"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT -LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR -A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT -OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, -SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT -LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, -DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY -THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT -(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE -OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. - --------------------------------------------------------------------