commit febe73ff16584578e3818bc35b5a3350ab672f77
author Ian Kasprzak <iankaz@google.com> Tue Jan 19 09:04:28 2021 -0800
committer Ian Kasprzak <iankaz@google.com> Tue Jan 19 20:35:56 2021 +0000
tree b45ce1f3a0fe2a6e3967ae592d6bffc60781da4f
parent e5670c881225ed025c77e0362a7c7edcc912ef9f

Update "evt" field to be logged as a string type.

Testing:
- Unit tests
- Verified git trace log has "evt": "2" (vs "evt": 2 previously)

Bug: https://crbug.com/gerrit/13966
Change-Id: I2e0c98dda0cccdd5cb6328105c11b93cd42676eb
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/294123
Reviewed-by: Jonathan Nieder <jrn@google.com>
Tested-by: Ian Kasprzak <iankaz@google.com>

git_trace2_event_log.py

diff --git a/git_trace2_event_log.py b/git_trace2_event_log.py
index dfbded1..fe34092 100644
--- a/git_trace2_event_log.py
+++ b/git_trace2_event_log.py
@@ -92,7 +92,7 @@
   def _AddVersionEvent(self):
     """Adds a 'version' event at the beginning of current log."""
     version_event = self._CreateEventDict('version')
-    version_event['evt'] = 2
+    version_event['evt'] = "2"
     version_event['exe'] = RepoSourceVersion()
     self._log.insert(0, version_event)
 

tests/test_git_trace2_event_log.py

diff --git a/tests/test_git_trace2_event_log.py b/tests/test_git_trace2_event_log.py
index 686802e..8fb38db 100644
--- a/tests/test_git_trace2_event_log.py
+++ b/tests/test_git_trace2_event_log.py
@@ -95,6 +95,8 @@
     # Check for 'version' event specific fields.
     self.assertIn('evt', version_event)
     self.assertIn('exe', version_event)
+    # Verify "evt" version field is a string.
+    self.assertIsInstance(version_event['evt'], str)
 
   def test_start_event(self):
     """Test and validate 'start' event data is valid.