manifest_xml: improve topdir accuracy.
Do not include a trailing path separator when submanifest_path is empty.
Bug: https://crbug.com/gerrit/16104
Change-Id: Ia65e355de25bdb1067fe50ab1d47db6e798d5a71
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/343674
Tested-by: LaMont Jones <lamontjones@google.com>
Reviewed-by: Mike Frysinger <vapier@google.com>
diff --git a/manifest_xml.py b/manifest_xml.py
index 84be8f4..ea274c7 100644
--- a/manifest_xml.py
+++ b/manifest_xml.py
@@ -358,7 +358,10 @@
self.repodir = os.path.abspath(repodir)
self._CheckLocalPath(submanifest_path)
- self.topdir = os.path.join(os.path.dirname(self.repodir), submanifest_path)
+ self.topdir = os.path.dirname(self.repodir)
+ if submanifest_path:
+ # This avoids a trailing os.path.sep when submanifest_path is empty.
+ self.topdir = os.path.join(self.topdir, submanifest_path)
if manifest_file != os.path.abspath(manifest_file):
raise ManifestParseError('manifest_file must be abspath')
self.manifestFile = manifest_file
