commit dc1b59d2c0a7ee00b7e6b111285360c4cff32d2b
author Mike Frysinger <vapier@google.com> Mon Sep 30 23:47:03 2019 -0400
committer Mike Frysinger <vapier@google.com> Tue Oct 01 05:43:51 2019 +0000
tree 504d0452e5a31556bbcc3b0f1a0e821001d22938
parent 71b0f312b15b597ab54d4d3bd6629efdcf188884

forall: exit 1 if we skip any repos

If a repo doesn't exist (e.g. an incomplete sync), make sure we exit
non-zero when they get skipped.

Change-Id: Ifff711e374416b1e6b9b8da4fdc6f14b27ced450
Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/239235
Reviewed-by: David Pursehouse <dpursehouse@collab.net>
Tested-by: Mike Frysinger <vapier@google.com>

subcmds/forall.py

diff --git a/subcmds/forall.py b/subcmds/forall.py
index 0be8d3b..c9de26b 100644
--- a/subcmds/forall.py
+++ b/subcmds/forall.py
@@ -323,10 +323,10 @@
     cwd = project['worktree']
 
   if not os.path.exists(cwd):
-    if (opt.project_header and opt.verbose) \
-    or not opt.project_header:
+    if ((opt.project_header and opt.verbose)
+        or not opt.project_header):
       print('skipping %s/' % project['relpath'], file=sys.stderr)
-    return
+    return 1
 
   if opt.project_header:
     stdin = subprocess.PIPE