Dave Borowitz | 938398f | 2018-09-14 14:14:25 -0700 | [diff] [blame] | 1 | load( |
| 2 | "@bazel_tools//tools/jdk:default_java_toolchain.bzl", |
| 3 | "JDK9_JVM_OPTS", |
| 4 | "default_java_toolchain", |
| 5 | ) |
David Ostrovsky | 4b60cd7 | 2018-08-26 15:53:01 +0200 | [diff] [blame] | 6 | |
Han-Wen Nienhuys | a223f5a | 2019-04-25 12:15:41 +0200 | [diff] [blame] | 7 | exports_files(["nongoogle.bzl"]) |
| 8 | |
David Ostrovsky | b81b4f7 | 2016-05-21 19:55:01 +0200 | [diff] [blame] | 9 | py_binary( |
David Ostrovsky | fa18907 | 2016-11-30 08:52:06 +0100 | [diff] [blame] | 10 | name = "merge_jars", |
| 11 | srcs = ["merge_jars.py"], |
| 12 | main = "merge_jars.py", |
| 13 | visibility = ["//visibility:public"], |
David Ostrovsky | b81b4f7 | 2016-05-21 19:55:01 +0200 | [diff] [blame] | 14 | ) |
David Ostrovsky | 4b60cd7 | 2018-08-26 15:53:01 +0200 | [diff] [blame] | 15 | |
David Ostrovsky | 4b60cd7 | 2018-08-26 15:53:01 +0200 | [diff] [blame] | 16 | default_java_toolchain( |
| 17 | name = "error_prone_warnings_toolchain", |
David Pursehouse | a5ca033 | 2018-11-02 08:24:16 +0900 | [diff] [blame] | 18 | bootclasspath = ["@bazel_tools//tools/jdk:platformclasspath.jar"], |
Dave Borowitz | 938398f | 2018-09-14 14:14:25 -0700 | [diff] [blame] | 19 | jvm_opts = JDK9_JVM_OPTS, |
David Ostrovsky | 4b60cd7 | 2018-08-26 15:53:01 +0200 | [diff] [blame] | 20 | package_configuration = [ |
| 21 | ":error_prone", |
| 22 | ], |
| 23 | visibility = ["//visibility:public"], |
| 24 | ) |
| 25 | |
Dave Borowitz | 3b78c07 | 2019-05-24 11:27:43 -0700 | [diff] [blame] | 26 | # Error Prone errors enabled by default; see ../.bazelrc for how this is |
| 27 | # enabled. This warnings list is originally based on: |
| 28 | # https://github.com/bazelbuild/BUILD_file_generator/blob/master/tools/bazel_defs/java.bzl |
| 29 | # However, feel free to add any additional errors. Thus far they have all been pretty useful. |
Dave Borowitz | cac4630 | 2019-05-24 09:54:18 -0700 | [diff] [blame] | 30 | java_package_configuration( |
| 31 | name = "error_prone", |
| 32 | javacopts = [ |
| 33 | "-XepDisableWarningsInGeneratedCode", |
Dave Borowitz | ccdc670 | 2019-05-24 10:14:03 -0700 | [diff] [blame] | 34 | "-Xep:AmbiguousMethodReference:ERROR", |
| 35 | "-Xep:BadAnnotationImplementation:ERROR", |
| 36 | "-Xep:BadComparable:ERROR", |
| 37 | "-Xep:BoxedPrimitiveConstructor:ERROR", |
| 38 | "-Xep:CannotMockFinalClass:ERROR", |
Dave Borowitz | ae99a1b | 2019-05-24 10:15:40 -0700 | [diff] [blame] | 39 | "-Xep:ClassCanBeStatic:ERROR", |
Dave Borowitz | ccdc670 | 2019-05-24 10:14:03 -0700 | [diff] [blame] | 40 | "-Xep:ClassNewInstance:ERROR", |
Dave Borowitz | 9601572 | 2019-05-24 10:16:41 -0700 | [diff] [blame] | 41 | "-Xep:DefaultCharset:ERROR", |
Dave Borowitz | ccdc670 | 2019-05-24 10:14:03 -0700 | [diff] [blame] | 42 | "-Xep:DoubleCheckedLocking:ERROR", |
| 43 | "-Xep:ElementsCountedInLoop:ERROR", |
Dave Borowitz | 3cf3962 | 2019-05-24 10:17:44 -0700 | [diff] [blame] | 44 | "-Xep:DoubleCheckedLocking:ERROR", |
| 45 | "-Xep:ElementsCountedInLoop:ERROR", |
| 46 | "-Xep:EqualsHashCode:ERROR", |
| 47 | "-Xep:EqualsIncompatibleType:ERROR", |
| 48 | "-Xep:ExpectedExceptionChecker:ERROR", |
| 49 | "-Xep:Finally:ERROR", |
Dave Borowitz | 0c5fdd7 | 2019-05-24 10:22:02 -0700 | [diff] [blame] | 50 | "-Xep:FloatingPointLiteralPrecision:ERROR", |
| 51 | "-Xep:FragmentInjection:ERROR", |
| 52 | "-Xep:FragmentNotInstantiable:ERROR", |
| 53 | "-Xep:FunctionalInterfaceClash:ERROR", |
Dave Borowitz | ef04f0e6 | 2019-05-24 10:42:22 -0700 | [diff] [blame] | 54 | "-Xep:FutureReturnValueIgnored:ERROR", |
Dave Borowitz | f66892a | 2019-05-24 10:44:32 -0700 | [diff] [blame] | 55 | "-Xep:GetClassOnEnum:ERROR", |
Dave Borowitz | 0c5fdd7 | 2019-05-24 10:22:02 -0700 | [diff] [blame] | 56 | "-Xep:ImmutableAnnotationChecker:ERROR", |
Dave Borowitz | 0b9e581 | 2019-05-24 10:37:36 -0700 | [diff] [blame] | 57 | "-Xep:ImmutableEnumChecker:ERROR", |
Dave Borowitz | 0c5fdd7 | 2019-05-24 10:22:02 -0700 | [diff] [blame] | 58 | "-Xep:IncompatibleModifiers:ERROR", |
| 59 | "-Xep:InjectOnConstructorOfAbstractClass:ERROR", |
Dave Borowitz | b7769f3 | 2019-05-24 10:46:17 -0700 | [diff] [blame] | 60 | "-Xep:InputStreamSlowMultibyteRead:ERROR", |
| 61 | "-Xep:IterableAndIterator:ERROR", |
| 62 | "-Xep:JUnit3FloatingPointComparisonWithoutDelta:ERROR", |
| 63 | "-Xep:JUnitAmbiguousTestClass:ERROR", |
| 64 | "-Xep:LiteralClassName:ERROR", |
| 65 | "-Xep:MissingCasesInEnumSwitch:ERROR", |
| 66 | "-Xep:MissingFail:ERROR", |
Dave Borowitz | dc00c1d | 2019-05-24 10:48:49 -0700 | [diff] [blame] | 67 | "-Xep:MissingOverride:ERROR", |
Dave Borowitz | b7769f3 | 2019-05-24 10:46:17 -0700 | [diff] [blame] | 68 | "-Xep:MutableConstantField:ERROR", |
Dave Borowitz | cd7efe1 | 2019-05-24 10:52:43 -0700 | [diff] [blame] | 69 | "-Xep:NarrowingCompoundAssignment:ERROR", |
Dave Borowitz | 2bc50b4 | 2019-05-24 10:56:59 -0700 | [diff] [blame] | 70 | "-Xep:NonAtomicVolatileUpdate:ERROR", |
| 71 | "-Xep:NonOverridingEquals:ERROR", |
| 72 | "-Xep:NullableConstructor:ERROR", |
| 73 | "-Xep:NullablePrimitive:ERROR", |
| 74 | "-Xep:NullableVoid:ERROR", |
Dave Borowitz | b21dde3 | 2019-05-24 10:57:09 -0700 | [diff] [blame] | 75 | "-Xep:OperatorPrecedence:ERROR", |
Dave Borowitz | 2bc50b4 | 2019-05-24 10:56:59 -0700 | [diff] [blame] | 76 | "-Xep:OverridesGuiceInjectableMethod:ERROR", |
| 77 | "-Xep:PreconditionsInvalidPlaceholder:ERROR", |
| 78 | "-Xep:ProtoFieldPreconditionsCheckNotNull:ERROR", |
| 79 | "-Xep:ProtocolBufferOrdinal:ERROR", |
Dave Borowitz | b964049 | 2019-05-24 11:24:32 -0700 | [diff] [blame] | 80 | "-Xep:ReferenceEquality:ERROR", |
Dave Borowitz | 425ad6e | 2019-05-24 11:00:18 -0700 | [diff] [blame] | 81 | "-Xep:RequiredModifiers:ERROR", |
| 82 | "-Xep:ShortCircuitBoolean:ERROR", |
| 83 | "-Xep:SimpleDateFormatConstant:ERROR", |
| 84 | "-Xep:StaticGuardedByInstance:ERROR", |
Dave Borowitz | ccdc670 | 2019-05-24 10:14:03 -0700 | [diff] [blame] | 85 | "-Xep:StringEquality:ERROR", |
Dave Borowitz | b13bec9 | 2019-05-24 11:16:54 -0700 | [diff] [blame] | 86 | "-Xep:SynchronizeOnNonFinalField:ERROR", |
Dave Borowitz | 425ad6e | 2019-05-24 11:00:18 -0700 | [diff] [blame] | 87 | "-Xep:TruthConstantAsserts:ERROR", |
| 88 | "-Xep:TypeParameterShadowing:ERROR", |
Dave Borowitz | b31519f | 2019-05-24 11:05:18 -0700 | [diff] [blame] | 89 | "-Xep:TypeParameterUnusedInFormals:ERROR", |
Dave Borowitz | 425ad6e | 2019-05-24 11:00:18 -0700 | [diff] [blame] | 90 | "-Xep:URLEqualsHashCode:ERROR", |
| 91 | "-Xep:UnsynchronizedOverridesSynchronized:ERROR", |
| 92 | "-Xep:WaitNotInLoop:ERROR", |
Dave Borowitz | cac4630 | 2019-05-24 09:54:18 -0700 | [diff] [blame] | 93 | "-Xep:WildcardImport:ERROR", |
| 94 | ], |
| 95 | packages = ["error_prone_packages"], |
| 96 | ) |
| 97 | |
David Ostrovsky | 4b60cd7 | 2018-08-26 15:53:01 +0200 | [diff] [blame] | 98 | package_group( |
| 99 | name = "error_prone_packages", |
| 100 | packages = [ |
| 101 | "//java/...", |
| 102 | "//javatests/...", |
David Pursehouse | df7c481 | 2019-05-27 13:29:03 +0900 | [diff] [blame] | 103 | "//plugins/codemirror-editor/...", |
| 104 | "//plugins/commit-message-length-validator/...", |
| 105 | "//plugins/delete-project/...", |
| 106 | "//plugins/download-commands/...", |
| 107 | "//plugins/gitiles/...", |
| 108 | "//plugins/hooks/...", |
| 109 | "//plugins/plugin-manager/...", |
| 110 | "//plugins/replication/...", |
| 111 | "//plugins/reviewnotes/...", |
| 112 | "//plugins/singleusergroup/...", |
| 113 | "//plugins/webhooks/...", |
David Ostrovsky | 4b60cd7 | 2018-08-26 15:53:01 +0200 | [diff] [blame] | 114 | ], |
| 115 | ) |