Edwin Kempin | 4fd84c9 | 2014-04-30 13:23:15 +0200 | [diff] [blame] | 1 | = Review UI |
| 2 | |
| 3 | Reviewing changes is an important task and the Gerrit Web UI provides |
| 4 | many functionalities to make the review process comfortable and |
| 5 | efficient. This is a guide through the review UI that explains the |
| 6 | different functions and UI elements. |
| 7 | |
| 8 | [[change-screen]] |
| 9 | == Change Screen |
| 10 | |
| 11 | The change screen shows the details of a single change and provides |
| 12 | various actions on it. |
| 13 | |
| 14 | image::images/user-review-ui-change-screen.png[width=800, link="images/user-review-ui-change-screen.png"] |
| 15 | |
| 16 | [[commit-message]] |
| 17 | === Commit Message Block |
| 18 | |
| 19 | The focus of the change screen is on the commit message since this is |
| 20 | the most important information about a change. The numeric change ID |
| 21 | and the change status are displayed right above the commit message. |
| 22 | |
| 23 | image::images/user-review-ui-change-screen-commit-message.png[width=800, link="images/user-review-ui-change-screen-commit-message.png"] |
| 24 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 25 | [[permalink]] |
Edwin Kempin | 4fd84c9 | 2014-04-30 13:23:15 +0200 | [diff] [blame] | 26 | The numeric change ID is a link to the change and clicking on it |
| 27 | refreshes the change screen. By copying the link location you can get |
| 28 | the permalink of the change. |
| 29 | |
| 30 | image::images/user-review-ui-change-screen-permalink.png[width=800, link="images/user-review-ui-change-screen-permalink.png"] |
| 31 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 32 | [[change-status]] |
Edwin Kempin | 4fd84c9 | 2014-04-30 13:23:15 +0200 | [diff] [blame] | 33 | The change status shows the state of the change: |
| 34 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 35 | - [[needs]]`Needs <label>`: |
Edwin Kempin | 4fd84c9 | 2014-04-30 13:23:15 +0200 | [diff] [blame] | 36 | + |
| 37 | The change is in review and an approval on the shown label is still |
| 38 | required to make the change submittable. |
| 39 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 40 | - [[not]]`Not <label>`: |
Edwin Kempin | 4fd84c9 | 2014-04-30 13:23:15 +0200 | [diff] [blame] | 41 | + |
| 42 | The change is in review and a veto vote on the shown label is |
| 43 | preventing the submit. |
| 44 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 45 | - [[not-current]]`Not Current`: |
Edwin Kempin | 4fd84c9 | 2014-04-30 13:23:15 +0200 | [diff] [blame] | 46 | + |
| 47 | The currently viewed patch set is outdated. |
| 48 | + |
| 49 | Please note that some operations, like voting, are not available on |
| 50 | outdated patch sets, but only on the current patch set. |
| 51 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 52 | - [[ready-to-submit]]`Ready to Submit`: |
Edwin Kempin | 4fd84c9 | 2014-04-30 13:23:15 +0200 | [diff] [blame] | 53 | + |
| 54 | The change has all necessary approvals and may be submitted. |
| 55 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 56 | - [[merged]]`Merged`: |
Edwin Kempin | 4fd84c9 | 2014-04-30 13:23:15 +0200 | [diff] [blame] | 57 | + |
| 58 | The change was successfully merged into the destination branch. |
| 59 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 60 | - [[abandoned]]`Abandoned`: |
Edwin Kempin | 4fd84c9 | 2014-04-30 13:23:15 +0200 | [diff] [blame] | 61 | + |
| 62 | The change was abandoned. |
| 63 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 64 | - [[draft]]`Draft`: |
Edwin Kempin | 4fd84c9 | 2014-04-30 13:23:15 +0200 | [diff] [blame] | 65 | + |
| 66 | The change is a draft that is only visible to the change owner, the |
| 67 | reviewers that were explicitly added to the change, and users who have |
| 68 | the link:access-control.html#category_view_drafts[View Drafts] global |
| 69 | capability assigned. |
| 70 | |
| 71 | [[commit-info]] |
| 72 | === Commit Info Block |
| 73 | |
| 74 | The commit info block shows information about the commit of the |
| 75 | currently viewed patch set. |
| 76 | |
| 77 | It displays the author and the committer as links to a list of this |
| 78 | person's changes that have the same status as the currently viewed |
| 79 | change. |
| 80 | |
Orgad Shaneh | 306ed3c | 2014-07-20 08:58:28 +0300 | [diff] [blame] | 81 | The commit ID, the parent commit(s) and the link:user-changeid.html[Change-Id] are |
Edwin Kempin | 4fd84c9 | 2014-04-30 13:23:15 +0200 | [diff] [blame] | 82 | displayed with a copy-to-clipboard icon that allows the ID to be copied |
| 83 | into the clipboard. |
| 84 | |
Dave Borowitz | a3d6788 | 2015-06-05 15:22:23 -0700 | [diff] [blame] | 85 | If a Git web browser, such as gitweb or Gitiles, is configured, there |
Edwin Kempin | 4fd84c9 | 2014-04-30 13:23:15 +0200 | [diff] [blame] | 86 | is also a link to the commit in the Git web browser. |
| 87 | |
| 88 | image::images/user-review-ui-change-screen-commit-info.png[width=800, link="images/user-review-ui-change-screen-commit-info.png"] |
| 89 | |
Orgad Shaneh | 306ed3c | 2014-07-20 08:58:28 +0300 | [diff] [blame] | 90 | If a merge commit is viewed this is highlighted by an icon. |
Edwin Kempin | b6c2a3b | 2014-05-14 10:37:17 +0200 | [diff] [blame] | 91 | |
| 92 | image::images/user-review-ui-change-screen-commit-info-merge-commit.png[width=800, link="images/user-review-ui-change-screen-commit-info-merge-commit.png"] |
| 93 | |
Edwin Kempin | f1a84f9 | 2014-04-30 15:37:48 +0200 | [diff] [blame] | 94 | [[change-info]] |
| 95 | === Change Info Block |
| 96 | |
| 97 | The change info block contains detailed information about the change |
| 98 | and offers actions on the change. |
| 99 | |
| 100 | image::images/user-review-ui-change-screen-change-info.png[width=800, link="images/user-review-ui-change-screen-change-info.png"] |
| 101 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 102 | - [[change-owner]]Change Owner: |
Edwin Kempin | f1a84f9 | 2014-04-30 15:37:48 +0200 | [diff] [blame] | 103 | + |
| 104 | The owner of the change is displayed as a link to a list of the owner's |
| 105 | changes that have the same status as the currently viewed change. |
| 106 | + |
| 107 | image::images/user-review-ui-change-screen-change-info-owner.png[width=800, link="images/user-review-ui-change-screen-change-info-owner.png"] |
| 108 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 109 | - [[reviewers]]Reviewers: |
Edwin Kempin | f1a84f9 | 2014-04-30 15:37:48 +0200 | [diff] [blame] | 110 | + |
| 111 | The reviewers of the change are displayed as chip tokens. |
| 112 | + |
| 113 | For each reviewer there is a tooltip that shows on which labels the |
| 114 | reviewer is allowed to vote. |
| 115 | + |
| 116 | New reviewers can be added by clicking on the `Add...` button. Typing |
| 117 | into the pop-up text field activates auto completion of user and group |
| 118 | names. |
| 119 | + |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 120 | [[remove-reviewer]] |
Edwin Kempin | f1a84f9 | 2014-04-30 15:37:48 +0200 | [diff] [blame] | 121 | Reviewers can be removed from the change by clicking on the `x` icon |
| 122 | in the reviewer's chip token. Removing a reviewer also removes the |
| 123 | current votes of the reviewer. The removal of votes is recorded as a |
| 124 | message on the change. |
| 125 | + |
| 126 | Removing reviewers is protected by permissions: |
| 127 | |
| 128 | ** Users can always remove themselves. |
| 129 | ** The change owner may remove any zero or positive score. |
| 130 | ** Users with the link:access-control.html#category_remove_reviewer[ |
| 131 | Remove Reviewer] access right, the branch owner, the project owner |
| 132 | and Gerrit administrators may remove anyone. |
| 133 | |
| 134 | + |
| 135 | image::images/user-review-ui-change-screen-change-info-reviewers.png[width=800, link="images/user-review-ui-change-screen-change-info-reviewers.png"] |
| 136 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 137 | - [[project-branch-topic]]Project / Branch / Topic: |
Edwin Kempin | f1a84f9 | 2014-04-30 15:37:48 +0200 | [diff] [blame] | 138 | + |
| 139 | The name of the project for which the change was done is displayed as a |
| 140 | link to the link:user-dashboards.html#project-default-dashboard[default |
| 141 | dashboard] of the project. If no default dashboard is defined, the link |
| 142 | opens a list of open changes on the project. |
| 143 | + |
| 144 | Clicking on the settings icon on the right side navigates to the |
| 145 | project administration screen. |
| 146 | + |
| 147 | The name of the destination branch is displayed as a link to a list |
| 148 | with all changes on this branch that have the same status as the |
| 149 | currently viewed change. |
| 150 | + |
| 151 | If a topic was assigned to the change it is displayed below the branch. |
| 152 | By clicking on the edit icon the topic can be set. This requires the |
| 153 | link:access-control.html#category_edit_topic_name[Edit Topic Name] |
| 154 | access right. To be able to set a topic on a closed change, the |
| 155 | `Edit Topic Name` must be assigned with the `force` flag. |
| 156 | + |
| 157 | image::images/user-review-ui-change-screen-change-info-project-branch-topic.png[width=800, link="images/user-review-ui-change-screen-change-info-project-branch-topic.png"] |
| 158 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 159 | - [[submit-strategy]]Submit Strategy: |
Edwin Kempin | f1a84f9 | 2014-04-30 15:37:48 +0200 | [diff] [blame] | 160 | + |
| 161 | The link:project-setup.html#submit_type[submit strategy] that will be |
| 162 | used to submit the change. The submit strategy is only displayed for |
| 163 | open changes. |
| 164 | + |
| 165 | image::images/user-review-ui-change-screen-change-info-submit-strategy.png[width=800, link="images/user-review-ui-change-screen-change-info-submit-strategy.png"] |
| 166 | + |
| 167 | If a change cannot be merged due to path conflicts this is highlighted |
| 168 | by a bold red `Cannot Merge` label. |
| 169 | + |
| 170 | image::images/user-review-ui-change-screen-change-info-cannot-merge.png[width=800, link="images/user-review-ui-change-screen-change-info-cannot-merge.png"] |
| 171 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 172 | - [[update-time]]Time of Last Update: |
Edwin Kempin | f1a84f9 | 2014-04-30 15:37:48 +0200 | [diff] [blame] | 173 | + |
| 174 | image::images/user-review-ui-change-screen-change-info-last-update.png[width=800, link="images/user-review-ui-change-screen-change-info-last-update.png"] |
| 175 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 176 | - [[actions]]Actions: |
Edwin Kempin | f1a84f9 | 2014-04-30 15:37:48 +0200 | [diff] [blame] | 177 | + |
| 178 | Depending on the change state and the permissions of the user, different |
| 179 | actions are available on the change: |
| 180 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 181 | ** [[submit]]`Submit`: |
Edwin Kempin | f1a84f9 | 2014-04-30 15:37:48 +0200 | [diff] [blame] | 182 | + |
| 183 | Submits the change and adds it to the merge queue. If possible the |
| 184 | change is merged into the destination branch. |
| 185 | + |
David Pursehouse | 53b1bd0 | 2014-05-09 11:18:08 +0900 | [diff] [blame] | 186 | The `Submit` button is available if the change is submittable and |
Edwin Kempin | f1a84f9 | 2014-04-30 15:37:48 +0200 | [diff] [blame] | 187 | the link:access-control.html#category_submit[Submit] access right is |
| 188 | assigned. |
Edwin Kempin | f1a84f9 | 2014-04-30 15:37:48 +0200 | [diff] [blame] | 189 | |
Andrew Bonventre | 4af9d8c | 2016-05-26 15:08:32 -0400 | [diff] [blame] | 190 | ** [[revert]]`Revert`: |
| 191 | + |
| 192 | Reverts the change via creating a new one. |
| 193 | + |
| 194 | The `Revert` button is available if the change has been submitted. |
| 195 | + |
| 196 | When the `Revert` button is pressed, a panel will appear to allow |
| 197 | the user to enter a commit message for the reverting change. |
| 198 | + |
| 199 | Once a revert change is created, the original author and any reviewers |
| 200 | of the original change are added as reviewers and a message is posted |
| 201 | to the original change linking to the revert. |
| 202 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 203 | ** [[abandon]]`Abandon`: |
Edwin Kempin | f1a84f9 | 2014-04-30 15:37:48 +0200 | [diff] [blame] | 204 | + |
| 205 | Abandons the change. |
| 206 | + |
| 207 | The `Abandon` button is only available if the change is open and the |
| 208 | link:access-control.html#category_abandon[Abandon] access right is |
| 209 | assigned. |
| 210 | + |
| 211 | When a change is abandoned, a panel appears that allows one to type a |
| 212 | comment message to explain why the change is being abandoned. |
| 213 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 214 | ** [[restore]]`Restore`: |
Edwin Kempin | f1a84f9 | 2014-04-30 15:37:48 +0200 | [diff] [blame] | 215 | + |
| 216 | Restores the change. |
| 217 | + |
| 218 | The `Restore` button is only available if the change is abandoned and |
| 219 | the link:access-control.html#category_abandon[Abandon] and the |
| 220 | link:access-control.html#category_push[Push] access right is |
| 221 | assigned. |
| 222 | + |
| 223 | When a change is restored, a panel appears that allows one to type a |
| 224 | comment message to explain why the change is being restored. |
| 225 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 226 | ** [[rebase]]`Rebase`: |
Edwin Kempin | f1a84f9 | 2014-04-30 15:37:48 +0200 | [diff] [blame] | 227 | + |
| 228 | Rebases the change. The rebase is always done with content merge |
| 229 | enabled. If the rebase is successful a new patch set with the rebased |
| 230 | commit is created. If the rebase fails, there are conflicts that have |
| 231 | to be resolved manually. |
| 232 | + |
| 233 | If the change does not depend on another open change, it is rebased |
| 234 | onto the tip of the destination branch. |
| 235 | + |
| 236 | If the change depends on another open change, it is rebased onto the |
| 237 | current patch set of that other change. |
| 238 | + |
Zalan Blenessy | 366d785 | 2015-03-18 11:40:48 +0100 | [diff] [blame] | 239 | It is possible to change parent revision of a change. The new parent |
| 240 | revision can be another change towards the same target branch, or |
| 241 | the tip of the target branch. |
| 242 | + |
| 243 | The `Rebase` button is only available if |
Edwin Kempin | f1a84f9 | 2014-04-30 15:37:48 +0200 | [diff] [blame] | 244 | the link:access-control.html#category_rebase[Rebase] access right is |
| 245 | assigned. Rebasing merge commits is not supported. |
| 246 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 247 | ** [[cherry-pick]]`Cherry-Pick`: |
Edwin Kempin | f1a84f9 | 2014-04-30 15:37:48 +0200 | [diff] [blame] | 248 | + |
| 249 | Allows to cherry-pick the change to another branch. The destination |
| 250 | branch can be selected from a dialog. Cherry-picking a change creates a |
| 251 | new open change on the selected destination branch. |
| 252 | + |
| 253 | It is also possible to cherry-pick a change to the same branch. This is |
| 254 | effectively the same as rebasing it to the current tip of the |
| 255 | destination branch. This can be used to remove dependencies on other |
| 256 | open changes. |
| 257 | + |
| 258 | Users can only cherry-pick changes to branches for which they are |
| 259 | allowed to upload changes for review. |
| 260 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 261 | ** [[publish]]`Publish`: |
Edwin Kempin | f1a84f9 | 2014-04-30 15:37:48 +0200 | [diff] [blame] | 262 | + |
| 263 | Publishes the currently viewed draft patch set. If this is the first |
| 264 | patch set of a change that is published, the change will be published |
| 265 | as well. |
| 266 | + |
| 267 | The `Publish` button is only available if a draft patch set is viewed |
| 268 | and the user is the change owner or has the |
| 269 | link:access-control.html#category_publish_drafts[Publish Drafts] access |
| 270 | right assigned. |
| 271 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 272 | ** [[delete]]`Delete Change` / `Delete Revision`: |
Edwin Kempin | f1a84f9 | 2014-04-30 15:37:48 +0200 | [diff] [blame] | 273 | + |
| 274 | Deletes the draft change / the currently viewed draft patch set. |
| 275 | + |
| 276 | The `Delete Change` / `Delete Revision` buttons are only available if a |
| 277 | draft patch set is viewed and the user is the change owner or has the |
| 278 | link:access-control.html#category_delete_drafts[Delete Drafts] access |
| 279 | right assigned. |
| 280 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 281 | ** [[plugin-actions]]Further actions may be available if plugins are installed. |
Edwin Kempin | f1a84f9 | 2014-04-30 15:37:48 +0200 | [diff] [blame] | 282 | |
| 283 | + |
| 284 | image::images/user-review-ui-change-screen-change-info-actions.png[width=800, link="images/user-review-ui-change-screen-change-info-actions.png"] |
| 285 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 286 | - [[labels]]Labels & Votes: |
Edwin Kempin | f1a84f9 | 2014-04-30 15:37:48 +0200 | [diff] [blame] | 287 | + |
| 288 | Approving votes are colored green; veto votes are colored red. |
| 289 | + |
| 290 | image::images/user-review-ui-change-screen-change-info-labels.png[width=800, link="images/user-review-ui-change-screen-change-info-labels.png"] |
| 291 | |
Edwin Kempin | ab777f1 | 2014-05-02 11:47:57 +0200 | [diff] [blame] | 292 | [[files]] |
| 293 | === File List |
| 294 | |
| 295 | The file list shows the files that are modified in the currently viewed |
| 296 | patch set. |
| 297 | |
| 298 | image::images/user-review-ui-change-screen-file-list.png[width=800, link="images/user-review-ui-change-screen-file-list.png"] |
| 299 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 300 | [[change-screen-mark-reviewed]] |
Edwin Kempin | ab777f1 | 2014-05-02 11:47:57 +0200 | [diff] [blame] | 301 | The checkboxes in front of the file names allow files to be marked as reviewed. |
| 302 | |
| 303 | image::images/user-review-ui-change-screen-file-list-mark-as-reviewed.png[width=800, link="images/user-review-ui-change-screen-file-list-mark-as-reviewed.png"] |
| 304 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 305 | [[modification-type]] |
Edwin Kempin | ab777f1 | 2014-05-02 11:47:57 +0200 | [diff] [blame] | 306 | The type of a file modification is indicated by the character in front |
| 307 | of the file name: |
| 308 | |
| 309 | - 'no character' (Modified): |
| 310 | + |
| 311 | The file existed before this change and is modified. |
| 312 | |
| 313 | - `A` (Added): |
| 314 | + |
| 315 | The file is newly added. |
| 316 | |
| 317 | - `D` (Deleted): |
| 318 | + |
| 319 | The file is deleted. |
| 320 | |
| 321 | - `R` (Renamed): |
| 322 | + |
| 323 | The file is renamed. |
| 324 | |
| 325 | - `C` (Copied): |
| 326 | + |
| 327 | The file is new and is copied from an existing file. |
| 328 | |
| 329 | image::images/user-review-ui-change-screen-file-list-modification-type.png[width=800, link="images/user-review-ui-change-screen-file-list-modification-type.png"] |
| 330 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 331 | [[rename-or-copy]] |
Edwin Kempin | ab777f1 | 2014-05-02 11:47:57 +0200 | [diff] [blame] | 332 | If a file is renamed or copied, the name of the original file is |
| 333 | displayed in gray below the file name. |
| 334 | |
| 335 | image::images/user-review-ui-change-screen-file-list-rename.png[width=800, link="images/user-review-ui-change-screen-file-list-rename.png"] |
| 336 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 337 | [[repeating-path-segments]] |
Edwin Kempin | ab777f1 | 2014-05-02 11:47:57 +0200 | [diff] [blame] | 338 | Repeating path segments are grayed out. |
| 339 | |
| 340 | image::images/user-review-ui-change-screen-file-list-repeating-paths.png[width=800, link="images/user-review-ui-change-screen-file-list-repeating-paths.png"] |
| 341 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 342 | [[inline-comments-column]] |
Edwin Kempin | ab777f1 | 2014-05-02 11:47:57 +0200 | [diff] [blame] | 343 | Inline comments on a file are shown in the `Comments` column. |
| 344 | |
| 345 | Draft comments, i.e. comments that have been written by the current |
| 346 | user but not yet published, are highlighted in red. |
| 347 | |
| 348 | New comments from other users, that were published after the current |
| 349 | user last reviewed this change, are highlighted in bold. |
| 350 | |
| 351 | image::images/user-review-ui-change-screen-file-list-comments.png[width=800, link="images/user-review-ui-change-screen-file-list-comments.png"] |
| 352 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 353 | [[size]] |
David Pursehouse | 8bd6f78 | 2015-01-30 11:06:38 +0900 | [diff] [blame] | 354 | The size of the modifications in the files can be seen in the `Size` column. The |
| 355 | footer row shows the total size of the change. |
Edwin Kempin | ab777f1 | 2014-05-02 11:47:57 +0200 | [diff] [blame] | 356 | |
| 357 | The size information is useful to easily spot the files that contain |
| 358 | the most modifications; these files are likely to be the most relevant |
| 359 | files for this change. The total change size gives an estimate of how |
| 360 | long a review of this change may take. |
| 361 | |
David Pursehouse | 8bd6f78 | 2015-01-30 11:06:38 +0900 | [diff] [blame] | 362 | When the "Show Change Sizes As Colored Bars" user preference is enabled, the |
| 363 | `Size` column shows the sum of inserted and deleted lines as one number. In |
| 364 | addition, the change size is shown as a bar. The size of the bar indicates the |
| 365 | amount of changed lines, and its coloring shows the proportion of insertions |
| 366 | (green) to deletions (red). |
| 367 | |
| 368 | When the "Show Change Sizes As Colored Bars" user preference is disabled, the |
| 369 | colored bar is not shown. For added and renamed files, the `Size` column |
| 370 | shows the number of inserted and deleted lines. For new files, the column only |
| 371 | shows the total number of lines in the new file. No size is shown for binary |
| 372 | files and deleted files. |
| 373 | |
Edwin Kempin | ab777f1 | 2014-05-02 11:47:57 +0200 | [diff] [blame] | 374 | image::images/user-review-ui-change-screen-file-list-size.png[width=800, link="images/user-review-ui-change-screen-file-list-size.png"] |
| 375 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 376 | [[diff-against]] |
Edwin Kempin | ab777f1 | 2014-05-02 11:47:57 +0200 | [diff] [blame] | 377 | In the header of the file list, the `Diff Against` selection can be |
| 378 | changed. This selection allows one to choose if the currently viewed |
| 379 | patch set should be compared against its base or against another patch |
| 380 | set of this change. The file list is updated accordingly. |
| 381 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 382 | [[open-all]] |
Edwin Kempin | ab777f1 | 2014-05-02 11:47:57 +0200 | [diff] [blame] | 383 | The file list header also provides an `Open All` button that opens the |
| 384 | diff views for all files in the file list. |
| 385 | |
| 386 | image::images/user-review-ui-change-screen-file-list-header.png[width=800, link="images/user-review-ui-change-screen-file-list-header.png"] |
| 387 | |
Edwin Kempin | b2a8ae3 | 2014-05-02 15:03:22 +0200 | [diff] [blame] | 388 | [[patch-sets]] |
| 389 | === Patch Sets |
| 390 | |
| 391 | The change screen only presents one patch set at a time. Which patch |
| 392 | set is currently viewed can be seen from the `Patch Sets` drop-down |
| 393 | panel in the change header. It shows the number of the currently viewed |
| 394 | patch set and the total number of patch sets, in the form: "current |
| 395 | patch set/number of patch sets". |
| 396 | |
| 397 | If a non-current patch set is viewed this is indicated by the |
| 398 | link:#not-current[Not Current] change state. Please note that some |
| 399 | operations are only available on the current patch set. |
| 400 | |
| 401 | image::images/user-review-ui-change-screen-patch-sets.png[width=800, link="images/user-review-ui-change-screen-patch-sets.png"] |
| 402 | |
Orgad Shaneh | ce43e0f | 2014-09-03 22:53:44 +0300 | [diff] [blame] | 403 | Another indication is a highlighted drop-down label. |
| 404 | |
| 405 | image::images/user-review-ui-change-screen-not-current.png[width=800, link="images/user-review-ui-change-screen-not-current.png"] |
| 406 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 407 | [[patch-set-drop-down]] |
Edwin Kempin | b2a8ae3 | 2014-05-02 15:03:22 +0200 | [diff] [blame] | 408 | The patch set drop-down list shows the list of patch sets and allows to |
| 409 | switch between them. The patch sets are sorted in descending order so |
| 410 | that the current patch set is always on top. |
| 411 | |
Edwin Kempin | b2a8ae3 | 2014-05-02 15:03:22 +0200 | [diff] [blame] | 412 | Draft patch sets are marked with `DRAFT`. |
| 413 | |
| 414 | image::images/user-review-ui-change-screen-patch-set-list.png[width=800, link="images/user-review-ui-change-screen-patch-set-list.png"] |
| 415 | |
Edwin Kempin | 0cb1ccb | 2014-05-05 13:22:03 +0200 | [diff] [blame] | 416 | [[download]] |
| 417 | === Download |
| 418 | |
| 419 | The `Download` drop-down panel in the change header offers commands and |
| 420 | links for downloading the currently viewed patch set. |
| 421 | |
| 422 | image::images/user-review-ui-change-screen-download-commands.png[width=800, link="images/user-review-ui-change-screen-download-commands.png"] |
| 423 | |
| 424 | The available download commands depend on the installed Gerrit plugins. |
| 425 | The most popular plugin for download commands, the |
| 426 | link:https://gerrit-review.googlesource.com/#/admin/projects/plugins/download-commands[ |
| 427 | download-commands] plugin, provides commands to checkout, pull and |
| 428 | cherry-pick a patch set. |
| 429 | |
| 430 | Each command has a copy-to-clipboard icon that allows the command to be |
| 431 | copied into the clipboard. This makes it easy to paste and execute the |
| 432 | command on a Git command line. |
| 433 | |
| 434 | If several download schemes are configured on the server (e.g. SSH and |
| 435 | HTTP) there is a drop-down list to switch between the download schemes. |
| 436 | Gerrit automatically remembers the download scheme that was last chosen |
| 437 | and selects this download scheme the next time the download commands |
| 438 | drop-down panel is opened. |
| 439 | |
| 440 | The `Patch-File` links provide the Git patch file for the currently |
| 441 | viewed patch set for download. The patch file can be base64 encoded or |
| 442 | zipped. |
| 443 | |
| 444 | The `Archive` links allow one to download an archive with the contents |
| 445 | of the currently viewed patch set. The archive is offered in several |
| 446 | formats (e.g. tar and tbz2); which formats are available depends on the |
| 447 | configuration of the server. |
| 448 | |
| 449 | image::images/user-review-ui-change-screen-download-commands-list.png[width=800, link="images/user-review-ui-change-screen-download-commands-list.png"] |
| 450 | |
Edwin Kempin | 811bd58 | 2014-05-05 13:39:24 +0200 | [diff] [blame] | 451 | [[included-in]] |
| 452 | === Included In |
| 453 | |
| 454 | For merged changes the `Included In` drop-down panel is available in |
| 455 | the change header. |
| 456 | |
| 457 | image::images/user-review-ui-change-screen-included-in.png[width=800, link="images/user-review-ui-change-screen-included-in.png"] |
| 458 | |
| 459 | The `Included In` drop-down panel shows the branches and tags in which |
| 460 | the change is included. E.g. if a change fixes a bug, this allows to |
| 461 | quickly see in which released versions the bug-fix is contained |
| 462 | (assuming that every release is tagged). |
| 463 | |
| 464 | image::images/user-review-ui-change-screen-included-in-list.png[width=800, link="images/user-review-ui-change-screen-included-in-list.png"] |
| 465 | |
Edwin Kempin | 981cc95 | 2014-05-05 14:04:08 +0200 | [diff] [blame] | 466 | [[star]] |
| 467 | === Star Change |
| 468 | |
| 469 | The star icon in the change header allows to mark the change as a |
| 470 | favorite. Clicking on the star icon again, unstars the change. |
| 471 | |
| 472 | image::images/user-review-ui-change-screen-star.png[width=800, link="images/user-review-ui-change-screen-star.png"] |
| 473 | |
| 474 | Starring a change turns on email notifications for this change. |
| 475 | |
| 476 | Starred changed are listed under `My` > `Starred Changes`. |
| 477 | and can be queried by the link:user-search.html#is[is:starred] search |
| 478 | operator. |
| 479 | |
Edwin Kempin | 8ab5b53 | 2014-05-05 17:10:31 +0200 | [diff] [blame] | 480 | [[related-changes]] |
| 481 | === Related Changes |
| 482 | |
| 483 | If there are changes that are related to the currently viewed change |
| 484 | they are displayed in the third column of the change screen. |
| 485 | |
| 486 | There are several lists of related changes and a tab control is used to |
| 487 | display each list of related changes in its own tab. |
| 488 | |
| 489 | The following tabs may be displayed: |
| 490 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 491 | - [[related-changes-tab]]`Related Changes`: |
Edwin Kempin | 8ab5b53 | 2014-05-05 17:10:31 +0200 | [diff] [blame] | 492 | + |
| 493 | This tab page shows changes on which the current change depends |
| 494 | (ancestors) and open changes that depend on the current change |
| 495 | (descendants). For merge commits it also shows the closed changes that |
| 496 | will be merged into the destination branch by submitting the merge |
| 497 | commit. |
| 498 | + |
| 499 | The changes are sorted in the same way as the output of 'git log'. This |
| 500 | means the relationship between the changes can be inferred from the |
| 501 | position of the changes in the list. Changes listed above the current |
| 502 | change are descendants; changes below the current change are ancestors. |
| 503 | + |
Edwin Kempin | 68cfe47 | 2014-05-12 15:10:25 +0200 | [diff] [blame] | 504 | For merged changes this tab is only shown if there are open |
| 505 | descendants. |
Edwin Kempin | 8ab5b53 | 2014-05-05 17:10:31 +0200 | [diff] [blame] | 506 | + |
| 507 | image::images/user-review-ui-change-screen-related-changes.png[width=800, link="images/user-review-ui-change-screen-related-changes.png"] |
| 508 | + |
| 509 | Related changes may be decorated with an icon to signify dependencies |
| 510 | on outdated patch sets, or commits that are not associated to changes |
| 511 | under review: |
| 512 | + |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 513 | ** [[outdated]]Orange Dot: |
Edwin Kempin | 8ab5b53 | 2014-05-05 17:10:31 +0200 | [diff] [blame] | 514 | + |
| 515 | The selected patch set of the change is outdated; it is not the current |
| 516 | patch set of the change. |
| 517 | + |
| 518 | If an ancestor change is marked with an orange dot it means that the |
| 519 | currently viewed patch set depends on a outdated patch set of the |
| 520 | ancestor change. This is because a new patch set for the ancestor |
| 521 | change was uploaded in the meantime and as result the currently viewed |
| 522 | patch set now needs to be rebased. |
| 523 | + |
| 524 | If a descendant change is marked with an orange dot it means that an |
| 525 | old patch set of the descendant change depends on the currently viewed |
| 526 | patch set. It may be that the descendant was rebased in the meantime |
| 527 | and with the new patch set this dependency was removed. |
| 528 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 529 | ** [[indirect-descendant]]Green Tilde: |
Edwin Kempin | 8ab5b53 | 2014-05-05 17:10:31 +0200 | [diff] [blame] | 530 | + |
| 531 | The selected patch set of the change is an indirect descendant of the |
| 532 | currently viewed patch set; it has a dependency to another patch set of |
| 533 | this change. E.g. this could mean that a new patch set was uploaded for |
| 534 | this change and the descendant change now needs to be rebased. Please |
| 535 | note that following the link to an indirect descendant change may |
| 536 | result in a completely different related changes listing. |
| 537 | |
Dave Borowitz | bbaea3f | 2015-03-13 13:56:41 -0700 | [diff] [blame] | 538 | ** [[closed-ancestor]]Black Dot: |
Edwin Kempin | 8ab5b53 | 2014-05-05 17:10:31 +0200 | [diff] [blame] | 539 | + |
Stefan Beller | 7e23cd0 | 2015-06-18 11:40:18 -0700 | [diff] [blame] | 540 | Indicates a closed ancestor, e.g. the commit was directly pushed into |
Edwin Kempin | 8ab5b53 | 2014-05-05 17:10:31 +0200 | [diff] [blame] | 541 | the repository bypassing code review, or the ancestor change was |
| 542 | reviewed and submitted on another branch. The latter may indicate that |
| 543 | the user has accidentally pushed the commit to the wrong branch, e.g. |
| 544 | the commit was done on `branch-a`, but was then pushed to |
| 545 | `refs/for/branch-b`. |
Stefan Beller | 7e23cd0 | 2015-06-18 11:40:18 -0700 | [diff] [blame] | 546 | A black dot is also present if the change was abandoned. |
Edwin Kempin | 8ab5b53 | 2014-05-05 17:10:31 +0200 | [diff] [blame] | 547 | |
Stefan Beller | 03d6790 | 2015-06-18 15:52:24 -0700 | [diff] [blame] | 548 | ** [[closed-ancestor-abandoned]]Strikethrough Subject: |
| 549 | + |
| 550 | When the commit is abandoned, its subject line will be striked |
| 551 | through. |
| 552 | |
Edwin Kempin | 8ab5b53 | 2014-05-05 17:10:31 +0200 | [diff] [blame] | 553 | + |
| 554 | image::images/user-review-ui-change-screen-related-changes-indicators.png[width=800, link="images/user-review-ui-change-screen-related-changes-indicators.png"] |
| 555 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 556 | - [[conflicts-with]]`Conflicts With`: |
Edwin Kempin | 8ab5b53 | 2014-05-05 17:10:31 +0200 | [diff] [blame] | 557 | + |
| 558 | This tab page shows changes that conflict with the current change. |
| 559 | Non-mergeable changes are filtered out; only conflicting changes that |
| 560 | are mergeable are shown. |
| 561 | + |
| 562 | If this change is merged, its conflicting changes will have merge |
| 563 | conflicts and must be rebased. The rebase of the other changes with the |
| 564 | conflict resolution must then be done manually. |
| 565 | + |
| 566 | image::images/user-review-ui-change-screen-conflicts-with.png[width=800, link="images/user-review-ui-change-screen-conflicts-with.png"] |
| 567 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 568 | - [[same-topic]]`Same Topic`: |
Edwin Kempin | 8ab5b53 | 2014-05-05 17:10:31 +0200 | [diff] [blame] | 569 | + |
| 570 | This tab page shows changes that have the same topic as the current |
| 571 | change. Only open changes are included in the list. |
| 572 | + |
| 573 | image::images/user-review-ui-change-screen-same-topic.png[width=800, link="images/user-review-ui-change-screen-same-topic.png"] |
| 574 | |
Stefan Beller | 09feaac | 2015-06-29 16:20:10 -0700 | [diff] [blame] | 575 | - [[submitted-together]]`Submitted Together`: |
| 576 | + |
| 577 | This tab page shows changes that will be submitted together with the |
| 578 | currently viewed change, when clicking the submit button. It includes |
| 579 | ancestors of the current patch set. |
| 580 | + |
| 581 | This may include changes and its ancestors with the same topic if |
| 582 | `change.submitWholeTopic` is enabled. Only open changes with the |
| 583 | same topic are included in the list. |
| 584 | + |
| 585 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 586 | - [[cherry-picks]]`Cherry-Picks`: |
Edwin Kempin | 8ab5b53 | 2014-05-05 17:10:31 +0200 | [diff] [blame] | 587 | + |
| 588 | This tab page shows changes with the same link:user-changeid.html[ |
| 589 | Change-Id] for the current project. |
| 590 | + |
| 591 | Abandoned changes are filtered out. |
| 592 | + |
| 593 | For each change in this list the destination branch is shown as a |
| 594 | prefix in front of the change subject. |
| 595 | + |
| 596 | image::images/user-review-ui-change-screen-cherry-picks.png[width=800, link="images/user-review-ui-change-screen-cherry-picks.png"] |
| 597 | |
| 598 | If there are no related changes for a tab, the tab is not displayed. |
| 599 | |
Edwin Kempin | c6cab61 | 2014-05-06 11:09:05 +0200 | [diff] [blame] | 600 | [[reply]] |
| 601 | === Reply |
| 602 | |
| 603 | The `Reply...` button in the change header allows to reply to the |
| 604 | currently viewed patch set; one can add a summary comment, publish |
| 605 | inline draft comments, and vote on the labels. |
| 606 | |
| 607 | image::images/user-review-ui-change-screen-reply.png[width=800, link="images/user-review-ui-change-screen-reply.png"] |
| 608 | |
| 609 | Clicking on the `Reply...` button opens a popup panel. |
| 610 | |
Sebastian Schuberth | 027c435 | 2016-02-02 09:24:29 +0100 | [diff] [blame] | 611 | [[summary-comment]] |
Edwin Kempin | c6cab61 | 2014-05-06 11:09:05 +0200 | [diff] [blame] | 612 | A text box allows to type a summary comment for the currently viewed |
Sebastian Schuberth | 027c435 | 2016-02-02 09:24:29 +0100 | [diff] [blame] | 613 | patch set. Some basic markdown-like syntax is supported which renders |
| 614 | indented lines preformatted, lines starting with "- " or "* " as list |
| 615 | items, and lines starting with "> " as block quotes (also see replying to |
| 616 | link:#reply-to-message[messages] and link:#reply-inline-comment[inline comments]). |
Edwin Kempin | c6cab61 | 2014-05-06 11:09:05 +0200 | [diff] [blame] | 617 | |
Richard Möhn | e4abe9a | 2014-11-13 20:05:13 +0100 | [diff] [blame] | 618 | Note that you can set the text and tooltip of the button in |
| 619 | link:config-gerrit.html#change.replyLabel[gerrit.config]. |
| 620 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 621 | [[vote]] |
Edwin Kempin | c6cab61 | 2014-05-06 11:09:05 +0200 | [diff] [blame] | 622 | If the current patch set is viewed, radio buttons are displayed for |
| 623 | each label on which the user is allowed to vote. Voting on non-current |
| 624 | patch sets is not possible. |
| 625 | |
Edwin Kempin | c6cab61 | 2014-05-06 11:09:05 +0200 | [diff] [blame] | 626 | The inline draft comments that will be published are displayed in a |
| 627 | separate section so that they can be reviewed before publishing. There |
| 628 | are links to navigate to the inline comments which can be used if a |
| 629 | comment needs to be edited. |
| 630 | |
| 631 | The `Post` button publishes the comments and the votes. |
| 632 | |
Edwin Kempin | c6cab61 | 2014-05-06 11:09:05 +0200 | [diff] [blame] | 633 | image::images/user-review-ui-change-screen-replying.png[width=800, link="images/user-review-ui-change-screen-replying.png"] |
| 634 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 635 | [[quick-approve]] |
Edwin Kempin | c6cab61 | 2014-05-06 11:09:05 +0200 | [diff] [blame] | 636 | If a user can approve a label that is still required, a quick approve |
| 637 | button appears in the change header that allows to add this missing |
| 638 | approval by a single click. The quick approve button only appears if |
| 639 | there is a single label that is still required and can be approved by |
| 640 | the user. |
| 641 | |
| 642 | E.g. if a change requires approvals on the 'Code-Review' and the |
| 643 | 'Verified' labels, and there is already a '+1 Verified' vote, then |
| 644 | if the user is allowed to vote the max score on 'Code-Review', a |
| 645 | `Code-Review+2` quick approve button appears that approves the |
| 646 | 'Code-Review' label if clicked. |
| 647 | |
| 648 | Using the quick approve button also publishes all inline draft |
| 649 | comments; a summary comment is only added if the reply popup panel is |
| 650 | open when the quick approve button is clicked. |
| 651 | |
| 652 | image::images/user-review-ui-change-screen-quick-approve.png[width=800, link="images/user-review-ui-change-screen-quick-approve.png"] |
| 653 | |
Edwin Kempin | 7a68281 | 2014-05-06 14:45:01 +0200 | [diff] [blame] | 654 | [[history]] |
| 655 | === History |
| 656 | |
| 657 | The history of the change can be seen in the lower part of the screen. |
| 658 | |
| 659 | The history contains messages for all kinds of change updates, e.g. a |
| 660 | message is added when a new patch set is uploaded or when a review was |
| 661 | done. |
| 662 | |
| 663 | Messages with new comments from other users, that were published after |
| 664 | the current user last reviewed this change, are automatically expanded. |
| 665 | |
| 666 | image::images/user-review-ui-change-screen-history.png[width=800, link="images/user-review-ui-change-screen-history.png"] |
| 667 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 668 | [[reply-to-message]] |
Edwin Kempin | 7a68281 | 2014-05-06 14:45:01 +0200 | [diff] [blame] | 669 | It is possible to directly reply to a change message by clicking on the |
| 670 | reply icon in the right upper corner of a change message. This opens |
| 671 | the reply popup panel and prefills the text box with the quoted comment. |
| 672 | Then the reply can be written below the quoted comment or inserted |
Sebastian Schuberth | 027c435 | 2016-02-02 09:24:29 +0100 | [diff] [blame] | 673 | inline. Lines starting with "> " will be rendered as a block quote. |
Edwin Kempin | 7a68281 | 2014-05-06 14:45:01 +0200 | [diff] [blame] | 674 | Please note that for a correct rendering it is important to leave a blank |
| 675 | line between a quoted block and the reply to it. |
| 676 | |
| 677 | image::images/user-review-ui-change-screen-reply-to-comment.png[width=800, link="images/user-review-ui-change-screen-reply-to-comment.png"] |
| 678 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 679 | [[inline-comments-in-history]] |
Edwin Kempin | 7a68281 | 2014-05-06 14:45:01 +0200 | [diff] [blame] | 680 | Inline comments are directly displayed in the change history and there |
| 681 | are links to navigate to the inline comments. |
| 682 | |
| 683 | image::images/user-review-ui-change-screen-inline-comments.png[width=800, link="images/user-review-ui-change-screen-inline-comments.png"] |
| 684 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 685 | [[expand-all]] |
Edwin Kempin | 7a68281 | 2014-05-06 14:45:01 +0200 | [diff] [blame] | 686 | The `Expand All` button expands all messages; the `Collapse All` button |
| 687 | collapses all messages. |
| 688 | |
Edwin Kempin | 772418f | 2014-05-06 15:45:35 +0200 | [diff] [blame] | 689 | [[update-notification]] |
| 690 | === Update Notification |
| 691 | |
| 692 | The change screen automatically polls for updates to the currently |
| 693 | viewed change. If there is an update the user is informed by a popup |
| 694 | panel in the bottom right corner. |
| 695 | |
| 696 | The polling frequency depends on the server configuration; by default |
| 697 | it is 30 seconds. Polling may also be completely disabled by the |
| 698 | administrator. |
| 699 | |
| 700 | image::images/user-review-ui-change-screen-change-update.png[width=800, link="images/user-review-ui-change-screen-change-update.png"] |
| 701 | |
Edwin Kempin | 41d9d30 | 2014-05-06 16:02:06 +0200 | [diff] [blame] | 702 | [[plugin-extensions]] |
| 703 | === Plugin Extensions |
| 704 | |
| 705 | Gerrit plugins may extend the change screen; they can add buttons for |
| 706 | additional actions to the change info block and display arbitrary UI |
| 707 | controls below the change info block. |
| 708 | |
| 709 | image::images/user-review-ui-change-screen-plugin-extensions.png[width=800, link="images/user-review-ui-change-screen-plugin-extensions.png"] |
| 710 | |
Edwin Kempin | d38ddf5 | 2014-05-07 14:31:42 +0200 | [diff] [blame] | 711 | [[side-by-side]] |
| 712 | == Side-by-Side Diff Screen |
| 713 | |
| 714 | The side-by-side diff screen shows a single patch; the old file version |
| 715 | is displayed on the left side of the screen; the new file version is |
| 716 | displayed on the right side of the screen. |
| 717 | |
| 718 | This screen allows to review a patch and to comment on it. |
| 719 | |
| 720 | image::images/user-review-ui-side-by-side-diff-screen.png[width=800, link="images/user-review-ui-side-by-side-diff-screen.png"] |
| 721 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 722 | [[side-by-side-header]] |
Edwin Kempin | d38ddf5 | 2014-05-07 14:31:42 +0200 | [diff] [blame] | 723 | In the screen header the project name and the name of the viewed patch |
| 724 | file are shown. |
| 725 | |
| 726 | If a Git web browser is configured on the server, the project name and |
| 727 | the file path are displayed as links to the project and the folder in |
| 728 | the Git web browser. |
| 729 | |
| 730 | image::images/user-review-ui-side-by-side-diff-screen-project-and-file.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-project-and-file.png"] |
| 731 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 732 | [[side-by-side-mark-reviewed]] |
Edwin Kempin | d38ddf5 | 2014-05-07 14:31:42 +0200 | [diff] [blame] | 733 | The checkbox in front of the project name and the file name allows the |
Edwin Kempin | fe8ca4c | 2014-05-08 16:49:15 +0200 | [diff] [blame] | 734 | patch to be marked as reviewed. The link:#mark-reviewed[Mark Reviewed] |
| 735 | diff preference allows to control whether the files should be |
| 736 | automatically marked as reviewed when they are viewed. |
Edwin Kempin | d38ddf5 | 2014-05-07 14:31:42 +0200 | [diff] [blame] | 737 | |
| 738 | image::images/user-review-ui-side-by-side-diff-screen-reviewed.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-reviewed.png"] |
| 739 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 740 | [[scrollbar]] |
Edwin Kempin | d38ddf5 | 2014-05-07 14:31:42 +0200 | [diff] [blame] | 741 | The scrollbar shows patch diffs and inline comments as annotations. |
| 742 | This provides a good overview of the lines in the patch that are |
| 743 | relevant for reviewing. By clicking on an annotation one can quickly |
| 744 | navigate to the corresponding line in the patch. |
| 745 | |
| 746 | image::images/user-review-ui-side-by-side-diff-screen-scrollbar.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-scrollbar.png"] |
| 747 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 748 | [[gaps]] |
Edwin Kempin | 1266ac8f | 2014-05-09 09:39:31 +0200 | [diff] [blame] | 749 | A gap between lines in the file content that is caused by aligning the |
| 750 | left and right side or by displaying inline comments is shown as a |
| 751 | vertical red bar in the line number column. This prevents a gap from |
| 752 | being mistaken for blank lines in the file |
| 753 | |
| 754 | image::images/user-review-ui-side-by-side-diff-screen-red-bar.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-red-bar.png"] |
| 755 | |
Edwin Kempin | d8057e5 | 2014-05-08 13:52:32 +0200 | [diff] [blame] | 756 | [[patch-set-selection]] |
| 757 | In the header, on each side, the list of patch sets is shown. Clicking |
| 758 | on a patch set changes the selection for the patch set comparison and |
| 759 | the screen is refreshed to show the diff between the selected patch |
| 760 | sets. The currently selected patch set is highlighted by a light blue |
| 761 | background. |
| 762 | |
| 763 | On the left side `Base` can be selected to compare a patch set against |
| 764 | its base. For merge commits `Auto Merge` is available instead which |
| 765 | allows to compare the patch against the result of the auto merge. The |
| 766 | auto merge version may contain Git conflict markers and is useful for |
| 767 | reviewing how conflicts are resolved by a patch. |
| 768 | |
| 769 | Reviewers that are reviewing a patch for the first time look at its |
| 770 | diff against its base; reviewers that have reviewed an old patch |
| 771 | version before, may see what has changed since that version by |
| 772 | comparing the old patch against the current patch. |
| 773 | |
| 774 | image::images/user-review-ui-side-by-side-diff-screen-patch-sets.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-patch-sets.png"] |
| 775 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 776 | [[download-file]] |
Edwin Kempin | 6db9bcd | 2014-06-06 09:32:05 +0200 | [diff] [blame] | 777 | The download icon next to the patch set list allows to download the |
| 778 | patch. Unless the mime type of the file is configured as safe, the |
| 779 | download file is a zip archive that contains the patch file. |
| 780 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 781 | [[no-differences]] |
Edwin Kempin | 01280cc | 2014-05-09 09:53:30 +0200 | [diff] [blame] | 782 | If the compared patches are identical, this is highlighted by a red |
| 783 | `No Differences` label in the screen header. |
| 784 | |
| 785 | image::images/user-review-ui-side-by-side-diff-screen-no-differences.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-no-differences.png"] |
| 786 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 787 | [[side-by-side-rename]] |
Edwin Kempin | afb4fcc | 2014-06-06 09:52:52 +0200 | [diff] [blame] | 788 | If a file was renamed, the old and new file paths are shown in the |
| 789 | header together with a similarity index that shows how much of the file |
| 790 | content is unmodified. |
| 791 | |
| 792 | image::images/user-review-ui-side-by-side-diff-screen-rename.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-rename.png"] |
Edwin Kempin | d8057e5 | 2014-05-08 13:52:32 +0200 | [diff] [blame] | 793 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 794 | [[navigation]] |
Edwin Kempin | d37a134 | 2014-05-08 14:02:35 +0200 | [diff] [blame] | 795 | For navigating between the patches in a patch set there are navigation |
| 796 | buttons on the right side of the screen header. The left arrow button |
| 797 | navigates to the previous patch; the right arrow button navigates to |
| 798 | the next patch. The arrow up button leads back to the change screen. In |
| 799 | all cases the selection for the patch set comparison is kept. |
| 800 | |
| 801 | image::images/user-review-ui-side-by-side-diff-screen-navigation.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-navigation.png"] |
| 802 | |
Edwin Kempin | 004c347 | 2014-05-07 16:56:59 +0200 | [diff] [blame] | 803 | [[inline-comments]] |
| 804 | === Inline Comments |
| 805 | |
| 806 | Inline comments are displayed directly in the patch file under the code |
| 807 | that is commented. Inline comments can be placed on lines or on code |
| 808 | blocks. |
| 809 | |
| 810 | If an inline comment relates to a code block, this code block is |
| 811 | highlighted by a yellow background. |
| 812 | |
| 813 | Code blocks with comments may overlap. This means it is possible to |
| 814 | attach several comments to the same code. |
| 815 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 816 | [[line-links]] |
Edwin Kempin | 004c347 | 2014-05-07 16:56:59 +0200 | [diff] [blame] | 817 | The lines of the patch file are linkable. To link to a certain line in |
| 818 | the patch file, '@<line-number>' must be appended to the patch link, |
| 819 | e.g. `http://host:8080/#/c/56857/2/Documentation/user-review-ui.txt@665`. |
| 820 | To link to a line in the old file version, '@a<line-number>' must be |
| 821 | appended to the patch link. These links can be used to directly link to |
| 822 | certain inline comments. |
| 823 | |
Edwin Kempin | fe8ca4c | 2014-05-08 16:49:15 +0200 | [diff] [blame] | 824 | If the diff preference link:#expand-all-comments[Expand All Comments] |
| 825 | is set to `Expand`, all inline comments will be automatically expanded. |
Edwin Kempin | 004c347 | 2014-05-07 16:56:59 +0200 | [diff] [blame] | 826 | |
| 827 | image::images/user-review-ui-side-by-side-diff-screen-inline-comments.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-inline-comments.png"] |
| 828 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 829 | [[comment]] |
Edwin Kempin | 004c347 | 2014-05-07 16:56:59 +0200 | [diff] [blame] | 830 | In the header of the comment box, the name of the comment author and |
| 831 | the timestamp of the comment are shown. If avatars are configured on |
| 832 | the server, the avatar image of the comment author is displayed in the |
| 833 | top left corner. Below the actual comment there are buttons to reply to |
| 834 | the comment. |
| 835 | |
| 836 | image::images/user-review-ui-side-by-side-diff-screen-comment-box.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-comment-box.png"] |
| 837 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 838 | [[reply-inline-comment]] |
Edwin Kempin | 004c347 | 2014-05-07 16:56:59 +0200 | [diff] [blame] | 839 | Clicking on the `Reply` button opens an editor to type the reply. |
| 840 | |
| 841 | Quoting is supported, but only by manually copying & pasting the old |
Sebastian Schuberth | 027c435 | 2016-02-02 09:24:29 +0100 | [diff] [blame] | 842 | comment that should be quoted and prefixing every line by "> ". Please |
Edwin Kempin | 004c347 | 2014-05-07 16:56:59 +0200 | [diff] [blame] | 843 | note that for a correct rendering it is important to leave a blank line |
| 844 | between a quoted block and the reply to it. |
| 845 | |
| 846 | Clicking on the `Save` button saves the comment as a draft. To make it |
| 847 | visible to other users it must be published from the change screen by |
| 848 | link:#reply[replying] to the change. |
| 849 | |
| 850 | The `Cancel` button cancels the editing and discards any changes to the |
| 851 | draft comment. |
| 852 | |
| 853 | Clicking on the `Discard` button deletes the inline draft comment. |
| 854 | |
| 855 | image::images/user-review-ui-side-by-side-diff-screen-comment-reply.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-comment-reply.png"] |
| 856 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 857 | [[draft-inline-comment]] |
Edwin Kempin | 004c347 | 2014-05-07 16:56:59 +0200 | [diff] [blame] | 858 | Draft comments are marked by the text "Draft" in the header in the |
| 859 | place of the comment author. |
| 860 | |
| 861 | A draft comment can be edited by clicking on the `Edit` button, or |
| 862 | deleted by clicking on the `Discard` button. |
| 863 | |
| 864 | image::images/user-review-ui-side-by-side-diff-screen-comment-edit.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-comment-edit.png"] |
| 865 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 866 | [[done]] |
Edwin Kempin | 004c347 | 2014-05-07 16:56:59 +0200 | [diff] [blame] | 867 | Clicking on the `Done` button is a quick way to reply with "Done" to a |
| 868 | comment. This is used to mark a comment as addressed by a follow-up |
| 869 | patch set. |
| 870 | |
Edwin Kempin | 4460665 | 2014-05-09 08:31:05 +0200 | [diff] [blame] | 871 | image::images/user-review-ui-side-by-side-diff-screen-replied-done.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-replied-done.png"] |
Edwin Kempin | 004c347 | 2014-05-07 16:56:59 +0200 | [diff] [blame] | 872 | |
| 873 | [[add-inline-comment]] |
| 874 | To add a new inline comment there are several possibilities: |
| 875 | |
| 876 | - select a code block and press 'c' |
| 877 | - select a code block and click on the popup comment icon |
Edwin Kempin | 7feeb95 | 2014-05-09 11:16:56 +0200 | [diff] [blame] | 878 | - go to a line, by clicking on it or by link:#key-navigation[key |
| 879 | navigation], and press 'c' |
Edwin Kempin | 004c347 | 2014-05-07 16:56:59 +0200 | [diff] [blame] | 880 | - click on a line number |
| 881 | |
| 882 | There are many ways to select code for commenting on it. The most |
| 883 | frequently used methods are: |
| 884 | |
| 885 | - by mouse: |
| 886 | ** click and drag with the mouse to select a block |
| 887 | ** double-click on a word to select it |
| 888 | ** double-click and drag with the mouse to select a code block word-wise |
| 889 | ** triple-click on a line to select it |
| 890 | ** triple-click and drag with the mouse to select a code block line-wise |
| 891 | |
| 892 | - by keys (the same keys that are used for visual selection in Vim): |
| 893 | ** press 'v' + arrow keys (or 'h', 'j', 'k', 'l') to select a block |
| 894 | ** press 'V' + arrow keys (or 'j', 'k') to select a code block line-wise |
| 895 | ** type 'bvw' to select a word |
| 896 | |
Edwin Kempin | 004c347 | 2014-05-07 16:56:59 +0200 | [diff] [blame] | 897 | image::images/user-review-ui-side-by-side-diff-screen-comment.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-comment.png"] |
| 898 | |
| 899 | For typing the new comment, a new comment box is shown under the code |
| 900 | that is commented. |
| 901 | |
| 902 | Clicking on the `Save` button saves the new comment as a draft. To make |
| 903 | it visible to other users it must be published from the change screen |
| 904 | by link:#reply[replying] to the change. |
| 905 | |
| 906 | Clicking on the `Discard` button deletes the new comment. |
| 907 | |
| 908 | image::images/user-review-ui-side-by-side-diff-screen-commented.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-commented.png"] |
| 909 | |
Edwin Kempin | 9df27ac | 2014-05-08 13:06:18 +0200 | [diff] [blame] | 910 | [[file-level-comments]] |
| 911 | === File Level Comments |
| 912 | |
| 913 | Comments that apply to a whole file can be added on file level. |
| 914 | |
| 915 | File level comments are added by clicking on the comment icon in the |
| 916 | header above the file. |
| 917 | |
| 918 | image::images/user-review-ui-side-by-side-diff-screen-file-level-comment.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-file-level-comment.png"] |
| 919 | |
| 920 | Clicking on the comment icon opens a comment box for typing the file |
| 921 | level comment. |
| 922 | |
| 923 | image::images/user-review-ui-side-by-side-diff-screen-file-level-commented.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-file-level-commented.png"] |
| 924 | |
Edwin Kempin | 6113a1f | 2014-05-09 10:48:34 +0200 | [diff] [blame] | 925 | [[search]] |
| 926 | === Search |
| 927 | |
| 928 | For searching within a patch file, a Vim-like search is supported. |
| 929 | Typing `/` opens the search box. Typing in the search box immediately |
| 930 | highlights matches in the patch file with a yellow background. Using |
| 931 | JavaScript regular expressions in the search term is supported. The |
| 932 | search is case insensitive. After confirming the search by `ENTER` one |
| 933 | can navigate between the matches by `n` / `N` to go to the next / |
| 934 | previous match. Skipped lines are automatically expanded if they |
| 935 | contain a match and one navigates to it. |
| 936 | |
| 937 | For additional possibilities to search please check the |
| 938 | link:http://www.vim.org/docs.php[Vim documentation]. There are other |
| 939 | useful ways to search, e.g. while the cursor is on a word, pressing `*` |
| 940 | or `#` searches for the next or previous occurrence of the word. |
| 941 | |
| 942 | Searching by `Ctrl-F` finds matches only in the visible area of the |
| 943 | screen unless the link:#render[Render] diff preference is set to `Slow`. |
| 944 | |
| 945 | image::images/user-review-ui-side-by-side-diff-screen-search.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-search.png"] |
| 946 | |
Edwin Kempin | 7feeb95 | 2014-05-09 11:16:56 +0200 | [diff] [blame] | 947 | [[key-navigation]] |
| 948 | === Key Navigation |
| 949 | |
| 950 | Vim-like commands can be used to navigate within a patch file: |
| 951 | |
| 952 | - `h` / `j` / `k` / `l` moves the cursor left / down / up / right |
| 953 | - `0` / `$` moves the cursor to the start / end of the line |
| 954 | - `gg` / `G` moves to cursor to the start / end of the file |
| 955 | - `Ctrl-D` / `Ctrl-U` scolls downwards / upwards |
| 956 | |
| 957 | Please check the link:http://www.vim.org/docs.php[Vim documentation] |
| 958 | for further information. |
| 959 | |
Edwin Kempin | fe8ca4c | 2014-05-08 16:49:15 +0200 | [diff] [blame] | 960 | [[diff-preferences]] |
| 961 | === Diff Preferences |
| 962 | |
| 963 | There are several options to control how patch diffs should be |
| 964 | rendered. Users can configure their preferences in the diff |
| 965 | preferences. The diff preferences can be accessed by clicking on the |
| 966 | settings icon in the screen header. |
| 967 | |
| 968 | image::images/user-review-ui-side-by-side-diff-screen-preferences.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-preferences.png"] |
| 969 | |
| 970 | The diff preferences popup allows to change the diff preferences. |
| 971 | By clicking on the `Save` button changes to the diff preferences are |
| 972 | saved permanently. Clicking on the `Apply` button applies the new |
| 973 | diff preferences to the current screen, but they are discarded when the |
| 974 | screen is refreshed. The `Save` button is only available if the user is |
| 975 | signed in. |
| 976 | |
| 977 | image::images/user-review-ui-side-by-side-diff-screen-preferences-popup.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-preferences-popup.png"] |
| 978 | |
| 979 | The following diff preferences can be configured: |
| 980 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 981 | - [[theme]]`Theme`: |
Edwin Kempin | fe8ca4c | 2014-05-08 16:49:15 +0200 | [diff] [blame] | 982 | + |
| 983 | Controls the theme that is used to render the file content. |
| 984 | + |
| 985 | E.g. users could choose to work with a dark theme. |
| 986 | + |
| 987 | image::images/user-review-ui-side-by-side-diff-screen-dark-theme.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-dark-theme.png"] |
| 988 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 989 | - [[ignore-whitespace]]`Ignore Whitespace`: |
Edwin Kempin | fe8ca4c | 2014-05-08 16:49:15 +0200 | [diff] [blame] | 990 | + |
| 991 | Controls whether differences in whitespace should be ignored or not. |
| 992 | + |
| 993 | ** `None`: |
| 994 | + |
| 995 | All differences in whitespace are highlighted. |
| 996 | + |
| 997 | ** `At Line End`: |
| 998 | + |
| 999 | Whitespace differences at the end of lines are ignored. |
| 1000 | + |
| 1001 | ** `Leading, At Line End`: |
| 1002 | + |
| 1003 | Whitespace differences at the beginning and end of lines are ignored. |
| 1004 | + |
| 1005 | ** `All`: |
| 1006 | + |
| 1007 | All differences in whitespace are ignored. |
| 1008 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 1009 | - [[tab-width]]`Tab Width`: |
Edwin Kempin | fe8ca4c | 2014-05-08 16:49:15 +0200 | [diff] [blame] | 1010 | + |
| 1011 | Controls how many spaces should be displayed for a tab. |
| 1012 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 1013 | - [[columns]]`Columns`: |
Edwin Kempin | fe8ca4c | 2014-05-08 16:49:15 +0200 | [diff] [blame] | 1014 | + |
| 1015 | Sets the preferred line length. At this position a vertical dashed line |
| 1016 | is displayed so that one can easily detect lines the exceed the |
| 1017 | preferred line length. |
| 1018 | + |
| 1019 | image::images/user-review-ui-side-by-side-diff-screen-column.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-column.png"] |
| 1020 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 1021 | - [[lines-of-context]]`Lines Of Context`: |
Edwin Kempin | fe8ca4c | 2014-05-08 16:49:15 +0200 | [diff] [blame] | 1022 | + |
| 1023 | The number of context lines that should be displayed before and after |
| 1024 | any diff. If the `entire file` checkbox is selected, the full file is |
| 1025 | rendered. |
| 1026 | + |
| 1027 | Skipped common lines can be expanded by clicking on the placeholder for |
| 1028 | the skipped lines. |
| 1029 | + |
| 1030 | Clicking on "... skipped <n> common lines ..." expands the complete |
| 1031 | block of skipped lines. |
| 1032 | + |
| 1033 | If many lines are skipped there are additional links to expand the |
| 1034 | context by ten lines before and after the skipped block. |
| 1035 | + |
| 1036 | image::images/user-review-ui-side-by-side-diff-screen-expand-skipped-lines.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-expand-skipped-lines.png"] |
| 1037 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 1038 | - [[intraline-difference]]`Intraline Difference`: |
Edwin Kempin | fe8ca4c | 2014-05-08 16:49:15 +0200 | [diff] [blame] | 1039 | + |
| 1040 | Controls whether intraline differences should be highlighted. |
| 1041 | + |
| 1042 | image::images/user-review-ui-side-by-side-diff-screen-intraline-difference.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-intraline-difference.png"] |
| 1043 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 1044 | - [[syntax-highlighting]]`Syntax Highlighting`: |
Edwin Kempin | fe8ca4c | 2014-05-08 16:49:15 +0200 | [diff] [blame] | 1045 | + |
| 1046 | Controls whether syntax highlighting should be enabled. |
| 1047 | + |
| 1048 | The language for the syntax highlighting is automatically detected from |
Edwin Kempin | 637db5e | 2014-05-12 08:25:26 +0200 | [diff] [blame] | 1049 | the file extension. The language can also be set manually by selecting |
| 1050 | it from the `Language` drop-down list. |
Edwin Kempin | fe8ca4c | 2014-05-08 16:49:15 +0200 | [diff] [blame] | 1051 | + |
| 1052 | image::images/user-review-ui-side-by-side-diff-screen-syntax-coloring.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-syntax-coloring.png"] |
| 1053 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 1054 | - [[whitespace-errors]]`Whitespace Errors`: |
Edwin Kempin | fe8ca4c | 2014-05-08 16:49:15 +0200 | [diff] [blame] | 1055 | + |
| 1056 | Controls whether whitespace errors are highlighted. |
| 1057 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 1058 | - [[show-tabs]]`Show Tabs`: |
Edwin Kempin | fe8ca4c | 2014-05-08 16:49:15 +0200 | [diff] [blame] | 1059 | + |
| 1060 | Controls whether tabs are highlighted. |
| 1061 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 1062 | - [[line-numbers]]`Line Numbers`: |
Edwin Kempin | fe8ca4c | 2014-05-08 16:49:15 +0200 | [diff] [blame] | 1063 | + |
| 1064 | Controls whether line numbers are shown. |
| 1065 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 1066 | - [[empty-pane]]`Empty Pane`: |
David Ostrovsky | a64d689 | 2014-05-01 21:55:00 +0200 | [diff] [blame] | 1067 | + |
| 1068 | Controls whether empty panes are shown or not. The Left pane is empty when a |
| 1069 | file was added; the right pane is empty when a file was deleted. |
| 1070 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 1071 | - [[left-side]]`Left Side`: |
Edwin Kempin | 91de46f | 2014-05-12 08:28:32 +0200 | [diff] [blame] | 1072 | + |
David Ostrovsky | a000b23 | 2014-05-13 07:47:06 +0200 | [diff] [blame] | 1073 | Controls whether the left side is shown. This preference is not |
| 1074 | persistent and is ignored by the `Save` button. Every time a |
| 1075 | patch diff is opened, this preference is reset to `Show`. |
Edwin Kempin | 91de46f | 2014-05-12 08:28:32 +0200 | [diff] [blame] | 1076 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 1077 | - [[top-menu]]`Top Menu`: |
Edwin Kempin | fe8ca4c | 2014-05-08 16:49:15 +0200 | [diff] [blame] | 1078 | + |
| 1079 | Controls whether the top menu is shown. |
| 1080 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 1081 | - [[auto-hide-diff-table-header]]`Auto Hide Diff Table Header`: |
Edwin Kempin | 1b6c6d8 | 2014-09-11 23:36:43 +0200 | [diff] [blame] | 1082 | + |
| 1083 | Controls whether the diff table header should be automatically hidden |
| 1084 | when scrolling down more than half of a page. |
| 1085 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 1086 | - [[mark-reviewed]]`Mark Reviewed`: |
Edwin Kempin | fe8ca4c | 2014-05-08 16:49:15 +0200 | [diff] [blame] | 1087 | + |
| 1088 | Controls whether the files of the patch set should be automatically |
| 1089 | marked as reviewed when they are viewed. |
| 1090 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 1091 | - [[expand-all-comments]]`Expand All Comments`: |
Edwin Kempin | fe8ca4c | 2014-05-08 16:49:15 +0200 | [diff] [blame] | 1092 | + |
| 1093 | Controls whether all comments should be automatically expanded. |
| 1094 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 1095 | - [[render]]`Render`: |
Edwin Kempin | fe8ca4c | 2014-05-08 16:49:15 +0200 | [diff] [blame] | 1096 | + |
| 1097 | Controls how patch files that exceed the screen size are rendered. |
| 1098 | + |
| 1099 | If `Fast` is selected file contents which are outside of the visible |
| 1100 | area are not attached to the browser's DOM tree. This makes the |
| 1101 | rendering fast, but searching by `Ctrl+F` only finds content which is |
| 1102 | in the visible area. |
| 1103 | + |
| 1104 | If `Slow` is selected all file contents are attached to the browser's |
| 1105 | DOM tree, which makes the rendering slow for large files. The advantage |
| 1106 | of this setting is that `Ctrl+F` can be used to search in the complete |
| 1107 | file. |
Edwin Kempin | 9cc22c9 | 2014-05-12 08:16:52 +0200 | [diff] [blame] | 1108 | + |
| 1109 | Large files that exceed 4000 lines will not be fully rendered. |
Edwin Kempin | fe8ca4c | 2014-05-08 16:49:15 +0200 | [diff] [blame] | 1110 | |
Paladox | ee24b3c | 2016-09-05 23:51:02 +0100 | [diff] [blame] | 1111 | - [[line-wrapping]]`Line Wrapping`: |
| 1112 | + |
| 1113 | Controls weather to enable line wrapping or not. |
| 1114 | + |
| 1115 | If `false` is selected then line wrapping is disabled. |
| 1116 | This is the default option. |
| 1117 | + |
| 1118 | If `true` is selected then line wrapping is enabled. |
| 1119 | |
Edwin Kempin | 7a85f41 | 2014-05-09 12:51:51 +0200 | [diff] [blame] | 1120 | [[keyboard-shortcuts]] |
| 1121 | == Keyboard Shortcuts |
| 1122 | |
| 1123 | Navigation within the review UI can be completely done by keys, and |
| 1124 | most actions can be controlled by keyboard shortcuts. Typing `?` opens |
| 1125 | a popup that shows a list of available keyboard shortcuts: |
| 1126 | |
| 1127 | - Change Screen |
| 1128 | + |
| 1129 | image::images/user-review-ui-change-screen-keyboard-shortcuts.png[width=800, link="images/user-review-ui-change-screen-keyboard-shortcuts.png"] |
| 1130 | |
| 1131 | - Side-by-Side Diff Screen |
| 1132 | + |
| 1133 | image::images/user-review-ui-side-by-side-diff-screen-keyboard-shortcuts.png[width=800, link="images/user-review-ui-side-by-side-diff-screen-keyboard-shortcuts.png"] |
| 1134 | + |
| 1135 | In addition, Vim-like commands can be used to link:#key-navigation[ |
| 1136 | navigate] and link:#search[search] within a patch file. |
| 1137 | |
Edwin Kempin | b7a1c7c | 2014-05-09 11:21:18 +0200 | [diff] [blame] | 1138 | [[new-vs-old]] |
| 1139 | == New Review UI vs. Old Review UI |
| 1140 | |
| 1141 | There are some important conceptual differences between the old and |
| 1142 | new review UIs: |
| 1143 | |
| 1144 | - The old change screen directly shows all patch sets of the change. |
| 1145 | With the new change screen only a single patch set is displayed; |
| 1146 | users can switch between the patch sets by choosing another patch |
| 1147 | set from the link:#patch-sets[Patch Sets] drop down panel in the |
| 1148 | screen header. |
| 1149 | - On the old side-by-side diff screen, new comments are inserted by |
| 1150 | double-clicking on a line. With the new side-by-side diff screen |
| 1151 | double-click is used to select a word for commenting on it; there |
| 1152 | are link:#add-inline-comment[several ways to insert new comments], |
| 1153 | e.g. by selecting a code block and clicking on the popup comment |
| 1154 | icon. |
| 1155 | |
Edwin Kempin | f9b4bc9 | 2014-11-05 13:14:57 +0100 | [diff] [blame] | 1156 | [[limitations]] |
Edwin Kempin | b7a1c7c | 2014-05-09 11:21:18 +0200 | [diff] [blame] | 1157 | Limitations of the new review UI: |
| 1158 | |
| 1159 | - The new side-by-side diff screen cannot render images. |
| 1160 | |
Edwin Kempin | 7aed5f0 | 2014-11-05 13:30:22 +0100 | [diff] [blame] | 1161 | - The new side-by-side diff screen isn't able to highlight line |
| 1162 | endings. |
| 1163 | |
Edwin Kempin | 4fd84c9 | 2014-04-30 13:23:15 +0200 | [diff] [blame] | 1164 | GERRIT |
| 1165 | ------ |
| 1166 | Part of link:index.html[Gerrit Code Review] |
| 1167 | |
| 1168 | SEARCHBOX |
| 1169 | --------- |