Yuxuan 'fishy' Wang | 61698b1 | 2013-12-20 12:55:51 -0800 | [diff] [blame] | 1 | = squash commits first |
Edwin Kempin | efb5f9a | 2010-12-16 11:02:00 +0100 | [diff] [blame] | 2 | |
| 3 | With this error message Gerrit rejects to push a commit if it |
David Pursehouse | 2c6f638 | 2014-09-04 13:06:19 +0900 | [diff] [blame] | 4 | contains the same Change-Id as a predecessor commit. |
Edwin Kempin | efb5f9a | 2010-12-16 11:02:00 +0100 | [diff] [blame] | 5 | |
| 6 | The reason for rejecting such a commit is that it would introduce, for |
| 7 | the corresponding change in Gerrit, a dependency upon itself. Gerrit |
| 8 | prevents such dependencies between patch sets within the same change |
| 9 | to keep the review process simple. Otherwise reviewers would not only |
| 10 | have to review the latest patch set but also all the patch sets the |
David Pursehouse | 221d4f6 | 2012-06-08 17:38:08 +0900 | [diff] [blame] | 11 | latest one depends on. |
Edwin Kempin | efb5f9a | 2010-12-16 11:02:00 +0100 | [diff] [blame] | 12 | |
| 13 | This error is quite common, it appears when a user tries to address |
| 14 | review comments and creates a new commit instead of amending the |
| 15 | existing commit. Another possibility for this error, although less |
| 16 | likely, is that the user tried to create a patch series with multiple |
David Pursehouse | 2c6f638 | 2014-09-04 13:06:19 +0900 | [diff] [blame] | 17 | changes to be reviewed and accidentally included the same Change-Id |
Edwin Kempin | efb5f9a | 2010-12-16 11:02:00 +0100 | [diff] [blame] | 18 | into the different commit messages. |
| 19 | |
| 20 | |
Yuxuan 'fishy' Wang | 61698b1 | 2013-12-20 12:55:51 -0800 | [diff] [blame] | 21 | == Example |
Edwin Kempin | efb5f9a | 2010-12-16 11:02:00 +0100 | [diff] [blame] | 22 | |
| 23 | Here an example about how the push is failing. Please note that the |
| 24 | two commits 'one commit' and 'another commit' both have the same |
David Pursehouse | 2c6f638 | 2014-09-04 13:06:19 +0900 | [diff] [blame] | 25 | Change-Id (of course in real life it can happen that there are more |
| 26 | than two commits that have the same Change-Id). |
Edwin Kempin | efb5f9a | 2010-12-16 11:02:00 +0100 | [diff] [blame] | 27 | |
| 28 | ---- |
| 29 | $ git log |
| 30 | commit 13d381265ffff88088e1af88d0e2c2c1143743cd |
| 31 | Author: John Doe <john.doe@example.com> |
| 32 | Date: Thu Dec 16 10:15:48 2010 +0100 |
| 33 | |
| 34 | another commit |
| 35 | |
| 36 | Change-Id: I93478acac09965af91f03c82e55346214811ac79 |
| 37 | |
| 38 | commit ca45e125145b12fe9681864b123bc9daea501bf7 |
| 39 | Author: John Doe <john.doe@example.com> |
| 40 | Date: Thu Dec 16 10:12:54 2010 +0100 |
| 41 | |
| 42 | one commit |
| 43 | |
| 44 | Change-Id: I93478acac09965af91f03c82e55346214811ac79 |
| 45 | |
| 46 | $ git push ssh://JohnDoe@host:29418/myProject HEAD:refs/for/master |
| 47 | Counting objects: 8, done. |
| 48 | Delta compression using up to 2 threads. |
| 49 | Compressing objects: 100% (2/2), done. |
| 50 | Writing objects: 100% (6/6), 558 bytes, done. |
| 51 | Total 6 (delta 0), reused 0 (delta 0) |
| 52 | To ssh://JohnDoe@host:29418/myProject |
| 53 | ! [remote rejected] HEAD -> refs/for/master (squash commits first) |
| 54 | error: failed to push some refs to 'ssh://JohnDoe@host:29418/myProject' |
| 55 | ---- |
| 56 | |
David Pursehouse | a43ad9c | 2014-09-04 13:15:15 +0900 | [diff] [blame] | 57 | If it was the intention to rework a change and push a new patch |
| 58 | set, the problem can be fixed by squashing the commits that contain the |
David Pursehouse | 2c6f638 | 2014-09-04 13:06:19 +0900 | [diff] [blame] | 59 | same Change-Id. The squashed commit can then be pushed to Gerrit. |
David Pursehouse | a43ad9c | 2014-09-04 13:15:15 +0900 | [diff] [blame] | 60 | |
| 61 | To squash the commits, use `git rebase -i` to do an interactive rebase. For |
| 62 | the example above where the last two commits have the same Change-Id, |
Edwin Kempin | efb5f9a | 2010-12-16 11:02:00 +0100 | [diff] [blame] | 63 | this means an interactive rebase for the last two commits should be |
| 64 | done. For further details about the git rebase command please check |
| 65 | the link:http://www.kernel.org/pub/software/scm/git/docs/git-rebase.html[Git documentation for rebase]. |
| 66 | |
| 67 | ---- |
| 68 | $ git rebase -i HEAD~2 |
| 69 | |
| 70 | pick ca45e12 one commit |
| 71 | squash 13d3812 another commit |
| 72 | |
| 73 | [detached HEAD ab37207] squashed commit |
| 74 | 1 files changed, 3 insertions(+), 0 deletions(-) |
| 75 | Successfully rebased and updated refs/heads/master. |
| 76 | |
| 77 | $ git log |
| 78 | commit ab37207d33647685801dba36cb4fd51f3eb73507 |
| 79 | Author: John Doe <john.doe@example.com> |
| 80 | Date: Thu Dec 16 10:12:54 2010 +0100 |
| 81 | |
| 82 | squashed commit |
| 83 | |
| 84 | Change-Id: I93478acac09965af91f03c82e55346214811ac79 |
| 85 | |
| 86 | $ git push ssh://JohnDoe@host:29418/myProject HEAD:refs/for/master |
| 87 | Counting objects: 5, done. |
| 88 | Writing objects: 100% (3/3), 307 bytes, done. |
| 89 | Total 3 (delta 0), reused 0 (delta 0) |
| 90 | To ssh://JohnDoe@host:29418/myProject |
| 91 | * [new branch] HEAD -> refs/for/master |
| 92 | ---- |
| 93 | |
| 94 | If it was the intention to create a patch series with multiple |
David Pursehouse | 221d4f6 | 2012-06-08 17:38:08 +0900 | [diff] [blame] | 95 | changes to be reviewed, each commit message should contain the |
David Pursehouse | 2c6f638 | 2014-09-04 13:06:19 +0900 | [diff] [blame] | 96 | Change-Id of the corresponding change in Gerrit. If a change in |
| 97 | Gerrit does not exist yet, the Change-Id should be generated (either |
| 98 | by using a link:cmd-hook-commit-msg.html[commit hook] or by using EGit) or the Change-Id could be |
Edwin Kempin | efb5f9a | 2010-12-16 11:02:00 +0100 | [diff] [blame] | 99 | removed (not recommended since then amending this commit to create |
David Pursehouse | 2c6f638 | 2014-09-04 13:06:19 +0900 | [diff] [blame] | 100 | subsequent patch sets is more error prone). To change the Change-Id |
Edwin Kempin | efb5f9a | 2010-12-16 11:02:00 +0100 | [diff] [blame] | 101 | of an existing commit do an interactive link:http://www.kernel.org/pub/software/scm/git/docs/git-rebase.html[git rebase] and fix the |
| 102 | affected commit messages. |
| 103 | |
| 104 | |
| 105 | GERRIT |
| 106 | ------ |
| 107 | Part of link:error-messages.html[Gerrit Error Messages] |
Yuxuan 'fishy' Wang | 99cb68d | 2013-10-31 17:26:00 -0700 | [diff] [blame] | 108 | |
| 109 | SEARCHBOX |
| 110 | --------- |