blob: 3fd2a0f70ccb25cb6de4d75322bdb4fcff0fd13d [file] [log] [blame]
Dave Borowitz938398f2018-09-14 14:14:25 -07001load(
2 "@bazel_tools//tools/jdk:default_java_toolchain.bzl",
3 "JDK9_JVM_OPTS",
4 "default_java_toolchain",
5)
David Pursehouseb80867d2019-09-08 22:31:37 +09006load("@rules_java//java:defs.bzl", "java_package_configuration")
David Ostrovsky4b60cd72018-08-26 15:53:01 +02007
Han-Wen Nienhuysa223f5a2019-04-25 12:15:41 +02008exports_files(["nongoogle.bzl"])
9
David Ostrovsky4b60cd72018-08-26 15:53:01 +020010default_java_toolchain(
11 name = "error_prone_warnings_toolchain",
David Pursehousea5ca0332018-11-02 08:24:16 +090012 bootclasspath = ["@bazel_tools//tools/jdk:platformclasspath.jar"],
Dave Borowitz938398f2018-09-14 14:14:25 -070013 jvm_opts = JDK9_JVM_OPTS,
David Ostrovsky4b60cd72018-08-26 15:53:01 +020014 package_configuration = [
15 ":error_prone",
16 ],
17 visibility = ["//visibility:public"],
18)
19
David Ostrovskyb89332d2020-04-27 07:06:24 +020020JDK11_JVM_OPTS = select({
21 "@bazel_tools//src/conditions:openbsd": ["-Xbootclasspath/p:$(location @bazel_tools//tools/jdk:javac_jar)"],
22 "//conditions:default": [
23 "--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED",
24 "--add-exports=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED",
25 "--add-exports=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED",
26 "--add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED",
27 "--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED",
28 "--add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED",
29 "--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED",
30 "--add-opens=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED",
31 "--patch-module=java.compiler=$(location @bazel_tools//tools/jdk:java_compiler_jar)",
32 "--patch-module=jdk.compiler=$(location @bazel_tools//tools/jdk:jdk_compiler_jar)",
33 "--add-opens=java.base/java.nio=ALL-UNNAMED",
34 "--add-opens=java.base/java.lang=ALL-UNNAMED",
35 ],
36})
37
38default_java_toolchain(
39 name = "error_prone_warnings_toolchain_java11",
40 bootclasspath = ["@bazel_tools//tools/jdk:platformclasspath.jar"],
41 forcibly_disable_header_compilation = False,
42 genclass = ["@bazel_tools//tools/jdk:genclass"],
43 header_compiler = ["@bazel_tools//tools/jdk:turbine"],
44 header_compiler_direct = ["@bazel_tools//tools/jdk:turbine_direct"],
45 ijar = ["@bazel_tools//tools/jdk:ijar"],
46 javabuilder = ["@bazel_tools//tools/jdk:javabuilder"],
David Ostrovskyb89332d2020-04-27 07:06:24 +020047 javac_supports_workers = True,
48 jvm_opts = JDK11_JVM_OPTS,
49 misc = [
50 "-XDskipDuplicateBridges=true",
51 "-g",
52 "-parameters",
53 ],
54 package_configuration = [
55 ":error_prone",
56 ],
57 singlejar = ["@bazel_tools//tools/jdk:singlejar"],
58 source_version = "11",
59 target_version = "11",
60 tools = [
61 "@bazel_tools//tools/jdk:java_compiler_jar",
Ivo Listb4d318e2020-11-25 11:19:53 +000062 "@bazel_tools//tools/jdk:javac_jar",
David Ostrovskyb89332d2020-04-27 07:06:24 +020063 "@bazel_tools//tools/jdk:jdk_compiler_jar",
64 ],
65 visibility = ["//visibility:public"],
66)
67
Dave Borowitz3b78c072019-05-24 11:27:43 -070068# Error Prone errors enabled by default; see ../.bazelrc for how this is
69# enabled. This warnings list is originally based on:
70# https://github.com/bazelbuild/BUILD_file_generator/blob/master/tools/bazel_defs/java.bzl
Dmitrii Filippova30b5b42021-09-23 13:21:34 +020071# Additionally, items used internally in google is added. Such items have
72# the same or higher verbosity level than in google.
Dave Borowitz3b78c072019-05-24 11:27:43 -070073# However, feel free to add any additional errors. Thus far they have all been pretty useful.
Dmitrii Filippova30b5b42021-09-23 13:21:34 +020074# All warnings are commented to avoid noise in the output.
75# Newer versions of error-prone have XepDisableAllWarnings flag which could
76# be used instead of commenting. Bazel should be updated to use a new version
77# of error-prone.
Dave Borowitzcac46302019-05-24 09:54:18 -070078java_package_configuration(
79 name = "error_prone",
80 javacopts = [
81 "-XepDisableWarningsInGeneratedCode",
Dmitrii Filippov1c76a0a2021-09-23 18:57:04 +020082 # The XepDisableWarningsInGeneratedCode disables only warnings, but
83 # not errors. We should manually exclude all files generated by
84 # AutoValue; such files always start $AutoValue_.....
85 # XepExcludedPaths is a regexp. If you need more paths - use | as
86 # separator.
87 "-XepExcludedPaths:.*/\\\\$$AutoValue_.*\\.java",
Dmitrii Filippov88726b92021-09-23 15:11:15 +020088 "-Xep:AlmostJavadoc:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +020089 "-Xep:AlwaysThrows:ERROR",
Dave Borowitzccdc6702019-05-24 10:14:03 -070090 "-Xep:AmbiguousMethodReference:ERROR",
Dmitrii Filippov53e46002021-09-23 18:20:21 +020091 "-Xep:AnnotateFormatMethod:ERROR",
Dmitrii Filippovacb4ba32021-09-23 18:27:21 +020092 "-Xep:ArgumentSelectionDefectChecker:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +020093 "-Xep:ArrayAsKeyOfSetOrMap:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +020094 "-Xep:ArrayEquals:ERROR",
95 "-Xep:ArrayFillIncompatibleType:ERROR",
96 "-Xep:ArrayHashCode:ERROR",
97 "-Xep:ArrayToString:ERROR",
98 "-Xep:ArraysAsListPrimitiveArray:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +020099 "-Xep:AssertEqualsArgumentOrderChecker:ERROR",
100 "-Xep:AssertionFailureIgnored:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200101 "-Xep:AsyncCallableReturnsNull:ERROR",
102 "-Xep:AsyncFunctionReturnsNull:ERROR",
103 "-Xep:AutoValueConstructorOrderChecker:ERROR",
Edwin Kempinc2d0a912019-07-01 16:10:57 +0200104 "-Xep:AutoValueFinalMethods:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200105 # "-Xep:AutoValueImmutableFields:WARN",
106 # "-Xep:AutoValueSubclassLeaked:WARN",
Dave Borowitzccdc6702019-05-24 10:14:03 -0700107 "-Xep:BadAnnotationImplementation:ERROR",
108 "-Xep:BadComparable:ERROR",
Edwin Kempin33f8f6a2021-09-28 15:17:15 +0200109 "-Xep:BadImport:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200110 "-Xep:BadInstanceof:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200111 "-Xep:BadShiftAmount:ERROR",
112 "-Xep:BanSerializableRead:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200113 "-Xep:BigDecimalEquals:ERROR",
114 "-Xep:BigDecimalLiteralDouble:ERROR",
Dave Borowitzccdc6702019-05-24 10:14:03 -0700115 "-Xep:BoxedPrimitiveConstructor:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200116 "-Xep:BoxedPrimitiveEquality:ERROR",
117 "-Xep:BundleDeserializationCast:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200118 "-Xep:ByteBufferBackingArray:ERROR",
119 "-Xep:CacheLoaderNull:ERROR",
Dave Borowitzccdc6702019-05-24 10:14:03 -0700120 "-Xep:CannotMockFinalClass:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200121 "-Xep:CanonicalDuration:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200122 # "-Xep:CatchAndPrintStackTrace:WARN",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200123 "-Xep:CatchFail:ERROR",
124 "-Xep:ChainedAssertionLosesContext:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200125 "-Xep:ChainingConstructorIgnoresParameter:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200126 "-Xep:CharacterGetNumericValue:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200127 "-Xep:CheckNotNullMultipleTimes:ERROR",
128 "-Xep:CheckReturnValue:ERROR",
Dave Borowitzae99a1b2019-05-24 10:15:40 -0700129 "-Xep:ClassCanBeStatic:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200130 "-Xep:ClassName:ERROR",
Dave Borowitzccdc6702019-05-24 10:14:03 -0700131 "-Xep:ClassNewInstance:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200132 "-Xep:CollectionIncompatibleType:ERROR",
133 "-Xep:CollectionToArraySafeParameter:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200134 "-Xep:CollectionUndefinedEquality:ERROR",
135 "-Xep:CollectorShouldNotUseState:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200136 "-Xep:ComparableAndComparator:ERROR",
137 "-Xep:ComparableType:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200138 "-Xep:CompareToZero:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200139 "-Xep:ComparingThisWithNull:ERROR",
140 "-Xep:ComparisonOutOfRange:ERROR",
141 "-Xep:CompatibleWithAnnotationMisuse:ERROR",
142 "-Xep:CompileTimeConstant:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200143 "-Xep:ComplexBooleanConstant:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200144 "-Xep:ComputeIfAbsentAmbiguousReference:ERROR",
145 "-Xep:ConditionalExpressionNumericPromotion:ERROR",
146 "-Xep:ConstantOverflow:ERROR",
147 "-Xep:DaggerProvidesNull:ERROR",
148 "-Xep:DangerousLiteralNull:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200149 "-Xep:DateChecker:ERROR",
David Pursehousee39b4f42019-06-05 15:23:20 +0900150 "-Xep:DateFormatConstant:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200151 "-Xep:DeadException:ERROR",
152 "-Xep:DeadThread:ERROR",
Dave Borowitz96015722019-05-24 10:16:41 -0700153 "-Xep:DefaultCharset:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200154 # "-Xep:DefaultPackage:WARN",
155 "-Xep:DepAnn:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200156 "-Xep:DeprecatedVariable:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200157 "-Xep:DiscardedPostfixExpression:ERROR",
158 "-Xep:DoNotCall:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200159 "-Xep:DoNotCallSuggester:ERROR",
160 "-Xep:DoNotClaimAnnotations:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200161 "-Xep:DoNotMock:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200162 "-Xep:DoNotMockAutoValue:ERROR",
163 "-Xep:DoubleBraceInitialization:ERROR",
Dave Borowitzccdc6702019-05-24 10:14:03 -0700164 "-Xep:DoubleCheckedLocking:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200165 "-Xep:DuplicateMapKeys:ERROR",
166 "-Xep:DurationFrom:ERROR",
167 "-Xep:DurationGetTemporalUnit:ERROR",
168 "-Xep:DurationTemporalUnit:ERROR",
169 "-Xep:DurationToLongTimeUnit:ERROR",
Dmitrii Filippov7709d062021-09-23 15:42:48 +0200170 "-Xep:EmptyBlockTag:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200171 # "-Xep:EmptyCatch:WARN",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200172 "-Xep:EmptySetMultibindingContributions:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200173 # "-Xep:EqualsGetClass:WARN",
Dave Borowitz3cf39622019-05-24 10:17:44 -0700174 "-Xep:EqualsHashCode:ERROR",
175 "-Xep:EqualsIncompatibleType:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200176 "-Xep:EqualsNaN:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200177 "-Xep:EqualsNull:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200178 "-Xep:EqualsReference:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200179 "-Xep:EqualsUnsafeCast:ERROR",
180 "-Xep:EqualsUsingHashCode:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200181 "-Xep:EqualsWrongThing:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200182 "-Xep:ErroneousThreadPoolConstructorChecker:ERROR",
Edwin Kempinb8455d72021-11-05 14:54:15 +0100183 "-Xep:EscapedEntity:WARN",
Dave Borowitz3cf39622019-05-24 10:17:44 -0700184 "-Xep:ExpectedExceptionChecker:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200185 "-Xep:ExtendingJUnitAssert:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200186 "-Xep:ExtendsAutoValue:ERROR",
187 "-Xep:FallThrough:ERROR",
Dave Borowitz3cf39622019-05-24 10:17:44 -0700188 "-Xep:Finally:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200189 "-Xep:FloatCast:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200190 "-Xep:FloatingPointAssertionWithinEpsilon:ERROR",
Dave Borowitz0c5fdd72019-05-24 10:22:02 -0700191 "-Xep:FloatingPointLiteralPrecision:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200192 "-Xep:FloggerArgumentToString:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200193 "-Xep:FloggerFormatString:ERROR",
194 "-Xep:FloggerLogVarargs:ERROR",
195 "-Xep:FloggerSplitLogStatement:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200196 "-Xep:FloggerStringConcatenation:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200197 "-Xep:ForOverride:ERROR",
198 "-Xep:FormatString:ERROR",
Patrick Hieself396eff2019-11-07 12:01:55 +0100199 "-Xep:FormatStringAnnotation:ERROR",
Dave Borowitz0c5fdd72019-05-24 10:22:02 -0700200 "-Xep:FragmentInjection:ERROR",
201 "-Xep:FragmentNotInstantiable:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200202 "-Xep:FromTemporalAccessor:ERROR",
Dave Borowitz0c5fdd72019-05-24 10:22:02 -0700203 "-Xep:FunctionalInterfaceClash:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200204 "-Xep:FunctionalInterfaceMethodChanged:ERROR",
Gal Paikine0ba0d12021-10-05 17:30:14 +0200205 # "-Xep:FutureReturnValueIgnored:ERROR", // this check has a bug.
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200206 "-Xep:FuturesGetCheckedIllegalExceptionType:ERROR",
207 "-Xep:GetClassOnAnnotation:ERROR",
208 "-Xep:GetClassOnClass:ERROR",
Dave Borowitzf66892a2019-05-24 10:44:32 -0700209 "-Xep:GetClassOnEnum:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200210 "-Xep:GuardedBy:ERROR",
211 "-Xep:GuiceAssistedInjectScoping:ERROR",
212 "-Xep:GuiceAssistedParameters:ERROR",
213 "-Xep:HashtableContains:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200214 "-Xep:HidingField:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200215 "-Xep:IdentityBinaryExpression:ERROR",
216 "-Xep:IdentityHashMapBoxing:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200217 "-Xep:IdentityHashMapUsage:ERROR",
218 "-Xep:IgnoredPureGetter:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200219 "-Xep:Immutable:ERROR",
Dmitrii Filippov7d493812021-09-23 09:59:25 +0200220 "-Xep:ImmutableAnnotationChecker:ERROR",
Dave Borowitz0b9e5812019-05-24 10:37:36 -0700221 "-Xep:ImmutableEnumChecker:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200222 "-Xep:ImmutableModification:ERROR",
223 "-Xep:Incomparable:ERROR",
224 "-Xep:IncompatibleArgumentType:ERROR",
Dave Borowitz0c5fdd72019-05-24 10:22:02 -0700225 "-Xep:IncompatibleModifiers:ERROR",
Edwin Kempine92a8512021-11-05 14:39:19 +0100226 "-Xep:InconsistentCapitalization:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200227 "-Xep:InconsistentHashCode:ERROR",
228 "-Xep:IncrementInForLoopAndHeader:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200229 "-Xep:IndexOfChar:ERROR",
230 "-Xep:InexactVarargsConditional:ERROR",
231 "-Xep:InfiniteRecursion:ERROR",
Dave Borowitz0c5fdd72019-05-24 10:22:02 -0700232 "-Xep:InjectOnConstructorOfAbstractClass:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200233 "-Xep:InheritDoc:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200234 # "-Xep:InlineFormatString:WARN",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200235 "-Xep:InlineMeInliner:ERROR",
236 "-Xep:InlineMeSuggester:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200237 "-Xep:InlineMeValidator:ERROR",
Dave Borowitzb7769f32019-05-24 10:46:17 -0700238 "-Xep:InputStreamSlowMultibyteRead:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200239 "-Xep:InsecureCryptoUsage:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200240 "-Xep:InstanceOfAndCastMatchWrongType:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200241 "-Xep:InstantTemporalUnit:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200242 "-Xep:IntLongMath:ERROR",
Edwin Kempin03ce0d12021-10-19 12:26:07 +0200243 "-Xep:InvalidBlockTag:ERROR",
Edwin Kempin6e38b702021-10-19 12:27:28 +0200244 "-Xep:InvalidInlineTag:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200245 "-Xep:InvalidJavaTimeConstant:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200246 "-Xep:InvalidLink:ERROR",
Edwin Kempin8ab87d72021-10-19 13:27:07 +0200247 "-Xep:InvalidParam:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200248 "-Xep:InvalidPatternSyntax:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200249 "-Xep:InvalidThrows:ERROR",
250 "-Xep:InvalidThrowsLink:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200251 "-Xep:InvalidTimeZoneID:ERROR",
252 "-Xep:InvalidZoneId:ERROR",
253 "-Xep:IsInstanceIncompatibleType:ERROR",
254 "-Xep:IsInstanceOfClass:ERROR",
255 "-Xep:IsLoggableTagLength:ERROR",
Dave Borowitzb7769f32019-05-24 10:46:17 -0700256 "-Xep:IterableAndIterator:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200257 "-Xep:IterablePathParameter:ERROR",
Dave Borowitzb7769f32019-05-24 10:46:17 -0700258 "-Xep:JUnit3FloatingPointComparisonWithoutDelta:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200259 "-Xep:JUnit3TestNotRun:ERROR",
260 "-Xep:JUnit4ClassAnnotationNonStatic:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200261 "-Xep:JUnit4ClassUsedInJUnit3:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200262 "-Xep:JUnit4SetUpNotRun:ERROR",
263 "-Xep:JUnit4TearDownNotRun:ERROR",
264 "-Xep:JUnit4TestNotRun:ERROR",
265 "-Xep:JUnit4TestsNotRunWithinEnclosed:ERROR",
Dave Borowitzb7769f32019-05-24 10:46:17 -0700266 "-Xep:JUnitAmbiguousTestClass:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200267 "-Xep:JUnitAssertSameCheck:ERROR",
268 "-Xep:JUnitParameterMethodNotFound:ERROR",
269 "-Xep:JavaDurationGetSecondsGetNano:ERROR",
270 "-Xep:JavaDurationWithNanos:ERROR",
271 "-Xep:JavaDurationWithSeconds:ERROR",
272 "-Xep:JavaInstantGetSecondsGetNano:ERROR",
Edwin Kempin8a6808f2021-10-19 14:00:26 +0200273 "-Xep:JavaLangClash:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200274 "-Xep:JavaLocalDateTimeGetNano:ERROR",
275 "-Xep:JavaLocalTimeGetNano:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200276 "-Xep:JavaPeriodGetDays:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200277 "-Xep:JavaTimeDefaultTimeZone:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200278 "-Xep:JavaUtilDate:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200279 # "-Xep:JdkObsolete:WARN",
280 "-Xep:JodaConstructors:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200281 "-Xep:JodaDateTimeConstants:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200282 "-Xep:JodaDurationWithMillis:ERROR",
283 "-Xep:JodaInstantWithMillis:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200284 "-Xep:JodaNewPeriod:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200285 "-Xep:JodaPlusMinusLong:ERROR",
286 "-Xep:JodaTimeConverterManager:ERROR",
287 "-Xep:JodaToSelf:ERROR",
288 "-Xep:JodaWithDurationAddedLong:ERROR",
289 "-Xep:LiteByteStringUtf8:ERROR",
290 "-Xep:LiteEnumValueOf:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200291 "-Xep:LiteProtoToString:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200292 "-Xep:LocalDateTemporalAmount:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200293 "-Xep:LockNotBeforeTry:ERROR",
294 "-Xep:LockOnBoxedPrimitive:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200295 "-Xep:LogicalAssignment:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200296 "-Xep:LongFloatConversion:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200297 "-Xep:LongLiteralLowerCaseSuffix:ERROR",
298 "-Xep:LoopConditionChecker:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200299 "-Xep:LoopOverCharArray:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200300 "-Xep:LossyPrimitiveCompare:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200301 "-Xep:MathAbsoluteRandom:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200302 "-Xep:MathRoundIntLong:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200303 "-Xep:MemoizeConstantVisitorStateLookups:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200304 "-Xep:MislabeledAndroidString:ERROR",
Dave Borowitzb7769f32019-05-24 10:46:17 -0700305 "-Xep:MissingCasesInEnumSwitch:ERROR",
306 "-Xep:MissingFail:ERROR",
Dave Borowitzdc00c1d2019-05-24 10:48:49 -0700307 "-Xep:MissingOverride:ERROR",
Dmitrii Filippov88726b92021-09-23 15:11:15 +0200308 "-Xep:MissingSummary:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200309 "-Xep:MissingSuperCall:ERROR",
310 "-Xep:MissingTestCall:ERROR",
311 "-Xep:MisusedDayOfYear:ERROR",
312 "-Xep:MisusedWeekYear:ERROR",
313 "-Xep:MixedDescriptors:ERROR",
314 # "-Xep:MixedMutabilityReturnType:WARN",
315 "-Xep:MockitoUsage:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200316 "-Xep:ModifiedButNotUsed:ERROR",
317 "-Xep:ModifyCollectionInEnhancedForLoop:ERROR",
318 "-Xep:ModifySourceCollectionInStream:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200319 "-Xep:ModifyingCollectionWithItself:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200320 "-Xep:MultipleParallelOrSequentialCalls:ERROR",
321 "-Xep:MultipleUnaryOperatorsInMethodCall:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200322 "-Xep:MustBeClosedChecker:ERROR",
Dave Borowitzb7769f32019-05-24 10:46:17 -0700323 "-Xep:MutableConstantField:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200324 # "-Xep:MutablePublicArray:WARN",
325 "-Xep:NCopiesOfChar:ERROR",
Dave Borowitzcd7efe12019-05-24 10:52:43 -0700326 "-Xep:NarrowingCompoundAssignment:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200327 "-Xep:NestedInstanceOfConditions:ERROR",
Dave Borowitz2bc50b42019-05-24 10:56:59 -0700328 "-Xep:NonAtomicVolatileUpdate:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200329 "-Xep:NonCanonicalStaticImport:ERROR",
330 # "-Xep:NonCanonicalType:WARN",
331 "-Xep:NonFinalCompileTimeConstant:ERROR",
Dave Borowitz2bc50b42019-05-24 10:56:59 -0700332 "-Xep:NonOverridingEquals:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200333 "-Xep:NonRuntimeAnnotation:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200334 "-Xep:NullOptional:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200335 "-Xep:NullTernary:ERROR",
Dave Borowitz2bc50b42019-05-24 10:56:59 -0700336 "-Xep:NullableConstructor:ERROR",
337 "-Xep:NullablePrimitive:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200338 "-Xep:NullablePrimitiveArray:ERROR",
Dave Borowitz2bc50b42019-05-24 10:56:59 -0700339 "-Xep:NullableVoid:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200340 "-Xep:ObjectEqualsForPrimitives:ERROR",
David Pursehousec8ccff92020-04-13 15:07:52 +0900341 "-Xep:ObjectToString:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200342 "-Xep:ObjectsHashCodePrimitive:ERROR",
Dave Borowitzb21dde32019-05-24 10:57:09 -0700343 "-Xep:OperatorPrecedence:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200344 "-Xep:OptionalEquality:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200345 "-Xep:OptionalMapToOptional:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200346 "-Xep:OptionalMapUnusedValue:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200347 "-Xep:OptionalNotPresent:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200348 "-Xep:OptionalOfRedundantMethod:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200349 "-Xep:OrphanedFormatString:ERROR",
350 "-Xep:OutlineNone:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200351 "-Xep:OverlappingQualifierAndScopeAnnotation:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200352 "-Xep:OverrideThrowableToString:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200353 "-Xep:Overrides:ERROR",
Dave Borowitz2bc50b42019-05-24 10:56:59 -0700354 "-Xep:OverridesGuiceInjectableMethod:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200355 "-Xep:OverridesJavaxInjectableMethod:ERROR",
356 "-Xep:PackageInfo:ERROR",
Edwin Kempin4957ffd2021-10-15 15:31:47 +0200357 "-Xep:ParameterName:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200358 "-Xep:ParametersButNotParameterized:ERROR",
359 "-Xep:ParcelableCreator:ERROR",
360 "-Xep:PeriodFrom:ERROR",
361 "-Xep:PeriodGetTemporalUnit:ERROR",
362 "-Xep:PeriodTimeMath:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200363 "-Xep:PreconditionsCheckNotNullRepeated:ERROR",
Dave Borowitz2bc50b42019-05-24 10:56:59 -0700364 "-Xep:PreconditionsInvalidPlaceholder:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200365 "-Xep:PrimitiveAtomicReference:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200366 "-Xep:PrivateSecurityContractProtoAccess:ERROR",
367 # "-Xep:ProtectedMembersInFinalClass:WARN",
368 "-Xep:ProtoBuilderReturnValueIgnored:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200369 "-Xep:ProtoDurationGetSecondsGetNano:ERROR",
Dmitrii Filippov7f051792021-09-23 12:55:43 +0200370 "-Xep:ProtoFieldNullComparison:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200371 "-Xep:ProtoRedundantSet:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200372 "-Xep:ProtoStringFieldReferenceEquality:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200373 "-Xep:ProtoTimestampGetSecondsGetNano:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200374 "-Xep:ProtoTruthMixedDescriptors:ERROR",
Dave Borowitz2bc50b42019-05-24 10:56:59 -0700375 "-Xep:ProtocolBufferOrdinal:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200376 "-Xep:ProvidesMethodOutsideOfModule:ERROR",
377 "-Xep:RandomCast:ERROR",
378 "-Xep:RandomModInteger:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200379 "-Xep:ReachabilityFenceUsage:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200380 "-Xep:RectIntersectReturnValueIgnored:ERROR",
Dave Borowitzb9640492019-05-24 11:24:32 -0700381 "-Xep:ReferenceEquality:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200382 "-Xep:RefersToDaggerCodegen:ERROR",
383 "-Xep:RemovedInJDK11:ERROR",
Dave Borowitz425ad6e2019-05-24 11:00:18 -0700384 "-Xep:RequiredModifiers:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200385 "-Xep:RestrictedApiChecker:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200386 "-Xep:RethrowReflectiveOperationExceptionAsLinkageError:ERROR",
387 "-Xep:ReturnFromVoid:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200388 "-Xep:ReturnValueIgnored:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200389 "-Xep:RxReturnValueIgnored:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200390 # "-Xep:SameNameButDifferent:WARN",
391 "-Xep:SelfAssignment:ERROR",
392 "-Xep:SelfComparison:ERROR",
393 "-Xep:SelfEquals:ERROR",
Dave Borowitz425ad6e2019-05-24 11:00:18 -0700394 "-Xep:ShortCircuitBoolean:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200395 "-Xep:ShouldHaveEvenArgs:ERROR",
396 "-Xep:SizeGreaterThanOrEqualsZero:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200397 "-Xep:StaticAssignmentInConstructor:ERROR",
Dave Borowitz425ad6e2019-05-24 11:00:18 -0700398 "-Xep:StaticGuardedByInstance:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200399 "-Xep:StaticMockMember:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200400 "-Xep:StaticQualifiedUsingExpression:ERROR",
401 "-Xep:StreamToString:ERROR",
402 "-Xep:StringBuilderInitWithChar:ERROR",
Dave Borowitzccdc6702019-05-24 10:14:03 -0700403 "-Xep:StringEquality:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200404 # "-Xep:StringSplitter:WARN",
405 "-Xep:SubstringOfZero:ERROR",
406 "-Xep:SuppressWarningsDeprecated:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200407 "-Xep:SwigMemoryLeak:ERROR",
Dave Borowitzb13bec92019-05-24 11:16:54 -0700408 "-Xep:SynchronizeOnNonFinalField:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200409 "-Xep:TemporalAccessorGetChronoField:ERROR",
410 "-Xep:TestParametersNotInitialized:ERROR",
411 "-Xep:TheoryButNoTheories:ERROR",
412 # "-Xep:ThreadJoinLoop:WARN",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200413 "-Xep:ThreadLocalUsage:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200414 # "-Xep:ThreadPriorityCheck:WARN",
415 "-Xep:ThreeLetterTimeZoneID:ERROR",
416 "-Xep:ThrowIfUncheckedKnownChecked:ERROR",
417 "-Xep:ThrowNull:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200418 "-Xep:TimeUnitConversionChecker:ERROR",
419 "-Xep:ToStringReturnsNull:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200420 "-Xep:TreeToString:ERROR",
Edwin Kempinec700342021-09-28 14:34:01 +0200421 "-Xep:TruthAssertExpected:ERROR",
Dave Borowitz425ad6e2019-05-24 11:00:18 -0700422 "-Xep:TruthConstantAsserts:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200423 "-Xep:TruthGetOrDefault:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200424 "-Xep:TruthIncompatibleType:ERROR",
425 "-Xep:TruthSelfEquals:ERROR",
426 "-Xep:TryFailThrowable:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200427 "-Xep:TypeEquals:ERROR",
428 "-Xep:TypeNameShadowing:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200429 "-Xep:TypeParameterQualifier:ERROR",
Dave Borowitz425ad6e2019-05-24 11:00:18 -0700430 "-Xep:TypeParameterShadowing:ERROR",
Dave Borowitzb31519f2019-05-24 11:05:18 -0700431 "-Xep:TypeParameterUnusedInFormals:ERROR",
Dave Borowitz425ad6e2019-05-24 11:00:18 -0700432 "-Xep:URLEqualsHashCode:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200433 # "-Xep:UndefinedEquals:WARN",
Edwin Kempin7817b7f2021-09-28 13:40:12 +0200434 "-Xep:UnescapedEntity:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200435 "-Xep:UnnecessaryAssignment:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200436 "-Xep:UnnecessaryCheckNotNull:ERROR",
437 # "-Xep:UnnecessaryLambda:WARN",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200438 "-Xep:UnnecessaryMethodInvocationMatcher:ERROR",
439 "-Xep:UnnecessaryMethodReference:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200440 # "-Xep:UnnecessaryParentheses:WARN",
441 "-Xep:UnnecessaryTypeArgument:ERROR",
Dmitrii Filippov88726b92021-09-23 15:11:15 +0200442 "-Xep:UnrecognisedJavadocTag:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200443 "-Xep:UnsafeFinalization:ERROR",
444 "-Xep:UnsafeReflectiveConstructionCast:ERROR",
Dave Borowitz425ad6e2019-05-24 11:00:18 -0700445 "-Xep:UnsynchronizedOverridesSynchronized:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200446 "-Xep:UnusedAnonymousClass:ERROR",
447 "-Xep:UnusedCollectionModifiedInPlace:ERROR",
David Pursehouse79d0c3a2019-12-02 10:19:17 +0900448 "-Xep:UnusedException:ERROR",
Edwin Kempin0e35c342021-09-28 12:56:24 +0200449 "-Xep:UnusedMethod:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200450 "-Xep:UnusedNestedClass:ERROR",
Edwin Kempin4816ff92021-09-28 12:41:11 +0200451 "-Xep:UnusedVariable:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200452 "-Xep:UseBinds:ERROR",
Dmitrii Filippov26c3c832021-09-23 19:37:33 +0200453 "-Xep:UseCorrectAssertInTests:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200454 "-Xep:VarTypeName:ERROR",
Dmitrii Filippov1c76a0a2021-09-23 18:57:04 +0200455 "-Xep:VariableNameSameAsType:ERROR",
Dave Borowitz425ad6e2019-05-24 11:00:18 -0700456 "-Xep:WaitNotInLoop:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200457 "-Xep:WakelockReleasedDangerously:ERROR",
Dave Borowitzcac46302019-05-24 09:54:18 -0700458 "-Xep:WildcardImport:ERROR",
Dmitrii Filippov36dd5902021-09-23 17:30:09 +0200459 "-Xep:WithSignatureDiscouraged:ERROR",
Dmitrii Filippova30b5b42021-09-23 13:21:34 +0200460 "-Xep:WrongOneof:ERROR",
461 "-Xep:XorPower:ERROR",
462 "-Xep:ZoneIdOfZ:ERROR",
Dave Borowitzcac46302019-05-24 09:54:18 -0700463 ],
464 packages = ["error_prone_packages"],
465)
466
David Ostrovsky4b60cd72018-08-26 15:53:01 +0200467package_group(
468 name = "error_prone_packages",
469 packages = [
470 "//java/...",
471 "//javatests/...",
David Pursehousedf7c4812019-05-27 13:29:03 +0900472 "//plugins/codemirror-editor/...",
473 "//plugins/commit-message-length-validator/...",
474 "//plugins/delete-project/...",
475 "//plugins/download-commands/...",
476 "//plugins/gitiles/...",
477 "//plugins/hooks/...",
478 "//plugins/plugin-manager/...",
479 "//plugins/replication/...",
480 "//plugins/reviewnotes/...",
481 "//plugins/singleusergroup/...",
482 "//plugins/webhooks/...",
David Ostrovsky4b60cd72018-08-26 15:53:01 +0200483 ],
484)