Dave Borowitz | 938398f | 2018-09-14 14:14:25 -0700 | [diff] [blame] | 1 | load( |
| 2 | "@bazel_tools//tools/jdk:default_java_toolchain.bzl", |
| 3 | "JDK9_JVM_OPTS", |
| 4 | "default_java_toolchain", |
| 5 | ) |
David Pursehouse | b80867d | 2019-09-08 22:31:37 +0900 | [diff] [blame] | 6 | load("@rules_java//java:defs.bzl", "java_package_configuration") |
David Ostrovsky | 4b60cd7 | 2018-08-26 15:53:01 +0200 | [diff] [blame] | 7 | |
Han-Wen Nienhuys | a223f5a | 2019-04-25 12:15:41 +0200 | [diff] [blame] | 8 | exports_files(["nongoogle.bzl"]) |
| 9 | |
David Ostrovsky | 4b60cd7 | 2018-08-26 15:53:01 +0200 | [diff] [blame] | 10 | default_java_toolchain( |
| 11 | name = "error_prone_warnings_toolchain", |
David Pursehouse | a5ca033 | 2018-11-02 08:24:16 +0900 | [diff] [blame] | 12 | bootclasspath = ["@bazel_tools//tools/jdk:platformclasspath.jar"], |
Dave Borowitz | 938398f | 2018-09-14 14:14:25 -0700 | [diff] [blame] | 13 | jvm_opts = JDK9_JVM_OPTS, |
David Ostrovsky | 4b60cd7 | 2018-08-26 15:53:01 +0200 | [diff] [blame] | 14 | package_configuration = [ |
| 15 | ":error_prone", |
| 16 | ], |
| 17 | visibility = ["//visibility:public"], |
| 18 | ) |
| 19 | |
David Ostrovsky | b89332d | 2020-04-27 07:06:24 +0200 | [diff] [blame] | 20 | JDK11_JVM_OPTS = select({ |
| 21 | "@bazel_tools//src/conditions:openbsd": ["-Xbootclasspath/p:$(location @bazel_tools//tools/jdk:javac_jar)"], |
| 22 | "//conditions:default": [ |
| 23 | "--add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED", |
| 24 | "--add-exports=jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED", |
| 25 | "--add-exports=jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED", |
| 26 | "--add-exports=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED", |
| 27 | "--add-exports=jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED", |
| 28 | "--add-exports=jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED", |
| 29 | "--add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED", |
| 30 | "--add-opens=jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED", |
| 31 | "--patch-module=java.compiler=$(location @bazel_tools//tools/jdk:java_compiler_jar)", |
| 32 | "--patch-module=jdk.compiler=$(location @bazel_tools//tools/jdk:jdk_compiler_jar)", |
| 33 | "--add-opens=java.base/java.nio=ALL-UNNAMED", |
| 34 | "--add-opens=java.base/java.lang=ALL-UNNAMED", |
| 35 | ], |
| 36 | }) |
| 37 | |
| 38 | default_java_toolchain( |
| 39 | name = "error_prone_warnings_toolchain_java11", |
| 40 | bootclasspath = ["@bazel_tools//tools/jdk:platformclasspath.jar"], |
| 41 | forcibly_disable_header_compilation = False, |
| 42 | genclass = ["@bazel_tools//tools/jdk:genclass"], |
| 43 | header_compiler = ["@bazel_tools//tools/jdk:turbine"], |
| 44 | header_compiler_direct = ["@bazel_tools//tools/jdk:turbine_direct"], |
| 45 | ijar = ["@bazel_tools//tools/jdk:ijar"], |
| 46 | javabuilder = ["@bazel_tools//tools/jdk:javabuilder"], |
David Ostrovsky | b89332d | 2020-04-27 07:06:24 +0200 | [diff] [blame] | 47 | javac_supports_workers = True, |
| 48 | jvm_opts = JDK11_JVM_OPTS, |
| 49 | misc = [ |
| 50 | "-XDskipDuplicateBridges=true", |
| 51 | "-g", |
| 52 | "-parameters", |
| 53 | ], |
| 54 | package_configuration = [ |
| 55 | ":error_prone", |
| 56 | ], |
| 57 | singlejar = ["@bazel_tools//tools/jdk:singlejar"], |
| 58 | source_version = "11", |
| 59 | target_version = "11", |
| 60 | tools = [ |
| 61 | "@bazel_tools//tools/jdk:java_compiler_jar", |
Ivo List | b4d318e | 2020-11-25 11:19:53 +0000 | [diff] [blame] | 62 | "@bazel_tools//tools/jdk:javac_jar", |
David Ostrovsky | b89332d | 2020-04-27 07:06:24 +0200 | [diff] [blame] | 63 | "@bazel_tools//tools/jdk:jdk_compiler_jar", |
| 64 | ], |
| 65 | visibility = ["//visibility:public"], |
| 66 | ) |
| 67 | |
Dave Borowitz | 3b78c07 | 2019-05-24 11:27:43 -0700 | [diff] [blame] | 68 | # Error Prone errors enabled by default; see ../.bazelrc for how this is |
| 69 | # enabled. This warnings list is originally based on: |
| 70 | # https://github.com/bazelbuild/BUILD_file_generator/blob/master/tools/bazel_defs/java.bzl |
| 71 | # However, feel free to add any additional errors. Thus far they have all been pretty useful. |
David Ostrovsky | dfe7d71 | 2019-09-14 09:43:13 +0200 | [diff] [blame] | 72 | # TODO(davido): Enable ImmutableAnnotationChecker again when these issues are fixed: |
| 73 | # https://github.com/google/error-prone/issues/1348 |
| 74 | # https://github.com/bazelbuild/bazel/issues/9378 |
Dave Borowitz | cac4630 | 2019-05-24 09:54:18 -0700 | [diff] [blame] | 75 | java_package_configuration( |
| 76 | name = "error_prone", |
| 77 | javacopts = [ |
| 78 | "-XepDisableWarningsInGeneratedCode", |
Dave Borowitz | ccdc670 | 2019-05-24 10:14:03 -0700 | [diff] [blame] | 79 | "-Xep:AmbiguousMethodReference:ERROR", |
Edwin Kempin | c2d0a91 | 2019-07-01 16:10:57 +0200 | [diff] [blame] | 80 | "-Xep:AutoValueFinalMethods:ERROR", |
Dave Borowitz | ccdc670 | 2019-05-24 10:14:03 -0700 | [diff] [blame] | 81 | "-Xep:BadAnnotationImplementation:ERROR", |
| 82 | "-Xep:BadComparable:ERROR", |
| 83 | "-Xep:BoxedPrimitiveConstructor:ERROR", |
| 84 | "-Xep:CannotMockFinalClass:ERROR", |
Dave Borowitz | ae99a1b | 2019-05-24 10:15:40 -0700 | [diff] [blame] | 85 | "-Xep:ClassCanBeStatic:ERROR", |
Dave Borowitz | ccdc670 | 2019-05-24 10:14:03 -0700 | [diff] [blame] | 86 | "-Xep:ClassNewInstance:ERROR", |
David Pursehouse | e39b4f4 | 2019-06-05 15:23:20 +0900 | [diff] [blame] | 87 | "-Xep:DateFormatConstant:ERROR", |
Dave Borowitz | 9601572 | 2019-05-24 10:16:41 -0700 | [diff] [blame] | 88 | "-Xep:DefaultCharset:ERROR", |
Dave Borowitz | ccdc670 | 2019-05-24 10:14:03 -0700 | [diff] [blame] | 89 | "-Xep:DoubleCheckedLocking:ERROR", |
| 90 | "-Xep:ElementsCountedInLoop:ERROR", |
Dave Borowitz | 3cf3962 | 2019-05-24 10:17:44 -0700 | [diff] [blame] | 91 | "-Xep:EqualsHashCode:ERROR", |
| 92 | "-Xep:EqualsIncompatibleType:ERROR", |
| 93 | "-Xep:ExpectedExceptionChecker:ERROR", |
| 94 | "-Xep:Finally:ERROR", |
Dave Borowitz | 0c5fdd7 | 2019-05-24 10:22:02 -0700 | [diff] [blame] | 95 | "-Xep:FloatingPointLiteralPrecision:ERROR", |
Patrick Hiesel | f396eff | 2019-11-07 12:01:55 +0100 | [diff] [blame] | 96 | "-Xep:FormatStringAnnotation:ERROR", |
Dave Borowitz | 0c5fdd7 | 2019-05-24 10:22:02 -0700 | [diff] [blame] | 97 | "-Xep:FragmentInjection:ERROR", |
| 98 | "-Xep:FragmentNotInstantiable:ERROR", |
| 99 | "-Xep:FunctionalInterfaceClash:ERROR", |
Dave Borowitz | ef04f0e6 | 2019-05-24 10:42:22 -0700 | [diff] [blame] | 100 | "-Xep:FutureReturnValueIgnored:ERROR", |
Dave Borowitz | f66892a | 2019-05-24 10:44:32 -0700 | [diff] [blame] | 101 | "-Xep:GetClassOnEnum:ERROR", |
David Ostrovsky | dfe7d71 | 2019-09-14 09:43:13 +0200 | [diff] [blame] | 102 | "-Xep:ImmutableAnnotationChecker:OFF", |
Dave Borowitz | 0b9e581 | 2019-05-24 10:37:36 -0700 | [diff] [blame] | 103 | "-Xep:ImmutableEnumChecker:ERROR", |
Dave Borowitz | 0c5fdd7 | 2019-05-24 10:22:02 -0700 | [diff] [blame] | 104 | "-Xep:IncompatibleModifiers:ERROR", |
| 105 | "-Xep:InjectOnConstructorOfAbstractClass:ERROR", |
Dave Borowitz | b7769f3 | 2019-05-24 10:46:17 -0700 | [diff] [blame] | 106 | "-Xep:InputStreamSlowMultibyteRead:ERROR", |
| 107 | "-Xep:IterableAndIterator:ERROR", |
| 108 | "-Xep:JUnit3FloatingPointComparisonWithoutDelta:ERROR", |
| 109 | "-Xep:JUnitAmbiguousTestClass:ERROR", |
| 110 | "-Xep:LiteralClassName:ERROR", |
| 111 | "-Xep:MissingCasesInEnumSwitch:ERROR", |
| 112 | "-Xep:MissingFail:ERROR", |
Dave Borowitz | dc00c1d | 2019-05-24 10:48:49 -0700 | [diff] [blame] | 113 | "-Xep:MissingOverride:ERROR", |
Dave Borowitz | b7769f3 | 2019-05-24 10:46:17 -0700 | [diff] [blame] | 114 | "-Xep:MutableConstantField:ERROR", |
Dave Borowitz | cd7efe1 | 2019-05-24 10:52:43 -0700 | [diff] [blame] | 115 | "-Xep:NarrowingCompoundAssignment:ERROR", |
Dave Borowitz | 2bc50b4 | 2019-05-24 10:56:59 -0700 | [diff] [blame] | 116 | "-Xep:NonAtomicVolatileUpdate:ERROR", |
| 117 | "-Xep:NonOverridingEquals:ERROR", |
| 118 | "-Xep:NullableConstructor:ERROR", |
| 119 | "-Xep:NullablePrimitive:ERROR", |
| 120 | "-Xep:NullableVoid:ERROR", |
David Pursehouse | c8ccff9 | 2020-04-13 15:07:52 +0900 | [diff] [blame] | 121 | "-Xep:ObjectToString:ERROR", |
Dave Borowitz | b21dde3 | 2019-05-24 10:57:09 -0700 | [diff] [blame] | 122 | "-Xep:OperatorPrecedence:ERROR", |
Dave Borowitz | 2bc50b4 | 2019-05-24 10:56:59 -0700 | [diff] [blame] | 123 | "-Xep:OverridesGuiceInjectableMethod:ERROR", |
| 124 | "-Xep:PreconditionsInvalidPlaceholder:ERROR", |
| 125 | "-Xep:ProtoFieldPreconditionsCheckNotNull:ERROR", |
| 126 | "-Xep:ProtocolBufferOrdinal:ERROR", |
Dave Borowitz | b964049 | 2019-05-24 11:24:32 -0700 | [diff] [blame] | 127 | "-Xep:ReferenceEquality:ERROR", |
Dave Borowitz | 425ad6e | 2019-05-24 11:00:18 -0700 | [diff] [blame] | 128 | "-Xep:RequiredModifiers:ERROR", |
| 129 | "-Xep:ShortCircuitBoolean:ERROR", |
| 130 | "-Xep:SimpleDateFormatConstant:ERROR", |
| 131 | "-Xep:StaticGuardedByInstance:ERROR", |
Dave Borowitz | ccdc670 | 2019-05-24 10:14:03 -0700 | [diff] [blame] | 132 | "-Xep:StringEquality:ERROR", |
Dave Borowitz | b13bec9 | 2019-05-24 11:16:54 -0700 | [diff] [blame] | 133 | "-Xep:SynchronizeOnNonFinalField:ERROR", |
Dave Borowitz | 425ad6e | 2019-05-24 11:00:18 -0700 | [diff] [blame] | 134 | "-Xep:TruthConstantAsserts:ERROR", |
| 135 | "-Xep:TypeParameterShadowing:ERROR", |
Dave Borowitz | b31519f | 2019-05-24 11:05:18 -0700 | [diff] [blame] | 136 | "-Xep:TypeParameterUnusedInFormals:ERROR", |
Dave Borowitz | 425ad6e | 2019-05-24 11:00:18 -0700 | [diff] [blame] | 137 | "-Xep:URLEqualsHashCode:ERROR", |
| 138 | "-Xep:UnsynchronizedOverridesSynchronized:ERROR", |
David Pursehouse | 79d0c3a | 2019-12-02 10:19:17 +0900 | [diff] [blame] | 139 | "-Xep:UnusedException:ERROR", |
Dave Borowitz | 425ad6e | 2019-05-24 11:00:18 -0700 | [diff] [blame] | 140 | "-Xep:WaitNotInLoop:ERROR", |
Dave Borowitz | cac4630 | 2019-05-24 09:54:18 -0700 | [diff] [blame] | 141 | "-Xep:WildcardImport:ERROR", |
| 142 | ], |
| 143 | packages = ["error_prone_packages"], |
| 144 | ) |
| 145 | |
David Ostrovsky | 4b60cd7 | 2018-08-26 15:53:01 +0200 | [diff] [blame] | 146 | package_group( |
| 147 | name = "error_prone_packages", |
| 148 | packages = [ |
| 149 | "//java/...", |
| 150 | "//javatests/...", |
David Pursehouse | df7c481 | 2019-05-27 13:29:03 +0900 | [diff] [blame] | 151 | "//plugins/codemirror-editor/...", |
| 152 | "//plugins/commit-message-length-validator/...", |
| 153 | "//plugins/delete-project/...", |
| 154 | "//plugins/download-commands/...", |
| 155 | "//plugins/gitiles/...", |
| 156 | "//plugins/hooks/...", |
| 157 | "//plugins/plugin-manager/...", |
| 158 | "//plugins/replication/...", |
| 159 | "//plugins/reviewnotes/...", |
| 160 | "//plugins/singleusergroup/...", |
| 161 | "//plugins/webhooks/...", |
David Ostrovsky | 4b60cd7 | 2018-08-26 15:53:01 +0200 | [diff] [blame] | 162 | ], |
| 163 | ) |