commit | fe5aac7e7227ade08cc324b9bc853492ba45638b | [log] [tgz] |
---|---|---|
author | Ian Wienand <iwienand@redhat.com> | Tue Jul 20 15:01:06 2021 +1000 |
committer | Ian Wienand <iwienand@redhat.com> | Tue Jul 20 16:17:15 2021 +1000 |
tree | dacc8dda9ee7a98823081a09606ee9aa0097b303 | |
parent | 4050ed9f4c7b646b813f0b137869aee8c69a6f51 [diff] |
AccountPatchReview : fix mariadb status matching mariadb is currently using SQLException.getSQLState() (as used by getSQLStateInt()) which returns the ANSI SQLSTATE value, not the MariaDB/mysql error code [1]. The result is that the duplicate key detection doesn't work when using the mariadb connector. If you have already reviewed a file (or click "reviewed" in the file chooser) and then open it again you get a 500 error and a long backtrace including something like Caused by: java.sql.SQLIntegrityConstraintViolationException: (conn=13) Duplicate entry '3-1-1000001-file-3.txt' for key 'PRIMARY' We could either continue using getSQLState() and change this to "23000" (which covers all these values) or do as MySQL connector does and use the vendor-specific getErrorCode() call. I've taken the later approach here. [1] https://mariadb.com/kb/en/mariadb-error-codes/ Change-Id: I5762118ceb5628171b991a80fe701d160ab0d959
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 7 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-centos7[:version]
To run a Ubuntu 15.04 based Gerrit image:
docker run -p 8080:8080 gerritforge/gerrit-ubuntu15.04[:version]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.