tree dacc8dda9ee7a98823081a09606ee9aa0097b303
parent 4050ed9f4c7b646b813f0b137869aee8c69a6f51
author Ian Wienand <iwienand@redhat.com> 1626757266 +1000
committer Ian Wienand <iwienand@redhat.com> 1626761835 +1000

AccountPatchReview : fix mariadb status matching

mariadb is currently using SQLException.getSQLState() (as used by
getSQLStateInt()) which returns the ANSI SQLSTATE value, not the
MariaDB/mysql error code [1].

The result is that the duplicate key detection doesn't work when using
the mariadb connector.  If you have already reviewed a file (or click
"reviewed" in the file chooser) and then open it again you get a 500
error and a long backtrace including something like

  Caused by: java.sql.SQLIntegrityConstraintViolationException:
  (conn=13) Duplicate entry '3-1-1000001-file-3.txt' for key 'PRIMARY'

We could either continue using getSQLState() and change this to
"23000" (which covers all these values) or do as MySQL connector does
and use the vendor-specific getErrorCode() call.  I've taken the later
approach here.

[1] https://mariadb.com/kb/en/mariadb-error-codes/

Change-Id: I5762118ceb5628171b991a80fe701d160ab0d959