commit fa9510ef4a54eee029bc3791b789d2f5686fc790
author Ben Rohlfs <brohlfs@google.com> Mon Sep 14 06:42:29 2020 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Mon Sep 14 06:42:29 2020 +0000
tree 78737357ecfd925f72b3c9a3654878fb59360912
parent da710364401e356e338583fa5d6899d07287ffe5
parent 3c01b81a3c39d155fb1573895c3e9ba828b6bbe0

Merge "Remove on-render listener on detached"

polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js

diff --git a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js
index 0b02245..ab706e9 100644
--- a/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js
+++ b/polygerrit-ui/app/elements/diff/gr-diff-view/gr-diff-view.js
@@ -314,12 +314,14 @@
     this.addEventListener('open-fix-preview',
         e => this._onOpenFixPreview(e));
     this.$.cursor.push('diffs', this.$.diffHost);
-
-    const onRender = () => {
-      this.$.diffHost.removeEventListener('render', onRender);
+    this._onRenderHandler = () => {
       this.$.cursor.reInitCursor();
     };
-    this.$.diffHost.addEventListener('render', onRender);
+    this.$.diffHost.addEventListener('render', this._onRenderHandler);
+  }
+
+  detached() {
+    this.$.diffHost.removeEventListener('render', this._onRenderHandler);
   }
 
   _getLoggedIn() {