commit f825be5b4ee7de1bd8690579ab25cd759bd8c8ef
author Sergey Zakharov <zakharovsergey1000@gmail.com> Sun Jan 15 18:32:26 2023 +0400
committer Sergey Zakharov <zakharovsergey1000@gmail.com> Mon Jan 16 07:35:44 2023 +0000
tree 684cb61b9626080f97b9ac510a2d2de3dce8fe29
parent 674fddd6af76fff5a98146d906d5aef9cee3a10f

AndPredicate#compare: Remove unnecessary calculation

Since the comparison method is called in a loop, all unnecessary
actions in this method will be called several times.

The expression "&& b instanceof DataSource" is redundant because
"b instanceof DataSource" is always true if
"cmp == 0 && a instanceof DataSource"

Release-Notes: skip
Change-Id: Id697c31e4854b6e9f68200195eaf642691825ff9

java/com/google/gerrit/index/query/AndPredicate.java

diff --git a/java/com/google/gerrit/index/query/AndPredicate.java b/java/com/google/gerrit/index/query/AndPredicate.java
index 23ae312..fda961d 100644
--- a/java/com/google/gerrit/index/query/AndPredicate.java
+++ b/java/com/google/gerrit/index/query/AndPredicate.java
@@ -134,7 +134,7 @@
       cmp = a.estimateCost() - b.estimateCost();
     }
 
-    if (cmp == 0 && a instanceof DataSource && b instanceof DataSource) {
+    if (cmp == 0 && a instanceof DataSource) {
       DataSource<?> as = (DataSource<?>) a;
       DataSource<?> bs = (DataSource<?>) b;
       cmp = as.getCardinality() - bs.getCardinality();