commit f5efdd463bfb9b23209560f72033156d9a9d52dd
author Nitzan Gur-Furman <nitzan@google.com> Mon Oct 13 01:05:11 2025 -0700
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Mon Oct 13 01:05:11 2025 -0700
tree 3f8fd5d5402512c19be66cb26009dfc4d4b5c924
parent b3c10d3316295194d193762c3440e7d6aa934110
parent a1f2a9417e70711399114913082843099c3ae277

Merge "PostReviewIT: wire the mock CommentValidator as a plugin"

Documentation/rest-api-projects.txt

diff --git a/Documentation/rest-api-projects.txt b/Documentation/rest-api-projects.txt
index e00749d..4a0a602 100644
--- a/Documentation/rest-api-projects.txt
+++ b/Documentation/rest-api-projects.txt
@@ -114,8 +114,7 @@
     },
     "some-other-project": {
       "id": "some-other-project",
-       "description": "Description of some other project."
-      }
+      "description": "Description of some other project."
     },
   }
 ----
@@ -140,7 +139,7 @@
   {
     "some-project": {
       "id": "some-project",
-      _more_projects: true
+      "_more_projects": true
     }
   }
 ----

WORKSPACE

diff --git a/WORKSPACE b/WORKSPACE
index 3d32937..666137b 100644
--- a/WORKSPACE
+++ b/WORKSPACE
@@ -108,8 +108,19 @@
 
 load("@build_bazel_rules_nodejs//:index.bzl", "node_repositories", "yarn_install")
 
+NODE_20_REPO = {
+    "20.19.5-darwin_arm64": ("node-v20.19.5-darwin-arm64.tar.gz", "node-v20.19.5-darwin-arm64", "cfed7503d8d99fbcf2f52e408ec52f616058eb0867b34dbc3437259993ef5cba"),
+    "20.19.5-darwin_amd64": ("node-v20.19.5-darwin-x64.tar.gz", "node-v20.19.5-darwin-x64", "f9cff058f2766d4d0631dc69b5f7f27664b3a42ff186e25ac7e1ac269af7e696"),
+    "20.19.5-linux_arm64": ("node-v20.19.5-linux-arm64.tar.xz", "node-v20.19.5-linux-arm64", "d462267863ae8ee556039ebdf559055a8ec562c633889ef1403f3adb449ba1dd"),
+    "20.19.5-linux_ppc64le": ("node-v20.19.5-linux-ppc64le.tar.xz", "node-v20.19.5-linux-ppc64le", "ef98025e71d6d498476a95f144e353be074b24431b22eaa81bc64f921ea7d57f"),
+    "20.19.5-linux_s390x": ("node-v20.19.5-linux-s390x.tar.xz", "node-v20.19.5-linux-s390x", "a2e56c4b7fbffd0e6eef3a89e1c5945962fe85b4e2acfa59edc77a9238cc7901"),
+    "20.19.5-linux_amd64": ("node-v20.19.5-linux-x64.tar.xz", "node-v20.19.5-linux-x64", "315046739a513a70e03a4a55a8afda8cf979f30852e576075c340084e3f8ac0f"),
+    "20.19.5-windows_amd64": ("node-v20.19.5-win-x64.zip", "node-v20.19.5-win-x64", "c48159529572a5a947eef2d55d6485dfdc4ce8e67216402e2f6de52ad5d95695"),
+}
+
 node_repositories(
-    node_version = "20.14.0",
+    node_repositories = NODE_20_REPO,
+    node_version = "20.19.5",
     yarn_version = "1.22.19",
 )
 

polygerrit-ui/app/elements/admin/gr-permission/gr-permission.ts

diff --git a/polygerrit-ui/app/elements/admin/gr-permission/gr-permission.ts b/polygerrit-ui/app/elements/admin/gr-permission/gr-permission.ts
index d4df7db..ef96c2e 100644
--- a/polygerrit-ui/app/elements/admin/gr-permission/gr-permission.ts
+++ b/polygerrit-ui/app/elements/admin/gr-permission/gr-permission.ts
@@ -45,6 +45,7 @@
 } from '../../../types/events';
 import {throwingErrorCallback} from '../../shared/gr-rest-api-interface/gr-rest-apis/gr-rest-api-helper';
 import {MdSwitch} from '@material/web/switch/switch';
+import {repeat} from 'lit/directives/repeat.js';
 
 const MAX_AUTOCOMPLETE_RESULTS = 20;
 
@@ -246,7 +247,9 @@
           </div>
           <!-- end header -->
           <div class="rules">
-            ${this.rules?.map(
+            ${repeat(
+              this.rules ?? [],
+              rule => rule.id,
               (rule, index) => html`
                 <gr-rule-editor
                   .hasRange=${this.computeHasRange(this.name)}