Change position of hovercard in case no position can be determined
For hovercards Gerrit tries to find a position where the complete
hovercard is visible. In case this fails the position 'left' is
used. Most hovercard targets are on the left side of the screen,
which causes the hovercard to be displayed off screen. This happens,
if a hovercard with a huge height is supposed to be displayed in
a small window.
Now, in case of a failure, the configured default position is used
as the hovercard's position. This is right now 'right', but can be
overriden by each hovercard.
Release-Notes: skip
Change-Id: I6d829d88d67b98e5a60b336b395181db83f76615
diff --git a/polygerrit-ui/app/mixins/hovercard-mixin/hovercard-mixin.ts b/polygerrit-ui/app/mixins/hovercard-mixin/hovercard-mixin.ts
index 473a3ca..c5985bb 100644
--- a/polygerrit-ui/app/mixins/hovercard-mixin/hovercard-mixin.ts
+++ b/polygerrit-ui/app/mixins/hovercard-mixin/hovercard-mixin.ts
@@ -538,6 +538,7 @@
this.updatePositionTo(position);
if (this._isInsideViewport()) return;
}
+ this.updatePositionTo(this.position);
console.warn('Could not find a visible position for the hovercard.');
}
