Fix diff row selectiong when diff view is loaded
When the diff view is loaded the selected diff row is set to the first
diff chunk or the given line in the URL. This happens when diff view
calls `cursor.reInitCursor()` in response to the `render` event of the
diff.
This was broken by change 337210, which removed the `render-progress`
events completely, and also the continuous updating of cursor stops
that was done in response to them. So at the time of `reInitCursor()`
being called the cursor stops may not be updated/set anymore. Thus
we need a dedicated `updateStops()` call. This should be fine, because
the only other caller of `cursor.reInitCursor()` was updating the stops,
as well.
The change 337210 was identied as being the culprit of the regression by
bisecting all changes since the last known release.
This change was tested using the Dev Helper and loading any diff view.
With this change a blue selected line would show up, but not before this
change.
Release-Notes: skip
Change-Id: I12d1ebb3b8e1ee04a91f312d5dcc0b743945da16
diff --git a/polygerrit-ui/app/embed/diff/gr-diff-cursor/gr-diff-cursor.ts b/polygerrit-ui/app/embed/diff/gr-diff-cursor/gr-diff-cursor.ts
index 6a2f784..d9bf23e 100644
--- a/polygerrit-ui/app/embed/diff/gr-diff-cursor/gr-diff-cursor.ts
+++ b/polygerrit-ui/app/embed/diff/gr-diff-cursor/gr-diff-cursor.ts
@@ -296,6 +296,7 @@
* reset the scroll behavior, use reInit() instead.
*/
reInitCursor() {
+ this._updateStops();
if (!this.diffRow) {
// does not scroll during init unless requested
this.cursorManager.scrollMode = this.initialLineNumber
@@ -329,7 +330,6 @@
}
handleDiffUpdate() {
- this._updateStops();
this.reInitCursor();
}
