commit ec4df750d0ed0a42e53c58629e37379965159b31
author Dhruv Srivastava <dhruvsri@google.com> Tue Jul 07 11:33:19 2020 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Tue Jul 07 11:33:19 2020 +0000
tree fab3b27f8146f91f5ea6c7d427dff5f7f1c2d6e3
parent a835a65cd736770cfe3001a59d68d13466790864
parent f8c89f3ca0990ae50861cc49aa5e9e5e630dc6f1

Merge "Add keyboard tracking for "v" key shortcuts"

polygerrit-ui/app/behaviors/keyboard-shortcut-behavior/keyboard-shortcut-behavior.js

diff --git a/polygerrit-ui/app/behaviors/keyboard-shortcut-behavior/keyboard-shortcut-behavior.js b/polygerrit-ui/app/behaviors/keyboard-shortcut-behavior/keyboard-shortcut-behavior.js
index 2db1c09..b525a82 100644
--- a/polygerrit-ui/app/behaviors/keyboard-shortcut-behavior/keyboard-shortcut-behavior.js
+++ b/polygerrit-ui/app/behaviors/keyboard-shortcut-behavior/keyboard-shortcut-behavior.js
@@ -577,6 +577,7 @@
         detail: {
           event: e,
           goKey: this._inGoKeyMode(),
+          vKey: this._inVKeyMode(),
         },
         composed: true, bubbles: true,
       }));

polygerrit-ui/app/elements/gr-app-element.js

diff --git a/polygerrit-ui/app/elements/gr-app-element.js b/polygerrit-ui/app/elements/gr-app-element.js
index a01e8a4..db098c5 100644
--- a/polygerrit-ui/app/elements/gr-app-element.js
+++ b/polygerrit-ui/app/elements/gr-app-element.js
@@ -421,10 +421,11 @@
   }
 
   _handleShortcutTriggered(event) {
-    const {event: e, goKey} = event.detail;
+    const {event: e, goKey, vKey} = event.detail;
     // eg: {key: "k:keydown", ..., from: "gr-diff-view"}
     let key = `${e.key}:${e.type}`;
     if (goKey) key = 'g+' + key;
+    if (vKey) key = 'v+' + key;
     if (e.shiftKey) key = 'shift+' + key;
     if (e.ctrlKey) key = 'ctrl+' + key;
     if (e.metaKey) key = 'meta+' + key;