Filter owner from list of reviewers on dashboard
Change-Id: I0650d47b3b92fdb9f4d7e5d193fad95db80dd6ac
diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.js b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.js
index d8101c8..95a1554 100644
--- a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.js
+++ b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item.js
@@ -228,7 +228,9 @@
*/
_computeReviewers(change) {
if (!change || !change.reviewers || !change.reviewers.REVIEWER) return [];
- const reviewers = [...change.reviewers.REVIEWER];
+ const reviewers = [...change.reviewers.REVIEWER].filter(r =>
+ !change.owner || change.owner._account_id !== r._account_id
+ );
reviewers.sort((r1, r2) => {
if (this.account) {
if (r1._account_id === this.account._account_id) return -1;
diff --git a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_test.js b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_test.js
index 4b9424b..7a66100 100644
--- a/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_test.js
+++ b/polygerrit-ui/app/elements/change-list/gr-change-list-item/gr-change-list-item_test.js
@@ -158,6 +158,9 @@
userId, reviewerIds, reviewerNames, attSetIds, expected) {
element.account = userId ? {_account_id: userId} : null;
element.change = {
+ owner: {
+ _account_id: 99,
+ },
reviewers: {
REVIEWER: [],
},
@@ -179,6 +182,8 @@
test('compute reviewers', () => {
checkComputeReviewers(null, [], [], [], []);
checkComputeReviewers(1, [], [], [], []);
+ checkComputeReviewers(1, [2], ['a'], [], [2]);
+ checkComputeReviewers(1, [99], ['owner'], [], []);
checkComputeReviewers(
1, [2, 3, 4, 5], ['b', 'a', 'd', 'c'], [3, 4], [3, 4, 2, 5]);
checkComputeReviewers(
