| commit | e1de7a527729d1a3ff5bedfea474b4399be4281e | [log] [tgz] |
|---|---|---|
| author | Marco Miller <marco.miller@ericsson.com> | Fri Jun 14 16:07:46 2019 -0400 |
| committer | Marco Miller <marco.miller@ericsson.com> | Mon Jun 17 12:20:38 2019 -0400 |
| tree | 661f71bdf69dbba2010387b40bd7d29d3ea81b4d | |
| parent | 07031b0407e0d3812a142c94405f6333d0e6a8d8 [diff] |
ProjectControl: Allow regexes ref strings for uploads Before this change, only ref strings not starting with the regex prefix for uploads allowed the latter. This was against the documentation [1] saying that "Reference names can also be described with a regular expression by prefixing the reference name with ^." [1] https://gerrit-documentation.storage.googleapis.com/Documentation/2.15.14/access-control.html#_project_access_control_lists Bug: Issue 10763 Change-Id: I6b685a7f140d82f0278b8efec271a78d92608b94
diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectControl.java b/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectControl.java index 1a51424..76e9e98 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectControl.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/project/ProjectControl.java
@@ -262,7 +262,8 @@ private boolean canCreateChanges() { for (SectionMatcher matcher : access()) { AccessSection section = matcher.section; - if (section.getName().startsWith(NEW_CHANGE)) { + if (section.getName().startsWith(NEW_CHANGE) + || section.getName().startsWith(REGEX_PREFIX + NEW_CHANGE)) { Permission permission = section.getPermission(Permission.PUSH); if (permission != null && controlForRef(section.getName()).canPerform(Permission.PUSH)) { return true;