RefUtil#parseBaseRevision: Do not log an error if baseRevision is invalid
Callers should decide whether they want to log the
InvalidRevisionException that is thrown in this case. All current
callers pass in user provided input, if that is invalid it's a 400 Bad
Request, but nothing that should be logged as server error.
Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: Ifdbac1bccea17f1e45a2c84b8869f9abafbd6518
diff --git a/java/com/google/gerrit/server/project/RefUtil.java b/java/com/google/gerrit/server/project/RefUtil.java
index 44c4f86..5d6379a 100644
--- a/java/com/google/gerrit/server/project/RefUtil.java
+++ b/java/com/google/gerrit/server/project/RefUtil.java
@@ -55,7 +55,6 @@
"Cannot resolve \"%s\" in project \"%s\"", baseRevision, projectName.get());
throw new InvalidRevisionException(baseRevision);
} catch (RevisionSyntaxException err) {
- logger.atSevere().withCause(err).log("Invalid revision syntax \"%s\"", baseRevision);
throw new InvalidRevisionException(baseRevision);
}
}
