Revert "Attach o=STAR on change list queries in frontend."
This reverts commit 0cfb4525ca303e2a86cd76ccc66be3049bf899e6.
Reason for revert: the request on backend doesn't work correctly for anonymous users
Change-Id: I95e5df621b5d5e1efa0280c37cab27294c5fb2e0
diff --git a/java/com/google/gerrit/httpd/raw/IndexPreloadingUtil.java b/java/com/google/gerrit/httpd/raw/IndexPreloadingUtil.java
index 36fa61b..402e48a 100644
--- a/java/com/google/gerrit/httpd/raw/IndexPreloadingUtil.java
+++ b/java/com/google/gerrit/httpd/raw/IndexPreloadingUtil.java
@@ -87,8 +87,7 @@
ImmutableSet.of(
ListChangesOption.LABELS,
ListChangesOption.DETAILED_ACCOUNTS,
- ListChangesOption.SUBMIT_REQUIREMENTS,
- ListChangesOption.STAR);
+ ListChangesOption.SUBMIT_REQUIREMENTS);
public static final ImmutableSet<ListChangesOption> CHANGE_DETAIL_OPTIONS =
ImmutableSet.of(
diff --git a/polygerrit-ui/app/services/gr-rest-api/gr-rest-api-impl.ts b/polygerrit-ui/app/services/gr-rest-api/gr-rest-api-impl.ts
index ceb5e9d..ba6e384 100644
--- a/polygerrit-ui/app/services/gr-rest-api/gr-rest-api-impl.ts
+++ b/polygerrit-ui/app/services/gr-rest-api/gr-rest-api-impl.ts
@@ -1016,12 +1016,6 @@
});
}
- /**
- * Construct the uri to get list of changes.
- *
- * If options is undefined then default options (see _getChangesOptionsHex) is
- * used.
- */
getRequestForGetChanges(
changesPerPage?: number,
query?: string[] | string,
@@ -1050,12 +1044,6 @@
return request;
}
- /**
- * For every query fetches the matching changes.
- *
- * If options is undefined then default options (see _getChangesOptionsHex) is
- * used.
- */
getChangesForMultipleQueries(
changesPerPage?: number,
query?: string[],
@@ -1097,12 +1085,6 @@
});
}
- /**
- * Fetches changes that match the query.
- *
- * If options is undefined then default options (see _getChangesOptionsHex) is
- * used.
- */
getChanges(
changesPerPage?: number,
query?: string,
@@ -1208,7 +1190,6 @@
ListChangesOption.LABELS,
ListChangesOption.DETAILED_ACCOUNTS,
ListChangesOption.SUBMIT_REQUIREMENTS,
- ListChangesOption.STAR,
];
return listChangesOptionsToHex(...options);
diff --git a/polygerrit-ui/app/utils/change-util.ts b/polygerrit-ui/app/utils/change-util.ts
index a62fcf3..7de5e7e 100644
--- a/polygerrit-ui/app/utils/change-util.ts
+++ b/polygerrit-ui/app/utils/change-util.ts
@@ -90,19 +90,14 @@
// Skip mergeability data.
SKIP_MERGEABLE: 22,
- // Skip diffstat computation that compute the insertions field (number of lines inserted) and
- // deletions field (number of lines deleted)
+ /**
+ * Skip diffstat computation that compute the insertions field (number of lines inserted) and
+ * deletions field (number of lines deleted)
+ */
SKIP_DIFFSTAT: 23,
- // Include the evaluated submit requirements for the caller.
+ /** Include the evaluated submit requirements for the caller. */
SUBMIT_REQUIREMENTS: 24,
-
- // Include custom keyed values.
- CUSTOM_KEYED_VALUES: 25,
-
- // Include the 'starred' field, that is if the change is starred by the
- // current user.
- STAR: 26,
};
export function listChangesOptionsToHex(...args: number[]) {