commit | 74a03beeb43dbbec6d99b708a1fa0a875cf887cd | [log] [tgz] |
---|---|---|
author | Edwin Kempin <ekempin@google.com> | Mon Feb 12 07:49:46 2024 +0000 |
committer | Edwin Kempin <ekempin@google.com> | Mon Feb 12 08:06:20 2024 +0000 |
tree | 3d0e3c1b56950dbe4c9be7fb15a881701413c3a3 | |
parent | 9e041a485443774b14500982b05fceaeb0b01b5d [diff] |
Support conditional attention set updates Attention set updates are often triggered by other actions (e.g. adding a reviewer causes the reviewer to be added to the attention set). The other actions are usually done in the same BatchUpdate by preceding ops. So far the attention set update is always decided at the moment when the ops are created. This means the attention set update can only be based on the request input but not on the result of the preceding ops (since at the moment when the op for the attention set is created the preceding ops haven't been executed yet). With this change we allow setting a condition for attention set updates that is only checked at the moment when the attention set op is executed, i.e. after all preceding ops have been executed and their result is available. In a follow-up change we will make use of this to schedule conditional attention set updates when applying votes on outdated patch sets. E.g. the change owner should only be added to the attention set if the votes have been copied to the current patch set (but this we know only after the PostReviewOp has been executed). Release-Notes: skip Bug: Google b/262017722 Change-Id: Iba9e5617f6fc626a6162a8f504a37e47557795e7 Signed-off-by: Edwin Kempin <ekempin@google.com>
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.