| commit | 9e041a485443774b14500982b05fceaeb0b01b5d | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Fri Feb 09 14:34:38 2024 +0000 |
| committer | Edwin Kempin <ekempin@google.com> | Fri Feb 09 14:49:05 2024 +0000 |
| tree | f923e70d04848e201ea7e7a0f1b76b956d03f9df | |
| parent | 48b299e2c0a6c8f91c41484e2b87b1bc317b5625 [diff] |
PostReviewOp: Add reviewer on current patch set Votes may be applied on outdated patch sets, using a ChangeUpdate that was created for the outdated patch set. Reviewers however cannot be added on outdated patch sets, but only on the change. This means reviewers should always be added using a ChangeUpdate that was created for the current patch set. This is important so that updates on the current patch set that are done by other ops within the same BatchUpdate after PostReviewOp was executed can see the reviewer updates. E.g. the AddToAttentionSetOp, that updates the attention set on the current patch set, needs to see newly added reviewers, as otherwise attention set updates for these reviewers are dropped (ChangeUpdate#updateAttentionSet drops attention set updates for users that are not active on the change, i.e. for users that are neither change owner, uploader nor reviewer). This becomes relevant with a follow-up change that wants to add users that are voting on outdated patch sets, that are not reviewers yet and which become reviewers only by voting on the change, to the attention set if any of their votes is not copied to the current patch set. Release-Notes: skip Bug: Google b/262017722 Change-Id: Idc99e6c6806022f94233b2bcd27de6f47c15baea Signed-off-by: Edwin Kempin <ekempin@google.com>
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.