| commit | d99261d609e21703e3b21bb0cd922c8b2ddc4029 | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Mon May 09 09:57:27 2022 +0200 |
| committer | Edwin Kempin <ekempin@google.com> | Mon May 09 09:57:27 2022 +0200 |
| tree | 9f7d417004a60feadabddd5b23a332fa2fce690e | |
| parent | 15956008aa33fefc48ca14ea4ceb2e19c12154d2 [diff] |
Simplify change kind matching Change kind is an enum, but matching the change kind is not as easy as checking if it is one of the enum values. This is because some enum value are special cases of other enum values, e.g. NO_CHANGE is a more trivial case of NO_CODE_CHANGE, and hence matching should take those into account as well. So far this matching looking was implemented in ChangeKindPredicate. Move this logic into ChangeKind so that it can be reused from other places too, e.g. ReplaceOp wants to skip the email notification if it is a trivial rebase (or no change). Checking for NO_CHANGE had been forgotten at this place and was only recently fixed by change If1ecda8fa. By moving the matching logic into ChangeKind we also hope to make caller more aware of the special matching semantics. Signed-off-by: Edwin Kempin <ekempin@google.com> Release-Notes: skip Change-Id: I574f514dba7d2c441e4efa55dfb2d3d2e623cdd7
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.