tree 9f7d417004a60feadabddd5b23a332fa2fce690e
parent 15956008aa33fefc48ca14ea4ceb2e19c12154d2
author Edwin Kempin <ekempin@google.com> 1652083047 +0200
committer Edwin Kempin <ekempin@google.com> 1652083047 +0200

Simplify change kind matching

Change kind is an enum, but matching the change kind is not as easy as
checking if it is one of the enum values. This is because some enum
value are special cases of other enum values, e.g. NO_CHANGE is a more
trivial case of NO_CODE_CHANGE, and hence matching should take those
into account as well.

So far this matching looking was implemented in ChangeKindPredicate.
Move this logic into ChangeKind so that it can be reused from other
places too, e.g. ReplaceOp wants to skip the email notification if it is
a trivial rebase (or no change). Checking for NO_CHANGE had been
forgotten at this place and was only recently fixed by change
If1ecda8fa. By moving the matching logic into ChangeKind we also hope to
make caller more aware of the special matching semantics.

Signed-off-by: Edwin Kempin <ekempin@google.com>
Release-Notes: skip
Change-Id: I574f514dba7d2c441e4efa55dfb2d3d2e623cdd7