Trace execution time for loading all group names
Loading all group names is done frequently, e.g. whenever a group name
is suggested or the 'ownerin' search predicate is being used (to resolve
group name to group UUID). To investigate slow requests it may be
important to know how long this step is taking. We usually trace all
accesses to NoteDb, but somehow here we forgot to do tracing.
Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I387190b7e2c60c07064ea9ee33fa53f6bb8b6fb4
diff --git a/java/com/google/gerrit/server/group/db/GroupNameNotes.java b/java/com/google/gerrit/server/group/db/GroupNameNotes.java
index cdba81f..7c4fb16f9 100644
--- a/java/com/google/gerrit/server/group/db/GroupNameNotes.java
+++ b/java/com/google/gerrit/server/group/db/GroupNameNotes.java
@@ -35,6 +35,9 @@
import com.google.gerrit.exceptions.DuplicateKeyException;
import com.google.gerrit.git.ObjectIds;
import com.google.gerrit.server.git.meta.VersionedMetaData;
+import com.google.gerrit.server.logging.Metadata;
+import com.google.gerrit.server.logging.TraceContext;
+import com.google.gerrit.server.logging.TraceContext.TraceTimer;
import java.io.IOException;
import java.util.Collection;
import java.util.Map;
@@ -210,7 +213,11 @@
if (ref == null) {
return ImmutableList.of();
}
- try (RevWalk revWalk = new RevWalk(repository);
+ try (TraceTimer ignored =
+ TraceContext.newTimer(
+ "Loading all groups",
+ Metadata.builder().noteDbRefName(RefNames.REFS_GROUPNAMES).build());
+ RevWalk revWalk = new RevWalk(repository);
ObjectReader reader = revWalk.getObjectReader()) {
RevCommit notesCommit = revWalk.parseCommit(ref.getObjectId());
NoteMap noteMap = NoteMap.read(reader, notesCommit);
