Merge changes Id3095a54,Id00e19d6 * changes: Make comment removal element less obtrusive Invert comment action alignments
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-comment-thread/gr-diff-comment-thread.html b/polygerrit-ui/app/elements/diff/gr-diff-comment-thread/gr-diff-comment-thread.html index d7c296b..288cd17 100644 --- a/polygerrit-ui/app/elements/diff/gr-diff-comment-thread/gr-diff-comment-thread.html +++ b/polygerrit-ui/app/elements/diff/gr-diff-comment-thread/gr-diff-comment-thread.html
@@ -30,6 +30,7 @@ white-space: normal; } #actions { + margin-left: auto; padding: .5em .7em; } #container { @@ -41,11 +42,10 @@ #commentInfoContainer { border-top: 1px dotted #bbb; display: flex; - justify-content: space-between; } #unresolvedLabel { font-family: var(--font-family); - margin: auto 0 auto auto; + margin: auto 0; padding: .5em .7em; } </style> @@ -67,6 +67,7 @@ </template> <div id="commentInfoContainer" hidden$="[[_hideActions(_showActions, _lastComment)]]"> + <span id="unresolvedLabel" hidden$="[[!_unresolved]]">Unresolved</span> <div id="actions"> <gr-button id="replyBtn" class="action reply" on-tap="_handleCommentReply">Reply</gr-button> @@ -77,7 +78,6 @@ <gr-button id="doneBtn" class="action done" on-tap="_handleCommentDone"> Done</gr-button> </div> - <span id="unresolvedLabel" hidden$="[[!_unresolved]]">Unresolved</span> </div> </div> <gr-rest-api-interface id="restAPI"></gr-rest-api-interface>
diff --git a/polygerrit-ui/app/elements/diff/gr-diff-comment/gr-diff-comment.html b/polygerrit-ui/app/elements/diff/gr-diff-comment/gr-diff-comment.html index ca22942..7023e0b 100644 --- a/polygerrit-ui/app/elements/diff/gr-diff-comment/gr-diff-comment.html +++ b/polygerrit-ui/app/elements/diff/gr-diff-comment/gr-diff-comment.html
@@ -89,10 +89,15 @@ } .actions { display: flex; + justify-content: flex-end; padding-top: 0; } .action { - margin-right: .5em; + margin-left: .5em; + } + .rightActions { + display: flex; + justify-content: flex-end; } .editMessage { display: none; @@ -180,7 +185,7 @@ align-items: center; display: flex; flex: 1; - justify-content: flex-end; + margin: 0; } .resolve label { color: #333; @@ -193,8 +198,8 @@ width: 100%; } #deleteBtn { + color: #666; display: none; - margin-top: .5em; } #deleteBtn.showDeleteButtons { display: block; @@ -217,6 +222,13 @@ <div class="headerMiddle"> <span class="collapsedContent">[[comment.message]]</span> </div> + <gr-button + id="deleteBtn" + link + class$="action delete [[_computeDeleteButtonClass(_isAdmin, draft)]]" + on-tap="_handleCommentDelete"> + (Delete) + </gr-button> <a class="date" href$="[[_computeLinkToComment(comment)]]" on-tap="_handleLinkTap"> <gr-date-formatter has-tooltip @@ -258,14 +270,6 @@ </div> </div> <div class="actions humanActions" hidden$="[[!_showHumanActions]]"> - <gr-button class="action edit hideOnPublished" on-tap="_handleEdit"> - Edit</gr-button> - <gr-button class="action save hideOnPublished" on-tap="_handleSave" - disabled$="[[_computeSaveDisabled(_messageText)]]">Save</gr-button> - <gr-button class="action cancel hideOnPublished" - on-tap="_handleCancel" hidden>Cancel</gr-button> - <gr-button class="action discard hideOnPublished" - on-tap="_handleDiscard">Discard</gr-button> <div class="action resolve hideOnPublished"> <label> <input type="checkbox" @@ -277,12 +281,16 @@ <div class="action unresolved hideOnPublished" hidden$="[[resolved]]"> Unresolved </div> - <gr-button - id="deleteBtn" - class$="action delete [[_computeDeleteButtonClass(_isAdmin, draft)]]" - on-tap="_handleCommentDelete"> - Delete - </gr-button> + <div class="rightActions"> + <gr-button class="action edit hideOnPublished" on-tap="_handleEdit"> + Edit</gr-button> + <gr-button class="action save hideOnPublished" on-tap="_handleSave" + disabled$="[[_computeSaveDisabled(_messageText)]]">Save</gr-button> + <gr-button class="action cancel hideOnPublished" + on-tap="_handleCancel" hidden>Cancel</gr-button> + <gr-button class="action discard hideOnPublished" + on-tap="_handleDiscard">Discard</gr-button> + </div> </div> <div class="actions robotActions" hidden$="[[!_showRobotActions]]"> <gr-button class="action fix"