commit | d0cab3901b51617289c84abc823782f0a7d0dc7a | [log] [tgz] |
---|---|---|
author | David Pursehouse <dpursehouse@collab.net> | Mon Nov 12 18:05:24 2018 +0000 |
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | Mon Nov 12 18:05:24 2018 +0000 |
tree | 0fc36daffc9e68f89b79cb8168dac34e0cde337b | |
parent | 7d335da86625ef67a805b988118af5ff6d82d92f [diff] | |
parent | cdb6d777a517d27c264e9c029e6c4ba85669f2be [diff] |
Merge changes I669da24b,I9e098d0c * changes: Use Provider<PersonIdent> in CreateProject @Singleton Initialize CreateProjectArgs#rejectEmptyCommit in ctor
diff --git a/polygerrit-ui/app/elements/shared/gr-dropdown/gr-dropdown.js b/polygerrit-ui/app/elements/shared/gr-dropdown/gr-dropdown.js index dcb428f..3d9d36b 100644 --- a/polygerrit-ui/app/elements/shared/gr-dropdown/gr-dropdown.js +++ b/polygerrit-ui/app/elements/shared/gr-dropdown/gr-dropdown.js
@@ -229,7 +229,7 @@ if (typeof link.url === 'undefined') { return ''; } - if (link.target) { + if (link.target || !link.url.startsWith('/')) { return link.url; } return this._computeRelativeURL(link.url);
diff --git a/polygerrit-ui/app/elements/shared/gr-dropdown/gr-dropdown_test.html b/polygerrit-ui/app/elements/shared/gr-dropdown/gr-dropdown_test.html index 456f235..7bb4dce 100644 --- a/polygerrit-ui/app/elements/shared/gr-dropdown/gr-dropdown_test.html +++ b/polygerrit-ui/app/elements/shared/gr-dropdown/gr-dropdown_test.html
@@ -73,6 +73,12 @@ test('link URLs', () => { assert.equal( + element._computeLinkURL({url: 'http://example.com/test'}), + 'http://example.com/test'); + assert.equal( + element._computeLinkURL({url: 'https://example.com/test'}), + 'https://example.com/test'); + assert.equal( element._computeLinkURL({url: '/test'}), '//' + window.location.host + '/test'); assert.equal(