commit cbf5f573b0eef5c7e63a56cbecf2ae1f78464e39
author David Pursehouse <dpursehouse@collab.net> Thu May 17 01:27:52 2018 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Thu May 17 01:27:52 2018 +0000
tree eaaa6736665b46b1832d9c01a25783be88ef5be1
parent f12685793d701ab2257ecb735f58b2c56fb82e6f
parent f639651d7b5d4f1ea3a3e44967e79ad0ac6aba45

Merge "ProjectBasicAuthFilter: Add comment why cause is not logged"

java/com/google/gerrit/httpd/ProjectBasicAuthFilter.java

diff --git a/java/com/google/gerrit/httpd/ProjectBasicAuthFilter.java b/java/com/google/gerrit/httpd/ProjectBasicAuthFilter.java
index 55bd4d5..6174644 100644
--- a/java/com/google/gerrit/httpd/ProjectBasicAuthFilter.java
+++ b/java/com/google/gerrit/httpd/ProjectBasicAuthFilter.java
@@ -167,6 +167,8 @@
       rsp.sendError(SC_UNAUTHORIZED);
       return false;
     } catch (AuthenticationFailedException e) {
+      // This exception is thrown if the user provided wrong credentials, we don't need to log a
+      // stacktrace for it.
       log.warn(authenticationFailedMsg(username, req) + ": " + e.getMessage());
       rsp.sendError(SC_UNAUTHORIZED);
       return false;