Reduce change spamming from CI Now that the checks integration is reliable and clear enough in terms of messaging, the extra spamming from the CI on the change log can be reduced to a minimum avoiding the redundant feedback on validation and build logs URLs. Change-Id: Idd23d088c5238ecdcd1106a378cf65e198b77782
diff --git a/Jenkinsfile b/Jenkinsfile index 53a1cc7..085cc65 100644 --- a/Jenkinsfile +++ b/Jenkinsfile
@@ -23,7 +23,6 @@ static final long curlTimeout = 10000 static final int waitForResultTimeout = 10000 static final String gerritRepositoryNameSha1Suffix = "-a6a0e4682515f3521897c5f950d1394f4619d928" - static final resTicks = [ 'ABORTED':'\u26aa', 'SUCCESS':'\u2705', 'FAILURE':'\u274c' ] } class Change { @@ -241,25 +240,6 @@ return codeStyleFiles } -def createCodeStyleMsgBody(build, label) { - def codeStyleFiles = findCodestyleFilesInLog(build) - def formattingMsg = label < 0 ? ('The following files need formatting:\n ' + - codeStyleFiles.join('\n ')) : 'All files are correctly formatted' - def url = build.url + "consoleText" - - return "${Globals.resTicks[build.result]} $formattingMsg\n (${url})" -} - -def createVerifyMsgBody(builds) { - def msgList = builds.collect { type, build -> [ - 'type': type, 'res': build.result, 'url': build.url + "consoleText" ] - } - - return msgList.collect { - "${Globals.resTicks[it.res]} ${it.type} : ${it.res}\n (${it.url})" - } .join('\n') -} - node ('master') { if (hasChangeNumber()) { @@ -286,18 +266,14 @@ stage('Report to Gerrit'){ resCodeStyle = getLabelValue(1, Builds.codeStyle.result) - gerritReview( - labels: ['Code-Style': resCodeStyle], - message: createCodeStyleMsgBody(Builds.codeStyle, resCodeStyle)) + gerritReview labels: ['Code-Style': resCodeStyle] postCheck(new GerritCheck("codestyle", Builds.codeStyle)) def verificationResults = Builds.verification.collect { k, v -> v } def resVerify = verificationResults.inject(1) { acc, build -> getLabelValue(acc, build.result) } - gerritReview( - labels: ['Verified': resVerify], - message: createVerifyMsgBody(Builds.verification)) + gerritReview labels: ['Verified': resVerify] Builds.verification.each { type, build -> postCheck( new GerritCheck(type, build)