commit c8680b2a0b643005f3ada6a540782026ac0a0989
author Gal Paikin <paiking@google.com> Tue Oct 15 13:05:35 2019 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Tue Oct 15 13:05:35 2019 +0000
tree c813dc86abbe5c98698ea0d669589c80045d6f2c
parent 72a3c8d2b460289b9978b742f85e6fe496852e5d
parent 4a807cdcfb581912900cd2d34e50c37f394191da

Merge "Add missing read permission test for Revert endpoint"

javatests/com/google/gerrit/acceptance/api/change/RevertIT.java

diff --git a/javatests/com/google/gerrit/acceptance/api/change/RevertIT.java b/javatests/com/google/gerrit/acceptance/api/change/RevertIT.java
index 5219e92..092ca45 100644
--- a/javatests/com/google/gerrit/acceptance/api/change/RevertIT.java
+++ b/javatests/com/google/gerrit/acceptance/api/change/RevertIT.java
@@ -37,6 +37,7 @@
 import com.google.gerrit.extensions.common.PureRevertInfo;
 import com.google.gerrit.extensions.restapi.BadRequestException;
 import com.google.gerrit.extensions.restapi.ResourceConflictException;
+import com.google.gerrit.extensions.restapi.ResourceNotFoundException;
 import com.google.gerrit.reviewdb.client.RefNames;
 import com.google.gerrit.server.ChangeUtil;
 import com.google.gerrit.server.permissions.PermissionDeniedException;
@@ -393,6 +394,24 @@
         .contains("not permitted: create change on refs/heads/master");
   }
 
+  @Test
+  public void cantCreateRevertWithoutReadPermission() throws Exception {
+    PushOneCommit.Result r = createChange();
+    gApi.changes().id(r.getChangeId()).revision(r.getCommit().name()).review(ReviewInput.approve());
+    gApi.changes().id(r.getChangeId()).revision(r.getCommit().name()).submit();
+
+    projectOperations
+        .project(project)
+        .forUpdate()
+        .add(block(Permission.READ).ref("refs/heads/master").group(REGISTERED_USERS))
+        .update();
+
+    ResourceNotFoundException thrown =
+        assertThrows(
+            ResourceNotFoundException.class, () -> gApi.changes().id(r.getChangeId()).revert());
+    assertThat(thrown).hasMessageThat().contains("Not found: " + r.getChangeId());
+  }
+
   @Override
   protected PushOneCommit.Result createChange() throws Exception {
     return createChange("refs/for/master");