Merge changes I08fe58d6,I1fda1794 into stable-2.14 * changes: doc: fix the example of index activate command doc: add groups index to index activate command
diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/account/VersionedAccountDestinations.java b/gerrit-server/src/main/java/com/google/gerrit/server/account/VersionedAccountDestinations.java index 5116cfb..2bb4bb7 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/account/VersionedAccountDestinations.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/account/VersionedAccountDestinations.java
@@ -53,6 +53,9 @@ @Override protected void onLoad() throws IOException, ConfigInvalidException { + if (revision == null) { + return; + } String prefix = DestinationList.DIR_NAME + "/"; for (PathInfo p : getPathInfos(true)) { if (p.fileMode == FileMode.REGULAR_FILE) {
diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java index e042b1d..17f52dc 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/query/change/ChangeQueryBuilder.java
@@ -1047,7 +1047,7 @@ VersionedAccountDestinations d = VersionedAccountDestinations.forUser(self()); d.load(git); Set<Branch.NameKey> destinations = d.getDestinationList().getDestinations(name); - if (destinations != null) { + if (destinations != null && !destinations.isEmpty()) { return new DestinationPredicate(destinations, name); } } catch (RepositoryNotFoundException e) {
diff --git a/gerrit-server/src/test/java/com/google/gerrit/server/query/change/AbstractQueryChangesTest.java b/gerrit-server/src/test/java/com/google/gerrit/server/query/change/AbstractQueryChangesTest.java index 933e695..fdf78d5 100644 --- a/gerrit-server/src/test/java/com/google/gerrit/server/query/change/AbstractQueryChangesTest.java +++ b/gerrit-server/src/test/java/com/google/gerrit/server/query/change/AbstractQueryChangesTest.java
@@ -438,6 +438,7 @@ accountManager.authenticate(AuthRequest.forUser("anotheruser")).getAccountId(); Change change2 = insert(repo, newChange(repo), user2); + assertQuery("is:owner", change1); assertQuery("owner:" + userId.get(), change1); assertQuery("owner:" + user2, change2); @@ -2105,6 +2106,24 @@ assertQuery("-assignee:" + user.getUserName(), change2); } + @Test + public void userDestination() throws Exception { + TestRepository<Repo> repo = createProject("repo"); + insert(repo, newChange(repo)); + + assertThatQueryException("destination:foo") + .hasMessageThat() + .isEqualTo("Unknown named destination: foo"); + } + + @Test + public void userQuery() throws Exception { + TestRepository<Repo> repo = createProject("repo"); + insert(repo, newChange(repo)); + + assertThatQueryException("query:foo").hasMessageThat().isEqualTo("Unknown named query: foo"); + } + protected ChangeInserter newChange(TestRepository<Repo> repo) throws Exception { return newChange(repo, null, null, null, null); }