| commit | c081a164c3587039d38d8f012b50094b48b3d40d | [log] [tgz] |
|---|---|---|
| author | David Pursehouse <david.pursehouse@sonymobile.com> | Thu Oct 24 00:46:04 2013 +0000 |
| committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | Thu Oct 24 00:46:04 2013 +0000 |
| tree | b8267675fecad69c500d6c902637fb88d50344ff | |
| parent | d4b0526403d31b4b4bfeac2933327f6f0ea98157 [diff] | |
| parent | ef0bbba58df0345903fa76005e6ef4114a0d4cbc [diff] |
Merge changes I8e81d244,If03ccac0,If8ec1887 into stable-2.8 * changes: Don't mention label abbreviation in search documentation Don't mention Verified as a default label in search documentation Minor fixes in dev-plugin documentation
diff --git a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/config/DownloadScheme.java b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/config/DownloadScheme.java index 1a9e754..20eda97 100644 --- a/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/config/DownloadScheme.java +++ b/gerrit-extension-api/src/main/java/com/google/gerrit/extensions/config/DownloadScheme.java
@@ -29,6 +29,11 @@ /** @return whether this scheme requires authentication */ public abstract boolean isAuthRequired(); + /** @return whether this scheme supports authentication */ + public boolean isAuthSupported() { + return isAuthRequired(); + } + /** @return whether the download scheme is enabled */ public abstract boolean isEnabled(); }
diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeJson.java b/gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeJson.java index d6ecc5e..f64e424 100644 --- a/gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeJson.java +++ b/gerrit-server/src/main/java/com/google/gerrit/server/change/ChangeJson.java
@@ -855,7 +855,7 @@ } ChangeControl ctl = control(cd); - if (!scheme.isAuthRequired() + if (!scheme.isAuthSupported() && !ctl.forUser(anonymous).isPatchVisible(in, db.get())) { continue; }