commit | ba9329cfe1f5e8db7c7f2cdd90a4e532f6ba4b19 | [log] [tgz] |
---|---|---|
author | Ben Rohlfs <brohlfs@google.com> | Tue May 16 10:05:12 2023 +0200 |
committer | Ben Rohlfs <brohlfs@google.com> | Tue May 16 10:48:33 2023 +0200 |
tree | d2ce5520a8c89b1cdfc6b2a43413194b619b1008 | |
parent | 2ce9a95bd08a63e23f53e2731c19b4230b77f409 [diff] |
Fix focus handling for comment replies Since we have included unsaved comment drafts into the comment model we have an issue with replying to comments when two `gr-comment-thread` instances are in the DOM for the same thread. `gr-comment` would just universally identify itself in `firstWillUpdate()` whether is has to go into editing mode or not. But only one of the two widgets should go into editing mode: The one that the user has interacted with. Fixing this means moving the responsibility up one level from `gr-comment` into `gr-comment-thread`. The thread will either request going into editing mode when the thread is completely new, or when the user has requested to reply with editing intention. While debugging we have seen a lot of `focus()` calls to `gr-comment` and `gr-textarea` that had no effect, because the `<textarea>` was not in the DOM. We are leaving comments for future developers to be aware of this potential issue. Release-Notes: skip Google-Bug-Id: b/282196918 Change-Id: I6deac7dd897eb15f187ac739e10c5d15a5dd25a4
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.