tree d2ce5520a8c89b1cdfc6b2a43413194b619b1008
parent 2ce9a95bd08a63e23f53e2731c19b4230b77f409
author Ben Rohlfs <brohlfs@google.com> 1684224312 +0200
committer Ben Rohlfs <brohlfs@google.com> 1684226913 +0200

Fix focus handling for comment replies

Since we have included unsaved comment drafts into the comment model
we have an issue with replying to comments when two `gr-comment-thread`
instances are in the DOM for the same thread. `gr-comment` would just
universally identify itself in `firstWillUpdate()` whether is has to go
into editing mode or not. But only one of the two widgets should go into
editing mode: The one that the user has interacted with.

Fixing this means moving the responsibility up one level from
`gr-comment` into `gr-comment-thread`. The thread will either request
going into editing mode when the thread is completely new, or when the
user has requested to reply with editing intention.

While debugging we have seen a lot of `focus()` calls to `gr-comment`
and `gr-textarea` that had no effect, because the `<textarea>` was not
in the DOM. We are leaving comments for future developers to be aware
of this potential issue.

Release-Notes: skip
Google-Bug-Id: b/282196918
Change-Id: I6deac7dd897eb15f187ac739e10c5d15a5dd25a4