commit ba39001d5b6006fa6e1678c825f525ecbfc6b47c
author Han-Wen Nienhuys <hanwen@google.com> Wed Jul 18 12:45:31 2018 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Wed Jul 18 12:45:31 2018 +0000
tree f4fab46c098109e052c29b588fcdfbec8257cc7f
parent 4f61bbce558b369361be0ada88557a60a3f9d6d0
parent 51b645bdaddcddc9e5844cbf8744d3b2e5a3d8e9

Merge "CommentJsonMigrator: add test for dryRun flag"

javatests/com/google/gerrit/server/notedb/CommentJsonMigratorTest.java

diff --git a/javatests/com/google/gerrit/server/notedb/CommentJsonMigratorTest.java b/javatests/com/google/gerrit/server/notedb/CommentJsonMigratorTest.java
index 2e19d20..2031a14 100644
--- a/javatests/com/google/gerrit/server/notedb/CommentJsonMigratorTest.java
+++ b/javatests/com/google/gerrit/server/notedb/CommentJsonMigratorTest.java
@@ -163,8 +163,16 @@
     assertThat(getLegacyFormatMapForPublishedComments(notes, oldLog.get(3)))
         .containsExactly(ps1Comment1.key, true, ps1Comment2.key, true, ps2Comment1.key, true);
 
+    // Check that dryRun doesn't touch anything.
+    String refName = RefNames.changeMetaRef(c.getId());
+    ObjectId before = repo.getRefDatabase().getRef(refName).getObjectId();
+    ProjectMigrationResult dryRunResult = migrator.migrateProject(project, repo, true);
+    ObjectId after = repo.getRefDatabase().getRef(refName).getObjectId();
+    assertThat(before).isEqualTo(after);
+    assertThat(dryRunResult.refsUpdated).isEqualTo(ImmutableList.of(refName));
+
     ChangeNotes oldNotes = notes;
-    checkMigrate(project, ImmutableList.of(RefNames.changeMetaRef(c.getId())));
+    checkMigrate(project, ImmutableList.of(refName));
 
     // Comment content is the same.
     notes = newNotes(c);