commit b891a8e4c882ee29b966439c1785276e37645752
author Stefan Beller <sbeller@google.com> Thu Jul 30 11:20:08 2015 -0700
committer Stefan Beller <sbeller@google.com> Mon Aug 03 15:20:21 2015 -0700
tree 97a568bc40017593ea1ee6a92bba7d3d231a6856
parent 55adf1e6400dd2b09ffcc0c3f06020203a83815a

Submit: Reuse db in problemsForSubmittingChangeset

Change-Id: I80451a28a32564d28a292a58663976a05ce80561

gerrit-server/src/main/java/com/google/gerrit/server/change/Submit.java

diff --git a/gerrit-server/src/main/java/com/google/gerrit/server/change/Submit.java b/gerrit-server/src/main/java/com/google/gerrit/server/change/Submit.java
index 2b8e3bc..8cba6c8 100644
--- a/gerrit-server/src/main/java/com/google/gerrit/server/change/Submit.java
+++ b/gerrit-server/src/main/java/com/google/gerrit/server/change/Submit.java
@@ -212,13 +212,13 @@
   private String problemsForSubmittingChangeset(
       ChangeSet cs, IdentifiedUser identifiedUser) {
     try {
+      ReviewDb db = dbProvider.get();
       for (PatchSet.Id psId : cs.patchIds()) {
-        ReviewDb db = dbProvider.get();
         ChangeControl changeControl = changeControlFactory
             .controlFor(psId.getParentKey(), identifiedUser);
         ChangeData c = changeDataFactory.create(db, changeControl);
 
-        if (!changeControl.isVisible(dbProvider.get())) {
+        if (!changeControl.isVisible(db)) {
           return BLOCKED_HIDDEN_SUBMIT_TOOLTIP;
         }
         if (!changeControl.canSubmit()) {