Merge "gr-create-change-dialog: Pass private-by-defaut value"
diff --git a/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog.html b/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog.html
index dacedd3..7b5d829 100644
--- a/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog.html
+++ b/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog.html
@@ -104,7 +104,7 @@
<input
type="checkbox"
id="privateChangeCheckBox"
- checked$="[[_formatBooleanString(_repoConfig.private_by_default)]]">
+ checked$="[[_formatBooleanString(privateByDefault)]]">
</span>
</section>
</div>
diff --git a/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog.js b/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog.js
index 8004faa..157d135 100644
--- a/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog.js
+++ b/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog.js
@@ -34,6 +34,7 @@
},
},
baseChange: String,
+ privateByDefault: String,
canCreate: {
type: Boolean,
notify: true,
@@ -47,8 +48,9 @@
],
attached() {
+ if (!this.repoName) { return; }
this.$.restAPI.getProjectConfig(this.repoName).then(config => {
- this._repoConfig = config;
+ this.privateByDefault = config.private_by_default;
});
},
diff --git a/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog_test.html b/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog_test.html
index 4a51d8f..09f89ff 100644
--- a/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog_test.html
+++ b/polygerrit-ui/app/elements/admin/gr-create-change-dialog/gr-create-change-dialog_test.html
@@ -102,11 +102,9 @@
});
test('new change created with private', done => {
- element._repoConfig = {
- private_by_default: {
- configured_value: 'TRUE',
- inherited_value: false,
- },
+ element.privateByDefault = {
+ configured_value: 'TRUE',
+ inherited_value: false,
};
sandbox.stub(element, '_formatBooleanString', () => {
return Promise.resolve(true);
diff --git a/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.html b/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.html
index 5b14fd4..85eea75 100644
--- a/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.html
+++ b/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.html
@@ -174,7 +174,8 @@
id="createFollowUpChange"
branch="[[change.branch]]"
base-change="[[change.id]]"
- repo-name="[[change.project]]"></gr-create-change-dialog>
+ repo-name="[[change.project]]"
+ private-by-default="[[privateByDefault]]"></gr-create-change-dialog>
</div>
</gr-confirm-dialog>
<gr-confirm-dialog
diff --git a/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.js b/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.js
index efc99a7..982267c 100644
--- a/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.js
+++ b/polygerrit-ui/app/elements/change/gr-change-actions/gr-change-actions.js
@@ -240,6 +240,7 @@
type: Object,
value() { return {}; },
},
+ privateByDefault: String,
_loading: {
type: Boolean,
diff --git a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.html b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.html
index bfa174b..ec8d7aa 100644
--- a/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.html
+++ b/polygerrit-ui/app/elements/change/gr-change-view/gr-change-view.html
@@ -394,6 +394,7 @@
edit-patchset-loaded="[[hasEditPatchsetLoaded(_patchRange.*)]]"
edit-mode="[[_editMode]]"
edit-based-on-current-patch-set="[[hasEditBasedOnCurrentPatchSet(_allPatchSets)]]"
+ private-by-default="[[_projectConfig.private_by_default]]"
on-reload-change="_handleReloadChange"
on-edit-tap="_handleEditTap"
on-stop-edit-tap="_handleStopEditTap"
