commit b4fe0613e9299b6bdcf75a69d915ef0ae2b16ee1
author Edwin Kempin <ekempin@google.com> Thu Dec 05 10:59:08 2019 +0100
committer Edwin Kempin <ekempin@google.com> Thu Dec 05 10:59:08 2019 +0100
tree bba75556830977220c39e35aa5accd0703d63e5b
parent fc8f3d037b7b71ab99df274577f91d2d37586969

CreateTag: Trim revision that is provided in input

Signed-off-by: Edwin Kempin <ekempin@google.com>
Change-Id: I2fb1cd153c6109caa9444a7c39987c0d8ca30db7

java/com/google/gerrit/server/restapi/project/CreateTag.java

diff --git a/java/com/google/gerrit/server/restapi/project/CreateTag.java b/java/com/google/gerrit/server/restapi/project/CreateTag.java
index 94ee2aa..8fdf5e4 100644
--- a/java/com/google/gerrit/server/restapi/project/CreateTag.java
+++ b/java/com/google/gerrit/server/restapi/project/CreateTag.java
@@ -88,6 +88,9 @@
     if (input.ref != null && !ref.equals(input.ref)) {
       throw new BadRequestException("ref must match URL");
     }
+    if (input.revision != null) {
+      input.revision = input.revision.trim();
+    }
     if (Strings.isNullOrEmpty(input.revision)) {
       input.revision = Constants.HEAD;
     }

javatests/com/google/gerrit/acceptance/rest/project/TagsIT.java

diff --git a/javatests/com/google/gerrit/acceptance/rest/project/TagsIT.java b/javatests/com/google/gerrit/acceptance/rest/project/TagsIT.java
index 063e9cb..3becb81 100644
--- a/javatests/com/google/gerrit/acceptance/rest/project/TagsIT.java
+++ b/javatests/com/google/gerrit/acceptance/rest/project/TagsIT.java
@@ -390,6 +390,21 @@
     assertThat(result.revision).isEqualTo(expectedRevision.name());
   }
 
+  @Test
+  public void baseRevisionIsTrimmed() throws Exception {
+    grantTagPermissions();
+
+    RevCommit revision = projectOperations.project(project).getHead("master");
+
+    TagInput input = new TagInput();
+    input.ref = "test";
+    input.revision = "\t" + revision.name();
+
+    TagInfo result = tag(input.ref).create(input).get();
+    assertThat(result.ref).isEqualTo(R_TAGS + input.ref);
+    assertThat(result.revision).isEqualTo(revision.name());
+  }
+
   private void assertTagList(FluentIterable<String> expected, List<TagInfo> actual)
       throws Exception {
     assertThat(actual).hasSize(expected.size());