Merge "Write debug log if account from commit identity is added as reviewer"
diff --git a/java/com/google/gerrit/server/change/ChangeInserter.java b/java/com/google/gerrit/server/change/ChangeInserter.java
index d1c27d5..69faf37 100644
--- a/java/com/google/gerrit/server/change/ChangeInserter.java
+++ b/java/com/google/gerrit/server/change/ChangeInserter.java
@@ -556,10 +556,16 @@
reviewerInputs.stream(),
Streams.stream(
newAddReviewerInputFromCommitIdentity(
- change, patchSetInfo.getAuthor().getAccount(), NotifyHandling.NONE)),
+ change,
+ patchSetInfo.getCommitId(),
+ patchSetInfo.getAuthor().getAccount(),
+ NotifyHandling.NONE)),
Streams.stream(
newAddReviewerInputFromCommitIdentity(
- change, patchSetInfo.getCommitter().getAccount(), NotifyHandling.NONE)))
+ change,
+ patchSetInfo.getCommitId(),
+ patchSetInfo.getCommitter().getAccount(),
+ NotifyHandling.NONE)))
.collect(toImmutableList());
}
}
diff --git a/java/com/google/gerrit/server/change/ReviewerAdder.java b/java/com/google/gerrit/server/change/ReviewerAdder.java
index ba6ba21..4f66492 100644
--- a/java/com/google/gerrit/server/change/ReviewerAdder.java
+++ b/java/com/google/gerrit/server/change/ReviewerAdder.java
@@ -81,6 +81,7 @@
import java.util.function.Function;
import org.eclipse.jgit.errors.ConfigInvalidException;
import org.eclipse.jgit.lib.Config;
+import org.eclipse.jgit.lib.ObjectId;
public class ReviewerAdder {
private static final FluentLogger logger = FluentLogger.forEnclosingClass();
@@ -125,12 +126,16 @@
}
public static Optional<InternalAddReviewerInput> newAddReviewerInputFromCommitIdentity(
- Change change, @Nullable Account.Id accountId, NotifyHandling notify) {
+ Change change, ObjectId commitId, @Nullable Account.Id accountId, NotifyHandling notify) {
if (accountId == null || accountId.equals(change.getOwner())) {
// If git ident couldn't be resolved to a user, or if it's not forged, do nothing.
return Optional.empty();
}
+ logger.atFine().log(
+ "Adding account %d from author/committer identity of commit %s as reviewer to change %d",
+ accountId.get(), commitId.name(), change.getChangeId());
+
InternalAddReviewerInput in = new InternalAddReviewerInput();
in.reviewer = accountId.toString();
in.state = REVIEWER;
diff --git a/java/com/google/gerrit/server/git/receive/ReplaceOp.java b/java/com/google/gerrit/server/git/receive/ReplaceOp.java
index 24154d60..62114b0 100644
--- a/java/com/google/gerrit/server/git/receive/ReplaceOp.java
+++ b/java/com/google/gerrit/server/git/receive/ReplaceOp.java
@@ -368,10 +368,16 @@
Streams.concat(
Streams.stream(
newAddReviewerInputFromCommitIdentity(
- change, psInfo.getAuthor().getAccount(), NotifyHandling.NONE)),
+ change,
+ psInfo.getCommitId(),
+ psInfo.getAuthor().getAccount(),
+ NotifyHandling.NONE)),
Streams.stream(
newAddReviewerInputFromCommitIdentity(
- change, psInfo.getCommitter().getAccount(), NotifyHandling.NONE)));
+ change,
+ psInfo.getCommitId(),
+ psInfo.getCommitter().getAccount(),
+ NotifyHandling.NONE)));
if (magicBranch != null) {
inputs =
Streams.concat(