Only show size bar in file list header if pref is enabled Release-Notes: skip Google-bug-id: b/261139479 Change-Id: Ia875ecd9f3a7aa27c2c10c29022a05b6b52df178
diff --git a/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.ts b/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.ts index 00d5a8c..071c489 100644 --- a/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.ts +++ b/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list.ts
@@ -955,7 +955,10 @@ <div class="path" role="columnheader">File</div> <div class="comments desktop" role="columnheader">Comments</div> <div class="comments mobile" role="columnheader" title="Comments">C</div> - <div class="sizeBars desktop" role="columnheader">Size</div> + ${when( + this.showSizeBars, + () => html`<div class="sizeBars desktop" role="columnheader">Size</div>` + )} <div class="header-stats" role="columnheader">Delta</div> <!-- endpoint: change-view-file-list-header --> ${when(showDynamicColumns, () => this.renderDynamicHeaderEndpoints())}
diff --git a/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list_test.ts b/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list_test.ts index 66f1e57..1fbddc5 100644 --- a/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list_test.ts +++ b/polygerrit-ui/app/elements/change/gr-file-list/gr-file-list_test.ts
@@ -113,6 +113,7 @@ .stub(element, '_saveReviewedState') .callsFake(() => Promise.resolve()); await element.updateComplete; + element.showSizeBars = true; // Wait for expandedFilesChanged to complete. await waitEventLoop(); }); @@ -205,7 +206,7 @@ </div> </div> <div class="desktop" role="gridcell"> - <div aria-hidden="true" class="hide sizeBars"></div> + <div aria-hidden="true" class="sizeBars"></div> </div> <div class="stats" role="gridcell"> <div>