commit a89e42885dda601d031ca5f4b034b4427250b37c
author Ben Rohlfs <brohlfs@google.com> Fri Feb 19 12:56:09 2021 +0100
committer Ben Rohlfs <brohlfs@google.com> Fri Feb 19 12:56:09 2021 +0100
tree 3fafe23446dc96bff1feb5db1879f2f99fbadf09
parent a4ae9283eaa48597788ad9e5f7491e83f247e483

Do not render more than 5 links in one check result row

This is just protecting us against mis-use of the API. We have already
seen incidents with chromium spamming us with 100 links. If they
seriously want so many links to be displayed in a useful way, then we
will have to have a separate conversation. For now a hard limit is good
enough.

Change-Id: I1ecc4c928c630e98250f8aad6b55f9d9b8413b1f

polygerrit-ui/app/elements/checks/gr-checks-results.ts

diff --git a/polygerrit-ui/app/elements/checks/gr-checks-results.ts b/polygerrit-ui/app/elements/checks/gr-checks-results.ts
index df881f3..007af97 100644
--- a/polygerrit-ui/app/elements/checks/gr-checks-results.ts
+++ b/polygerrit-ui/app/elements/checks/gr-checks-results.ts
@@ -138,7 +138,7 @@
         </td>
         <td class="summaryCol">
           <div class="summary-cell">
-            ${(this.result.links ?? []).map(this.renderLink)}
+            ${(this.result.links?.slice(0, 5) ?? []).map(this.renderLink)}
             ${this.renderSummary(this.result.summary)}
             <div class="message">
               ${this.isExpanded ? '' : this.result.message}