commit 99bd4abe2d324f316801679735cf9157c9f86b84
author David Ostrovsky <david.ostrovsky@gmail.com> Tue May 17 06:49:41 2022 +0000
committer Gerrit Code Review <noreply-gerritcodereview@google.com> Tue May 17 06:49:41 2022 +0000
tree 1d3ecd978ed5059595cd0123f1fc23bc551ee6c9
parent 65da880878089e417c07e434ee0f53b0a9743851
parent 29b7e8fe5099763c920f141aa5ac73801cd23997

Merge "GitVisibleChangeFilter: Remove unnecessary nested else clause"

java/com/google/gerrit/server/permissions/GitVisibleChangeFilter.java

diff --git a/java/com/google/gerrit/server/permissions/GitVisibleChangeFilter.java b/java/com/google/gerrit/server/permissions/GitVisibleChangeFilter.java
index 506d292..12a7841 100644
--- a/java/com/google/gerrit/server/permissions/GitVisibleChangeFilter.java
+++ b/java/com/google/gerrit/server/permissions/GitVisibleChangeFilter.java
@@ -130,11 +130,10 @@
                   notesResult -> {
                     if (!notesResult.error().isPresent()) {
                       return changeDataFactory.create(notesResult.notes());
-                    } else {
-                      logger.atWarning().withCause(notesResult.error().get()).log(
-                          "Unable to load ChangeNotes for %s", notesResult.id());
-                      return null;
                     }
+                    logger.atWarning().withCause(notesResult.error().get()).log(
+                        "Unable to load ChangeNotes for %s", notesResult.id());
+                    return null;
                   })
               .filter(Objects::nonNull);
     } catch (IOException e) {