| // Copyright (C) 2013 The Android Open Source Project |
| // |
| // Licensed under the Apache License, Version 2.0 (the "License"); |
| // you may not use this file except in compliance with the License. |
| // You may obtain a copy of the License at |
| // |
| // http://www.apache.org/licenses/LICENSE-2.0 |
| // |
| // Unless required by applicable law or agreed to in writing, software |
| // distributed under the License is distributed on an "AS IS" BASIS, |
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| // See the License for the specific language governing permissions and |
| // limitations under the License. |
| |
| package com.google.gerrit.acceptance.git; |
| |
| import static com.google.common.truth.Truth.assertThat; |
| import static com.google.common.truth.TruthJUnit.assume; |
| import static com.google.gerrit.acceptance.GitUtil.cloneProject; |
| |
| import com.google.common.collect.ImmutableSet; |
| import com.google.gerrit.acceptance.AbstractDaemonTest; |
| import com.google.gerrit.acceptance.PushOneCommit; |
| import com.google.gerrit.acceptance.TestAccount; |
| import com.google.gerrit.extensions.common.ChangeInfo; |
| import com.google.gerrit.extensions.common.EditInfo; |
| import com.google.gerrit.extensions.common.LabelInfo; |
| import com.google.gerrit.reviewdb.client.Change; |
| import com.google.gerrit.server.notedb.NotesMigration; |
| import com.google.gerrit.testutil.ConfigSuite; |
| import com.google.inject.Inject; |
| |
| import org.eclipse.jgit.lib.Config; |
| import org.junit.Before; |
| import org.junit.Test; |
| |
| import java.util.Set; |
| |
| public abstract class AbstractPushForReview extends AbstractDaemonTest { |
| @ConfigSuite.Config |
| public static Config noteDbEnabled() { |
| return NotesMigration.allEnabledConfig(); |
| } |
| |
| @Inject |
| private NotesMigration notesMigration; |
| |
| protected enum Protocol { |
| SSH, HTTP |
| } |
| |
| private String sshUrl; |
| |
| @Before |
| public void setUp() throws Exception { |
| sshUrl = sshSession.getUrl(); |
| } |
| |
| protected void selectProtocol(Protocol p) throws Exception { |
| String url; |
| switch (p) { |
| case SSH: |
| url = sshUrl; |
| break; |
| case HTTP: |
| url = admin.getHttpUrl(server); |
| break; |
| default: |
| throw new IllegalArgumentException("unexpected protocol: " + p); |
| } |
| testRepo = cloneProject(project, url + "/" + project.get()); |
| } |
| |
| @Test |
| public void testPushForMaster() throws Exception { |
| PushOneCommit.Result r = pushTo("refs/for/master"); |
| r.assertOkStatus(); |
| r.assertChange(Change.Status.NEW, null); |
| } |
| |
| @Test |
| public void testPushForMasterWithTopic() throws Exception { |
| // specify topic in ref |
| String topic = "my/topic"; |
| PushOneCommit.Result r = pushTo("refs/for/master/" + topic); |
| r.assertOkStatus(); |
| r.assertChange(Change.Status.NEW, topic); |
| |
| // specify topic as option |
| r = pushTo("refs/for/master%topic=" + topic); |
| r.assertOkStatus(); |
| r.assertChange(Change.Status.NEW, topic); |
| } |
| |
| @Test |
| public void testPushForMasterWithCc() throws Exception { |
| // cc one user |
| String topic = "my/topic"; |
| PushOneCommit.Result r = pushTo("refs/for/master/" + topic + "%cc=" + user.email); |
| r.assertOkStatus(); |
| r.assertChange(Change.Status.NEW, topic); |
| |
| // cc several users |
| TestAccount user2 = |
| accounts.create("another-user", "another.user@example.com", "Another User"); |
| r = pushTo("refs/for/master/" + topic + "%cc=" + admin.email + ",cc=" |
| + user.email + ",cc=" + user2.email); |
| r.assertOkStatus(); |
| r.assertChange(Change.Status.NEW, topic); |
| |
| // cc non-existing user |
| String nonExistingEmail = "non.existing@example.com"; |
| r = pushTo("refs/for/master/" + topic + "%cc=" + admin.email + ",cc=" |
| + nonExistingEmail + ",cc=" + user.email); |
| r.assertErrorStatus("user \"" + nonExistingEmail + "\" not found"); |
| } |
| |
| @Test |
| public void testPushForMasterWithReviewer() throws Exception { |
| // add one reviewer |
| String topic = "my/topic"; |
| PushOneCommit.Result r = pushTo("refs/for/master/" + topic + "%r=" + user.email); |
| r.assertOkStatus(); |
| r.assertChange(Change.Status.NEW, topic, user); |
| |
| // add several reviewers |
| TestAccount user2 = |
| accounts.create("another-user", "another.user@example.com", "Another User"); |
| r = pushTo("refs/for/master/" + topic + "%r=" + admin.email + ",r=" + user.email |
| + ",r=" + user2.email); |
| r.assertOkStatus(); |
| // admin is the owner of the change and should not appear as reviewer |
| r.assertChange(Change.Status.NEW, topic, user, user2); |
| |
| // add non-existing user as reviewer |
| String nonExistingEmail = "non.existing@example.com"; |
| r = pushTo("refs/for/master/" + topic + "%r=" + admin.email + ",r=" |
| + nonExistingEmail + ",r=" + user.email); |
| r.assertErrorStatus("user \"" + nonExistingEmail + "\" not found"); |
| } |
| |
| @Test |
| public void testPushForMasterAsDraft() throws Exception { |
| // create draft by pushing to 'refs/drafts/' |
| PushOneCommit.Result r = pushTo("refs/drafts/master"); |
| r.assertOkStatus(); |
| r.assertChange(Change.Status.DRAFT, null); |
| |
| // create draft by using 'draft' option |
| r = pushTo("refs/for/master%draft"); |
| r.assertOkStatus(); |
| r.assertChange(Change.Status.DRAFT, null); |
| } |
| |
| @Test |
| public void testPushForMasterAsEdit() throws Exception { |
| PushOneCommit.Result r = pushTo("refs/for/master"); |
| r.assertOkStatus(); |
| EditInfo edit = getEdit(r.getChangeId()); |
| assertThat(edit).isNull(); |
| |
| // specify edit as option |
| r = amendChange(r.getChangeId(), "refs/for/master%edit"); |
| r.assertOkStatus(); |
| edit = getEdit(r.getChangeId()); |
| assertThat(edit).isNotNull(); |
| } |
| |
| @Test |
| public void testPushForMasterWithApprovals() throws Exception { |
| PushOneCommit.Result r = pushTo("refs/for/master/%l=Code-Review"); |
| r.assertOkStatus(); |
| ChangeInfo ci = get(r.getChangeId()); |
| LabelInfo cr = ci.labels.get("Code-Review"); |
| assertThat(cr.all).hasSize(1); |
| assertThat(cr.all.get(0).name).isEqualTo("Administrator"); |
| assertThat(cr.all.get(0).value).is(1); |
| |
| PushOneCommit push = |
| pushFactory.create(db, admin.getIdent(), testRepo, PushOneCommit.SUBJECT, |
| "b.txt", "anotherContent", r.getChangeId()); |
| r = push.to("refs/for/master/%l=Code-Review+2"); |
| |
| ci = get(r.getChangeId()); |
| cr = ci.labels.get("Code-Review"); |
| assertThat(cr.all).hasSize(1); |
| assertThat(cr.all.get(0).name).isEqualTo("Administrator"); |
| assertThat(cr.all.get(0).value).is(2); |
| } |
| |
| @Test |
| public void testPushNewPatchsetToRefsChanges() throws Exception { |
| PushOneCommit.Result r = pushTo("refs/for/master"); |
| r.assertOkStatus(); |
| PushOneCommit push = |
| pushFactory.create(db, admin.getIdent(), testRepo, PushOneCommit.SUBJECT, |
| "b.txt", "anotherContent", r.getChangeId()); |
| r = push.to("refs/changes/" + r.getChange().change().getId().get()); |
| r.assertOkStatus(); |
| } |
| |
| @Test |
| public void testPushForMasterWithApprovals_MissingLabel() throws Exception { |
| PushOneCommit.Result r = pushTo("refs/for/master/%l=Verify"); |
| r.assertErrorStatus("label \"Verify\" is not a configured label"); |
| } |
| |
| @Test |
| public void testPushForMasterWithApprovals_ValueOutOfRange() throws Exception { |
| PushOneCommit.Result r = pushTo("refs/for/master/%l=Code-Review-3"); |
| r.assertErrorStatus("label \"Code-Review\": -3 is not a valid value"); |
| } |
| |
| @Test |
| public void testPushForNonExistingBranch() throws Exception { |
| String branchName = "non-existing"; |
| PushOneCommit.Result r = pushTo("refs/for/" + branchName); |
| r.assertErrorStatus("branch " + branchName + " not found"); |
| } |
| |
| @Test |
| public void testPushForMasterWithHashtags() throws Exception { |
| |
| // Hashtags currently only work when noteDB is enabled |
| assume().that(notesMigration.enabled()).isTrue(); |
| |
| // specify a single hashtag as option |
| String hashtag1 = "tag1"; |
| Set<String> expected = ImmutableSet.of(hashtag1); |
| PushOneCommit.Result r = pushTo("refs/for/master%hashtag=#" + hashtag1); |
| r.assertOkStatus(); |
| r.assertChange(Change.Status.NEW, null); |
| |
| Set<String> hashtags = gApi.changes().id(r.getChangeId()).getHashtags(); |
| assertThat((Iterable<?>)hashtags).containsExactlyElementsIn(expected); |
| |
| // specify a single hashtag as option in new patch set |
| String hashtag2 = "tag2"; |
| PushOneCommit push = |
| pushFactory.create(db, admin.getIdent(), testRepo, PushOneCommit.SUBJECT, |
| "b.txt", "anotherContent", r.getChangeId()); |
| r = push.to("refs/for/master/%hashtag=" + hashtag2); |
| r.assertOkStatus(); |
| expected = ImmutableSet.of(hashtag1, hashtag2); |
| hashtags = gApi.changes().id(r.getChangeId()).getHashtags(); |
| assertThat((Iterable<?>)hashtags).containsExactlyElementsIn(expected); |
| } |
| |
| @Test |
| public void testPushForMasterWithMultipleHashtags() throws Exception { |
| |
| // Hashtags currently only work when noteDB is enabled |
| assume().that(notesMigration.enabled()).isTrue(); |
| |
| // specify multiple hashtags as options |
| String hashtag1 = "tag1"; |
| String hashtag2 = "tag2"; |
| Set<String> expected = ImmutableSet.of(hashtag1, hashtag2); |
| PushOneCommit.Result r = pushTo("refs/for/master%hashtag=#" + hashtag1 |
| + ",hashtag=##" + hashtag2); |
| r.assertOkStatus(); |
| r.assertChange(Change.Status.NEW, null); |
| |
| Set<String> hashtags = gApi.changes().id(r.getChangeId()).getHashtags(); |
| assertThat((Iterable<?>)hashtags).containsExactlyElementsIn(expected); |
| |
| // specify multiple hashtags as options in new patch set |
| String hashtag3 = "tag3"; |
| String hashtag4 = "tag4"; |
| PushOneCommit push = |
| pushFactory.create(db, admin.getIdent(), testRepo, PushOneCommit.SUBJECT, |
| "b.txt", "anotherContent", r.getChangeId()); |
| r = push.to("refs/for/master%hashtag=" + hashtag3 + ",hashtag=" + hashtag4); |
| r.assertOkStatus(); |
| expected = ImmutableSet.of(hashtag1, hashtag2, hashtag3, hashtag4); |
| hashtags = gApi.changes().id(r.getChangeId()).getHashtags(); |
| assertThat((Iterable<?>)hashtags).containsExactlyElementsIn(expected); |
| } |
| |
| @Test |
| public void testPushForMasterWithHashtagsNoteDbDisabled() throws Exception { |
| // push with hashtags should fail when noteDb is disabled |
| assume().that(notesMigration.enabled()).isFalse(); |
| PushOneCommit.Result r = pushTo("refs/for/master%hashtag=tag1"); |
| r.assertErrorStatus("cannot add hashtags; noteDb is disabled"); |
| } |
| } |