commit | eebe777b7ea704e3eadaaf42e1e17ce27685e478 | [log] [tgz] |
---|---|---|
author | Ben Rohlfs <brohlfs@google.com> | Wed May 25 20:29:38 2022 +0200 |
committer | Ben Rohlfs <brohlfs@google.com> | Wed May 25 20:29:38 2022 +0200 |
tree | da956890bd44c890bbc60d11ab0c7bc7516521db | |
parent | b3886df395a28aa84f92740843a4e8aa725af973 [diff] |
Fix diff row selectiong when diff view is loaded When the diff view is loaded the selected diff row is set to the first diff chunk or the given line in the URL. This happens when diff view calls `cursor.reInitCursor()` in response to the `render` event of the diff. This was broken by change 337210, which removed the `render-progress` events completely, and also the continuous updating of cursor stops that was done in response to them. So at the time of `reInitCursor()` being called the cursor stops may not be updated/set anymore. Thus we need a dedicated `updateStops()` call. This should be fine, because the only other caller of `cursor.reInitCursor()` was updating the stops, as well. The change 337210 was identied as being the culprit of the regression by bisecting all changes since the last known release. This change was tested using the Dev Helper and loading any diff view. With this change a blue selected line would show up, but not before this change. Release-Notes: skip Change-Id: I12d1ebb3b8e1ee04a91f312d5dcc0b743945da16
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.