| commit | 8e5c1c6e454d02b1a4bb61b700647ae6cc4ed94e | [log] [tgz] |
|---|---|---|
| author | Luca Milanesio <luca.milanesio@gmail.com> | Fri Jan 10 14:07:43 2025 +0000 |
| committer | Luca Milanesio <luca.milanesio@gmail.com> | Fri Jan 10 09:25:34 2025 -0800 |
| tree | 08fce8ccfaf9f4f6a3da75e0ca32f6b1cd5d49f4 | |
| parent | de7c8f26e246a86ea1067a64260ba7edb2548bc0 [diff] |
Audit: fetch current user and sessionId at the beginning of the REST API Before this change, the current user and sessionId for the audit trail of the REST API were fetched at the end of the execution. For regular REST API execution, there are no specific issues in fetching user and sessionId at any time; however, when running the plugin-reload API, the Guice injections can be amended and influenced by the plugin loader, therefore the request to fetch the sessionId and user at the end of the API may fail, assuming that the plugin has impacted the HTTP-related injections. An example of the failure to reload the pull-replicaton plugin is: 1) [Guice/ErrorInCustomProvider]: OutOfScopeException: Cannot access scoped [WebSession]. Either we are not currently inside an HTTP Servlet request, or you may have forgotten to apply GuiceFilter as a servlet filter for this request. at DynamicItem.bind(DynamicItem.java:111) while locating WebSession Learn more: https://github.com/google/guice/wiki/ERROR_IN_CUSTOM_PROVIDER Retrieve the user and sessionId at the beginning of the REST-API servlet service method, making sure that the values are the same across the whole API invocation. Bug: Issue 388863156 Release-Notes: Fix OutOfScopeException when reloading plugins via REST-API Change-Id: I8e61044e969bbad0267ddb63a5615936f64094cd
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update && apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.